unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 50738@debbugs.gnu.org, mattiase@acm.org
Subject: bug#50738: `ert-deftest` bodies should not use lexical-binding=nil
Date: Thu, 23 Sep 2021 08:50:31 +0300	[thread overview]
Message-ID: <83zgs3vo0o.fsf@gnu.org> (raw)
In-Reply-To: <87ee9gtknn.fsf@gnus.org> (message from Lars Ingebrigtsen on Wed,  22 Sep 2021 22:33:48 +0200)

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Wed, 22 Sep 2021 22:33:48 +0200
> Cc: 50738@debbugs.gnu.org
> 
> Mattias Engdegård <mattiase@acm.org> writes:
> 
> > 1. Make with-temp-buffer use the current value of lexical-binding for
> > the temporary buffer, instead of always using nil.
> 
> I think that makes the most sense?  

I think it's dangerous to do this in Emacs 28.  After all, the
original issue is with ERT, whereas the change will affect gobs of
code.  After the emacs-28 branch is cut, if you feel adventurous, ...





  reply	other threads:[~2021-09-23  5:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22 11:13 bug#50738: `ert-deftest` bodies should not use lexical-binding=nil Mattias Engdegård
2021-09-22 14:26 ` Mattias Engdegård
2021-09-22 20:33 ` Lars Ingebrigtsen
2021-09-23  5:50   ` Eli Zaretskii [this message]
2021-09-25 18:33     ` Mattias Engdegård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zgs3vo0o.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=50738@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=mattiase@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).