From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 62823@debbugs.gnu.org
Subject: bug#62823: 29.0.60; Fixing a small leak in tree-sitter search functions
Date: Fri, 14 Apr 2023 11:27:22 -0700 [thread overview]
Message-ID: <EC1C1D49-DE46-44CA-864B-9FA7B9BFC6F1@gmail.com> (raw)
In-Reply-To: <83zg7bezc4.fsf@gnu.org>
> On Apr 13, 2023, at 11:45 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Thu, 13 Apr 2023 15:48:43 -0700
>>
>> When we switch to using cursors instead of nodes [1] in treesit.c for
>> search functions, we introduced a small leak: the search functions
>> allows the user to pass a predicate function, which can signal. And
>> because we are now using cursors, which needs to be freed, everytime the
>> predicate function signals, the cursor is leaked.
>>
>> I pushed a fix to master (a5eb9f6ad4e), the change is relatively
>> straightforward so I hope we can pick it into the next pretest.
>
> Thanks, but this kind of bugs should be fixed on the release branch to
> begin with (I've backported it now). If you are unsure on which
> branch to install such changes, please ask before installing.
Oops. I’ll do that the next time.
Yuan
next prev parent reply other threads:[~2023-04-14 18:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 22:48 bug#62823: 29.0.60; Fixing a small leak in tree-sitter search functions Yuan Fu
2023-04-14 6:45 ` Eli Zaretskii
2023-04-14 18:27 ` Yuan Fu [this message]
2023-09-05 23:55 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EC1C1D49-DE46-44CA-864B-9FA7B9BFC6F1@gmail.com \
--to=casouri@gmail.com \
--cc=62823@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).