From: Stefan Kangas <stefankangas@gmail.com>
To: Yuan Fu <casouri@gmail.com>
Cc: 62823-done@debbugs.gnu.org
Subject: bug#62823: 29.0.60; Fixing a small leak in tree-sitter search functions
Date: Tue, 5 Sep 2023 16:55:36 -0700 [thread overview]
Message-ID: <CADwFkm=-Js+vRnU2XYPr4xDpJz8aJU5Spw800xnYLUqN=YpfJQ@mail.gmail.com> (raw)
In-Reply-To: <BF5A7764-6DB4-40F1-A396-8842D1A5B62C@gmail.com> (Yuan Fu's message of "Thu, 13 Apr 2023 15:48:43 -0700")
Yuan Fu <casouri@gmail.com> writes:
> When we switch to using cursors instead of nodes [1] in treesit.c for
> search functions, we introduced a small leak: the search functions
> allows the user to pass a predicate function, which can signal. And
> because we are now using cursors, which needs to be freed, everytime the
> predicate function signals, the cursor is leaked.
>
> I pushed a fix to master (a5eb9f6ad4e), the change is relatively
> straightforward so I hope we can pick it into the next pretest.
>
> And sorry for introducing the leak in the first place :-(
It seems like this was already installed, so I'm closing this.
prev parent reply other threads:[~2023-09-05 23:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 22:48 bug#62823: 29.0.60; Fixing a small leak in tree-sitter search functions Yuan Fu
2023-04-14 6:45 ` Eli Zaretskii
2023-04-14 18:27 ` Yuan Fu
2023-09-05 23:55 ` Stefan Kangas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADwFkm=-Js+vRnU2XYPr4xDpJz8aJU5Spw800xnYLUqN=YpfJQ@mail.gmail.com' \
--to=stefankangas@gmail.com \
--cc=62823-done@debbugs.gnu.org \
--cc=casouri@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).