From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#62823: 29.0.60; Fixing a small leak in tree-sitter search functions Date: Fri, 14 Apr 2023 11:27:22 -0700 Message-ID: References: <83zg7bezc4.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.500.231\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31230"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62823@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 14 20:28:33 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pnO9x-0007yc-Dk for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Apr 2023 20:28:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pnO9Z-0000Ip-59; Fri, 14 Apr 2023 14:28:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pnO9S-0000GT-Hg for bug-gnu-emacs@gnu.org; Fri, 14 Apr 2023 14:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pnO9S-00010V-7A for bug-gnu-emacs@gnu.org; Fri, 14 Apr 2023 14:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pnO9S-0006Gr-28 for bug-gnu-emacs@gnu.org; Fri, 14 Apr 2023 14:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Apr 2023 18:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62823 X-GNU-PR-Package: emacs Original-Received: via spool by 62823-submit@debbugs.gnu.org id=B62823.168149686324065 (code B ref 62823); Fri, 14 Apr 2023 18:28:02 +0000 Original-Received: (at 62823) by debbugs.gnu.org; 14 Apr 2023 18:27:43 +0000 Original-Received: from localhost ([127.0.0.1]:47602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnO99-0006G5-9n for submit@debbugs.gnu.org; Fri, 14 Apr 2023 14:27:43 -0400 Original-Received: from mail-pl1-f176.google.com ([209.85.214.176]:35366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnO97-0006Fr-IY for 62823@debbugs.gnu.org; Fri, 14 Apr 2023 14:27:41 -0400 Original-Received: by mail-pl1-f176.google.com with SMTP id y6so18070869plp.2 for <62823@debbugs.gnu.org>; Fri, 14 Apr 2023 11:27:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681496855; x=1684088855; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=QW8SO/JTHoMZi3Khnr7heoxcbdvtPDP/WyWGwi884KY=; b=fau9ks+COsOzz2mnNu2R0qHWrPIjXbl//t05PTmdYYkPtdqXWn/C3YlMBw1wOkaBaX k9b77tqoUwrBlbP1G+K9DyE2rTA4dROsLKGr2V0N4FIyBv8HveEHG6hOBufk1R19Xgzq 9LBZTjGNio1PHQBd4hZ2M16mZL8IxBOBCPFiltKc/U9KK2s9Th3p9w3J2oGlUJOYU6bs UKX/0MwWiYAEy1SWBEEc2hfKHxqpCB0kB6wa1C7u5ykDLS4ydpHUYqW/HsP0wtWdvuCY 4i2kMVuCXotyaYAYzmE9XEubbTbp17mrkkdSM+tGODLRgervo27dl+iCnp2fFoow6N9s PdLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681496855; x=1684088855; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QW8SO/JTHoMZi3Khnr7heoxcbdvtPDP/WyWGwi884KY=; b=EmbyV1/cNHANRFnGQSd8ltVkVkvyt3gENYCRM3TGmulOmVQeJ8C3/dtXXf5bgXPWKJ vYhrQPtxkHdGSUnGl/kLRUipWJXyEuMH6M9ezcYX3xh57/ggajfTA9CkIIm1HZhC6fvB CkreA+BUmvz+ym2zSZirtAmtot7dT+FO+gQuWazYDRJkC1YcWFAfwoITe7KWHD5GMpkW v1Y8vKOwVRysPj2iYwKFFntOqX6rg5zw0L6dGZ5Crdba7/kL2qTtdlfY5Lfvu4IgcuoS lsJVfPp1gVAUfA+7UNqGgZ9aDb0ZimuxpVpowi9iQE0Wh/653LcSok9SnHhEamInI08d j8pw== X-Gm-Message-State: AAQBX9e+8K2/wAfZL6j/0rY0Bka086+ps+9QVclYL2qIq5CpePedQFUC 6suT2pyiBuUrzAQ+f6Uc9Dc= X-Google-Smtp-Source: AKy350beU6577oxGy/sPWhArBuBaNHshJFMmZELiY1Lfep6Mu3sBpbyhlIWGzNy60qovQcwdWKxr5g== X-Received: by 2002:a05:6a20:7b19:b0:d4:a361:fd3 with SMTP id s25-20020a056a207b1900b000d4a3610fd3mr6782048pzh.58.1681496855379; Fri, 14 Apr 2023 11:27:35 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id u36-20020a634724000000b0050bd9c8c53dsm3027480pga.23.2023.04.14.11.27.34 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Apr 2023 11:27:35 -0700 (PDT) In-Reply-To: <83zg7bezc4.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.500.231) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259955 Archived-At: > On Apr 13, 2023, at 11:45 PM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Thu, 13 Apr 2023 15:48:43 -0700 >>=20 >> When we switch to using cursors instead of nodes [1] in treesit.c for >> search functions, we introduced a small leak: the search functions >> allows the user to pass a predicate function, which can signal. And >> because we are now using cursors, which needs to be freed, everytime = the >> predicate function signals, the cursor is leaked. >>=20 >> I pushed a fix to master (a5eb9f6ad4e), the change is relatively >> straightforward so I hope we can pick it into the next pretest. >=20 > Thanks, but this kind of bugs should be fixed on the release branch to > begin with (I've backported it now). If you are unsure on which > branch to install such changes, please ask before installing. Oops. I=E2=80=99ll do that the next time. Yuan=