bug#48234: [PATCH] Remove debugging message from js.el

bug#48234: [PATCH] Remove debugging message from js.el

[Matt Beshara]

[-- Attachment #1.1: Type: text/plain, Size: 508 bytes --]

Hello Emacs devs,
I was using JavaScript mode a while ago and noticed that the 
string “test” appeared in the echo area after performing certain 
commands.  I found that a debugging message had been left in js.el 
for quite a while.  This patch removes it.

Also, I would like to make it known that I have completed the FSF 
copyright assignment paperwork.  It shouldn’t be necessary for 
this trivial patch, but I plan on submitting more patches in 
future.

Thanks for your time,
Matt


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 239 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2.1: 0001-Remove-unnecessary-call-to-message.patch --]
[-- Type: text/x-patch, Size: 727 bytes --]

From fac0e58c884024d586ad9b222269b4fcd6409365 Mon Sep 17 00:00:00 2001
From: Matt Beshara <m@mfa.pw>
Date: Wed, 7 Apr 2021 21:25:21 +1000
Subject: [PATCH] Remove unnecessary call to message

---
 lisp/progmodes/js.el | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el
index a942235f47..eeb85d9df0 100644
--- a/lisp/progmodes/js.el
+++ b/lisp/progmodes/js.el
@@ -1340,7 +1340,6 @@ LIMIT defaults to point."
 
 (defun js--end-of-defun-nested ()
   "Helper function for `js-end-of-defun'."
-  (message "test")
   (let* (pitem
          (this-end (save-excursion
                      (and (setq pitem (js--beginning-of-defun-nested))
-- 
2.24.3 (Apple Git-128)


[-- Attachment #2.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 239 bytes --]

bug#48234: [PATCH] Remove debugging message from js.el

[Lars Ingebrigtsen]

Matt Beshara <m@mfa.pw> writes:

> I was using JavaScript mode a while ago and noticed that the string
> “test” appeared in the echo area after performing certain commands.  I
> found that a debugging message had been left in js.el for quite a
> while.  This patch removes it.

Thanks; applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#48234: [PATCH] Remove debugging message from js.el

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > Also, I would like to make it known that I have completed the FSF 
  > copyright assignment paperwork.  It shouldn’t be necessary for 
  > this trivial patch, but I plan on submitting more patches in 
  > future.

Thank you for arranging to contribute.

-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)