unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Matt Beshara <m@mfa.pw>
To: 48234@debbugs.gnu.org
Subject: bug#48234: [PATCH] Remove debugging message from js.el
Date: Wed, 05 May 2021 20:57:57 +1000	[thread overview]
Message-ID: <m2bl9p8n2i.fsf@mfa.pw> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 508 bytes --]

Hello Emacs devs,
I was using JavaScript mode a while ago and noticed that the 
string “test” appeared in the echo area after performing certain 
commands.  I found that a debugging message had been left in js.el 
for quite a while.  This patch removes it.

Also, I would like to make it known that I have completed the FSF 
copyright assignment paperwork.  It shouldn’t be necessary for 
this trivial patch, but I plan on submitting more patches in 
future.

Thanks for your time,
Matt


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 239 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2.1: 0001-Remove-unnecessary-call-to-message.patch --]
[-- Type: text/x-patch, Size: 727 bytes --]

From fac0e58c884024d586ad9b222269b4fcd6409365 Mon Sep 17 00:00:00 2001
From: Matt Beshara <m@mfa.pw>
Date: Wed, 7 Apr 2021 21:25:21 +1000
Subject: [PATCH] Remove unnecessary call to message

---
 lisp/progmodes/js.el | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el
index a942235f47..eeb85d9df0 100644
--- a/lisp/progmodes/js.el
+++ b/lisp/progmodes/js.el
@@ -1340,7 +1340,6 @@ LIMIT defaults to point."
 
 (defun js--end-of-defun-nested ()
   "Helper function for `js-end-of-defun'."
-  (message "test")
   (let* (pitem
          (this-end (save-excursion
                      (and (setq pitem (js--beginning-of-defun-nested))
-- 
2.24.3 (Apple Git-128)


[-- Attachment #2.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 239 bytes --]

             reply	other threads:[~2021-05-05 10:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-05 10:57 Matt Beshara [this message]
2021-05-05 12:49 ` bug#48234: [PATCH] Remove debugging message from js.el Lars Ingebrigtsen
2021-05-06  4:17 ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2bl9p8n2i.fsf@mfa.pw \
    --to=m@mfa.pw \
    --cc=48234@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).