* bug#32733: 26; (dired-x) `Shell Command Guessing' typo
@ 2018-09-14 4:27 Drew Adams
2018-09-14 7:28 ` Robert Pluim
0 siblings, 1 reply; 13+ messages in thread
From: Drew Adams @ 2018-09-14 4:27 UTC (permalink / raw)
To: 32733
This is not clear:
If '*' in the shell command, that means to substitute the file name.
^^^^^^^^^^^^^^^^^^^^^^^^^^^
Probably it should be something like "If `*' appears in the shell
command..." or "If there is an asterisk (`*') in the shell command..."
or "If the shell command contains `*'...".
In GNU Emacs 26.1 (build 1, x86_64-w64-mingw32)
of 2018-05-30
Repository revision: 07f8f9bc5a51f5aa94eb099f3e15fbe0c20ea1ea
Windowing system distributor `Microsoft Corp.', version 10.0.16299
Configured using:
`configure --without-dbus --host=x86_64-w64-mingw32
--without-compress-install 'CFLAGS=-O2 -static -g3''
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#32733: 26; (dired-x) `Shell Command Guessing' typo
2018-09-14 4:27 bug#32733: 26; (dired-x) `Shell Command Guessing' typo Drew Adams
@ 2018-09-14 7:28 ` Robert Pluim
2018-09-14 13:39 ` Drew Adams
0 siblings, 1 reply; 13+ messages in thread
From: Robert Pluim @ 2018-09-14 7:28 UTC (permalink / raw)
To: Drew Adams; +Cc: 32733
Drew Adams <drew.adams@oracle.com> writes:
> This is not clear:
>
> If '*' in the shell command, that means to substitute the file name.
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> Probably it should be something like "If `*' appears in the shell
> command..." or "If there is an asterisk (`*') in the shell command..."
> or "If the shell command contains `*'...".
>
How about:
A @samp{*} in the shell command is replaced by the file name.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#32733: 26; (dired-x) `Shell Command Guessing' typo
2018-09-14 7:28 ` Robert Pluim
@ 2018-09-14 13:39 ` Drew Adams
2018-09-14 14:01 ` Robert Pluim
2018-09-15 0:47 ` Richard Stallman
0 siblings, 2 replies; 13+ messages in thread
From: Drew Adams @ 2018-09-14 13:39 UTC (permalink / raw)
To: Robert Pluim; +Cc: 32733
> How about:
> A @samp{*} in the shell command is replaced by the file name.
Good.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#32733: 26; (dired-x) `Shell Command Guessing' typo
2018-09-14 13:39 ` Drew Adams
@ 2018-09-14 14:01 ` Robert Pluim
2018-09-15 0:47 ` Richard Stallman
1 sibling, 0 replies; 13+ messages in thread
From: Robert Pluim @ 2018-09-14 14:01 UTC (permalink / raw)
To: Drew Adams; +Cc: 32733
tags 32733 fixed
close 32733 26.2
quit
Drew Adams <drew.adams@oracle.com> writes:
>> How about:
>> A @samp{*} in the shell command is replaced by the file name.
>
> Good.
Pushed as 219893a519 to emacs-26
Regards
Robert
PS Drew, Iʼm surprised you donʼt make these kind of changes directly
yourself, rather than opening a bug.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#32733: 26; (dired-x) `Shell Command Guessing' typo
2018-09-14 13:39 ` Drew Adams
2018-09-14 14:01 ` Robert Pluim
@ 2018-09-15 0:47 ` Richard Stallman
2018-09-18 12:57 ` Robert Pluim
1 sibling, 1 reply; 13+ messages in thread
From: Richard Stallman @ 2018-09-15 0:47 UTC (permalink / raw)
To: Drew Adams; +Cc: rpluim, 32733
[[[ To any NSA and FBI agents reading my email: please consider ]]]
[[[ whether defending the US Constitution against all enemies, ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]
> > A @samp{*} in the shell command is replaced by the file name.
How about putting that in the active voice?
--
Dr Richard Stallman
President, Free Software Foundation (https://gnu.org, https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#32733: 26; (dired-x) `Shell Command Guessing' typo
2018-09-15 0:47 ` Richard Stallman
@ 2018-09-18 12:57 ` Robert Pluim
2018-09-18 13:21 ` Eli Zaretskii
2018-09-19 3:36 ` Richard Stallman
0 siblings, 2 replies; 13+ messages in thread
From: Robert Pluim @ 2018-09-18 12:57 UTC (permalink / raw)
To: Richard Stallman; +Cc: 32733
Richard Stallman <rms@gnu.org> writes:
> [[[ To any NSA and FBI agents reading my email: please consider ]]]
> [[[ whether defending the US Constitution against all enemies, ]]]
> [[[ foreign or domestic, requires you to follow Snowden's example. ]]]
>
> > > A @samp{*} in the shell command is replaced by the file name.
>
> How about putting that in the active voice?
I guess thatʼs possible, but it would make that sentence be very
different in tone from the surrounding text.
Robert
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#32733: 26; (dired-x) `Shell Command Guessing' typo
2018-09-18 12:57 ` Robert Pluim
@ 2018-09-18 13:21 ` Eli Zaretskii
2018-09-18 13:36 ` Robert Pluim
2018-09-19 3:41 ` Richard Stallman
2018-09-19 3:36 ` Richard Stallman
1 sibling, 2 replies; 13+ messages in thread
From: Eli Zaretskii @ 2018-09-18 13:21 UTC (permalink / raw)
To: Robert Pluim; +Cc: rms, 32733
> From: Robert Pluim <rpluim@gmail.com>
> Date: Tue, 18 Sep 2018 14:57:54 +0200
> Cc: 32733@debbugs.gnu.org
>
> > > > A @samp{*} in the shell command is replaced by the file name.
> >
> > How about putting that in the active voice?
>
> I guess thatʼs possible, but it would make that sentence be very
> different in tone from the surrounding text.
Not sure what surrounding text is alluded to here, but I'd just say
A @samp{*} in the shell command stands for the file name that
matched the regexp.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#32733: 26; (dired-x) `Shell Command Guessing' typo
2018-09-18 13:21 ` Eli Zaretskii
@ 2018-09-18 13:36 ` Robert Pluim
2018-09-18 14:19 ` Eli Zaretskii
2018-09-19 3:41 ` Richard Stallman
1 sibling, 1 reply; 13+ messages in thread
From: Robert Pluim @ 2018-09-18 13:36 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: rms, 32733
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Robert Pluim <rpluim@gmail.com>
>> Date: Tue, 18 Sep 2018 14:57:54 +0200
>> Cc: 32733@debbugs.gnu.org
>>
>> > > > A @samp{*} in the shell command is replaced by the file name.
>> >
>> > How about putting that in the active voice?
>>
>> I guess thatʼs possible, but it would make that sentence be very
>> different in tone from the surrounding text.
>
> Not sure what surrounding text is alluded to here, but I'd just say
>
> A @samp{*} in the shell command stands for the file name that
> matched the regexp.
I donʼt find that notably clearer nor more 'active'.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#32733: 26; (dired-x) `Shell Command Guessing' typo
2018-09-18 13:36 ` Robert Pluim
@ 2018-09-18 14:19 ` Eli Zaretskii
0 siblings, 0 replies; 13+ messages in thread
From: Eli Zaretskii @ 2018-09-18 14:19 UTC (permalink / raw)
To: Robert Pluim; +Cc: rms, 32733
> From: Robert Pluim <rpluim@gmail.com>
> Cc: rms@gnu.org, 32733@debbugs.gnu.org
> Date: Tue, 18 Sep 2018 15:36:54 +0200
>
> > A @samp{*} in the shell command stands for the file name that
> > matched the regexp.
>
> I donʼt find that notably clearer nor more 'active'.
I think it's slightly better, although not overwhelmingly so.
However, we make a point of avoiding passive tense in our
documentation, so it makes sense to try to avoid it even if the effect
is relatively minor.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#32733: 26; (dired-x) `Shell Command Guessing' typo
2018-09-18 12:57 ` Robert Pluim
2018-09-18 13:21 ` Eli Zaretskii
@ 2018-09-19 3:36 ` Richard Stallman
2018-09-19 7:09 ` Eli Zaretskii
1 sibling, 1 reply; 13+ messages in thread
From: Richard Stallman @ 2018-09-19 3:36 UTC (permalink / raw)
To: Robert Pluim; +Cc: 32733
[[[ To any NSA and FBI agents reading my email: please consider ]]]
[[[ whether defending the US Constitution against all enemies, ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]
> > How about putting that in the active voice?
> I guess thatʼs possible, but it would make that sentence be very
> different in tone from the surrounding text.
If the surrounding text uses passive voice, please try rewriting
that text to use active voice. That is one of our
guidelines for writing. See GNU Manuals in the GNU Coding Standards.
--
Dr Richard Stallman
President, Free Software Foundation (https://gnu.org, https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#32733: 26; (dired-x) `Shell Command Guessing' typo
2018-09-18 13:21 ` Eli Zaretskii
2018-09-18 13:36 ` Robert Pluim
@ 2018-09-19 3:41 ` Richard Stallman
1 sibling, 0 replies; 13+ messages in thread
From: Richard Stallman @ 2018-09-19 3:41 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: rpluim, 32733
[[[ To any NSA and FBI agents reading my email: please consider ]]]
[[[ whether defending the US Constitution against all enemies, ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]
> A @samp{*} in the shell command stands for the file name that
> matched the regexp.
That's an improvement. It is a little easier to read
than the passive sentence, a little clearer.
Once in a while there is a good reason to use passive voice.
Most of the time, replacing it with active voice makes it
a little clearer; sometimes much clearer.
--
Dr Richard Stallman
President, Free Software Foundation (https://gnu.org, https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#32733: 26; (dired-x) `Shell Command Guessing' typo
2018-09-19 3:36 ` Richard Stallman
@ 2018-09-19 7:09 ` Eli Zaretskii
2018-09-20 1:50 ` Richard Stallman
0 siblings, 1 reply; 13+ messages in thread
From: Eli Zaretskii @ 2018-09-19 7:09 UTC (permalink / raw)
To: rms; +Cc: rpluim, 32733
> From: Richard Stallman <rms@gnu.org>
> Date: Tue, 18 Sep 2018 23:36:34 -0400
> Cc: 32733@debbugs.gnu.org
>
> > I guess thatʼs possible, but it would make that sentence be very
> > different in tone from the surrounding text.
>
> If the surrounding text uses passive voice, please try rewriting
> that text to use active voice.
FWIW, I didn't see any passive voice in surrounding text that would
make the change in this sentence stand out.
^ permalink raw reply [flat|nested] 13+ messages in thread
* bug#32733: 26; (dired-x) `Shell Command Guessing' typo
2018-09-19 7:09 ` Eli Zaretskii
@ 2018-09-20 1:50 ` Richard Stallman
0 siblings, 0 replies; 13+ messages in thread
From: Richard Stallman @ 2018-09-20 1:50 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: rpluim, 32733
[[[ To any NSA and FBI agents reading my email: please consider ]]]
[[[ whether defending the US Constitution against all enemies, ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]
> FWIW, I didn't see any passive voice in surrounding text that would
> make the change in this sentence stand out.
That is good.
--
Dr Richard Stallman
President, Free Software Foundation (https://gnu.org, https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2018-09-20 1:50 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-14 4:27 bug#32733: 26; (dired-x) `Shell Command Guessing' typo Drew Adams
2018-09-14 7:28 ` Robert Pluim
2018-09-14 13:39 ` Drew Adams
2018-09-14 14:01 ` Robert Pluim
2018-09-15 0:47 ` Richard Stallman
2018-09-18 12:57 ` Robert Pluim
2018-09-18 13:21 ` Eli Zaretskii
2018-09-18 13:36 ` Robert Pluim
2018-09-18 14:19 ` Eli Zaretskii
2018-09-19 3:41 ` Richard Stallman
2018-09-19 3:36 ` Richard Stallman
2018-09-19 7:09 ` Eli Zaretskii
2018-09-20 1:50 ` Richard Stallman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).