* bug#19791: 25.0.50; Bad HTML rendering
@ 2015-02-06 12:41 Richard Stallman
2015-02-06 13:19 ` Lars Ingebrigtsen
2015-02-06 15:31 ` Stefan Monnier
0 siblings, 2 replies; 20+ messages in thread
From: Richard Stallman @ 2015-02-06 12:41 UTC (permalink / raw)
To: 19791
[-- Attachment #1: Type: text/plain, Size: 124 bytes --]
The HTML in this message came out all black, invisible.
It specifies black letters, but it's a bug to blindly obey that.
[-- Attachment #2: foo.xmail --]
[-- Type: application/octet-stream, Size: 2396 bytes --]
From tracey.hughes@neoacmchapter.org Thu Feb 5 15:02:22 2015
Return-path: <tracey.hughes@neoacmchapter.org>
Envelope-to: rms@gnu.org
Delivery-date: Thu, 05 Feb 2015 15:02:22 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32858)
by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
(Exim 4.71)
(envelope-from <tracey.hughes@neoacmchapter.org>)
id 1YJSd3-0002Kh-W8
for rms@gnu.org; Thu, 05 Feb 2015 15:02:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from <tracey.hughes@neoacmchapter.org>)
id 1YJScy-0006YH-Mh
for rms@gnu.org; Thu, 05 Feb 2015 15:02:21 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: *
X-Spam-Status: No, score=1.5 required=5.0 tests=BAYES_50,HTML_MESSAGE,
MIME_HTML_ONLY,RCVD_IN_DNSWL_NONE autolearn=disabled version=3.3.2
Received: from p3plsmtp21-01-2.prod.phx3.secureserver.net ([68.178.252.47]:41926 helo=p3plwbeout21-01.prod.phx3.secureserver.net)
by eggs.gnu.org with esmtp (Exim 4.71)
(envelope-from <tracey.hughes@neoacmchapter.org>)
id 1YJScy-0006W9-IN
for rms@gnu.org; Thu, 05 Feb 2015 15:02:16 -0500
Received: from localhost ([68.178.252.116])
by p3plwbeout21-01.prod.phx3.secureserver.net with bizsmtp
id ok2E1p0022XSfNk01k2EF4; Thu, 05 Feb 2015 13:02:14 -0700
X-SID: ok2E1p0022XSfNk01
Received: (qmail 20984 invoked by uid 99); 5 Feb 2015 20:02:14 -0000
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset="utf-8"
X-Originating-IP: 162.234.210.195
User-Agent: Workspace Webmail 5.8.0
Message-Id: <20150205130212.55fac5241db179934fe05891ad5e6001.55ccb05880.wbe@email21.secureserver.net>
From: <tracey.hughes@neoacmchapter.org>
To: "Richard Stallman" <rms@gnu.org>
Cc: "Scott McCarty" <scott.mccarty@gmail.com>,
"Scott McCarty" <smccarty@redhat.com>,
"Trevor Watkins" <tuwatkins@gmail.com>
Subject: Re: Speaking in Akron
Date: Thu, 05 Feb 2015 13:02:12 -0700
Mime-Version: 1.0
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x
X-Received-From: 68.178.252.47
X-RMAIL-ATTRIBUTES: A-------
<html><body><span style=3D"font-family:Verdana; color:#000; font-size:10pt;=
"><div>Hi Dr. Stallman,</div><div><br></div><div>Can you give us a second d=
ate besides Oct. 31st? (Just in case that date is not available).</div><div=
><br></div><div>Thanx</div><div>Tracey Hughes<br></div></span></body></html=
>
[-- Attachment #3: Type: text/plain, Size: 3356 bytes --]
In GNU Emacs 25.0.50.1 (i686-pc-linux-gnu, GTK+ Version 2.24.10)
of 2015-02-01 on rms
System Description: Trisquel GNU/Linux 6.0.1, Toutatis
Configured using:
`configure 'CFLAGS=-g3 -O0''
Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND GPM DBUS GCONF GSETTINGS NOTIFY
LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
Important settings:
value of $LANG: en_US.UTF-8
locale-coding-system: utf-8-unix
Major mode: RMAIL
Minor modes in effect:
shell-dirtrack-mode: t
gpm-mouse-mode: t
tooltip-mode: t
global-eldoc-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
buffer-read-only: t
line-number-mode: t
abbrev-mode: t
Recent messages:
Wrote /home/rms/outgoing/out-45
Sending...done
Expunging deleted messages...done
mouse-2, RET: Toggle show/hide
scroll-up-command: End of buffer [2 times]
forward-button: No buttons! [2 times]
Sending...
Wrote /home/rms/outgoing/out-46
Sending...done
Added to /home/rms/foo.xmail
Load-path shadows:
None found.
Features:
(shadow emacsbug epa derived epg mule-util jka-compr mailcap shell
pcomplete grep compile comint ansi-color ring quail help-mode rmailout
dabbrev mailalias qp url-util url-parse auth-source cl-macs eieio
byte-opt gv bytecomp byte-compile cl-extra seq cconv eieio-core
cl-generic gnus-util password-cache url-vars shr-color color shr dom
cl-loaddefs cl-lib subr-x pcase browse-url rmailmm message sendmail
format-spec rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode
mailabbrev gmm-utils mailheader mail-parse rfc2231 rmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils dired t-mouse package
epg-config view time-date paren cus-start cus-load advice help-fns
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment elisp-mode lisp-mode prog-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
dbusbind gfilenotify dynamic-setting system-font-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs)
Memory information:
((conses 8 239928 61935)
(symbols 24 23683 3)
(miscs 20 1025 2025)
(strings 16 32637 6360)
(string-bytes 1 1009006)
(vectors 8 22661)
(vector-slots 4 1191213 60850)
(floats 8 293 444)
(intervals 28 43220 1476)
(buffers 520 42)
(heap 1024 13044 1685))
[[[ To any NSA and FBI agents reading my email: please consider ]]]
[[[ whether defending the US Constitution against all enemies, ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]
--
Dr Richard Stallman
President, Free Software Foundation
51 Franklin St
Boston MA 02110
USA
www.fsf.org www.gnu.org
Skype: No way! See stallman.org/skype.html.
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#19791: 25.0.50; Bad HTML rendering
2015-02-06 12:41 bug#19791: 25.0.50; Bad HTML rendering Richard Stallman
@ 2015-02-06 13:19 ` Lars Ingebrigtsen
2015-02-06 14:49 ` Eli Zaretskii
2015-02-07 12:43 ` Richard Stallman
2015-02-06 15:31 ` Stefan Monnier
1 sibling, 2 replies; 20+ messages in thread
From: Lars Ingebrigtsen @ 2015-02-06 13:19 UTC (permalink / raw)
To: Richard Stallman; +Cc: 19791
Richard Stallman <rms@gnu.org> writes:
> The HTML in this message came out all black, invisible.
>
> It specifies black letters, but it's a bug to blindly obey that.
You're running Emacs on a tty? Have you told Emacs what the background
colour is? I think the function is `set-background-color'.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#19791: 25.0.50; Bad HTML rendering
2015-02-06 13:19 ` Lars Ingebrigtsen
@ 2015-02-06 14:49 ` Eli Zaretskii
2015-02-06 17:14 ` Lars Ingebrigtsen
2015-02-07 12:43 ` Richard Stallman
1 sibling, 1 reply; 20+ messages in thread
From: Eli Zaretskii @ 2015-02-06 14:49 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 19791, rms
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Sat, 07 Feb 2015 00:19:18 +1100
> Cc: 19791@debbugs.gnu.org
>
> Richard Stallman <rms@gnu.org> writes:
>
> > The HTML in this message came out all black, invisible.
> >
> > It specifies black letters, but it's a bug to blindly obey that.
>
> You're running Emacs on a tty? Have you told Emacs what the background
> colour is? I think the function is `set-background-color'.
Do you mean that shr.el will change the colors it produces depending
on the background color? Because I don't seem to see this, maybe I'm
doing something wrong.
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#19791: 25.0.50; Bad HTML rendering
2015-02-06 12:41 bug#19791: 25.0.50; Bad HTML rendering Richard Stallman
2015-02-06 13:19 ` Lars Ingebrigtsen
@ 2015-02-06 15:31 ` Stefan Monnier
2015-02-06 15:44 ` Eli Zaretskii
` (2 more replies)
1 sibling, 3 replies; 20+ messages in thread
From: Stefan Monnier @ 2015-02-06 15:31 UTC (permalink / raw)
To: Richard Stallman; +Cc: 19791
> It specifies black letters, but it's a bug to blindly obey that.
Unless it specified this color specifically because it wanted the text
to be invisible.
Stefan
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#19791: 25.0.50; Bad HTML rendering
2015-02-06 15:31 ` Stefan Monnier
@ 2015-02-06 15:44 ` Eli Zaretskii
2015-02-06 18:09 ` Stefan Monnier
2015-02-07 7:14 ` Ivan Shmakov
2015-02-07 12:44 ` Richard Stallman
2 siblings, 1 reply; 20+ messages in thread
From: Eli Zaretskii @ 2015-02-06 15:44 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 19791, rms
> Date: Fri, 06 Feb 2015 10:31:05 -0500
> Cc: 19791@debbugs.gnu.org
>
> > It specifies black letters, but it's a bug to blindly obey that.
>
> Unless it specified this color specifically because it wanted the text
> to be invisible.
Not in this case.
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#19791: 25.0.50; Bad HTML rendering
2015-02-06 14:49 ` Eli Zaretskii
@ 2015-02-06 17:14 ` Lars Ingebrigtsen
2015-02-06 18:59 ` Eli Zaretskii
0 siblings, 1 reply; 20+ messages in thread
From: Lars Ingebrigtsen @ 2015-02-06 17:14 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 19791, rms
Eli Zaretskii <eliz@gnu.org> writes:
> Do you mean that shr.el will change the colors it produces depending
> on the background color? Because I don't seem to see this, maybe I'm
> doing something wrong.
Yes, it's supposed to. I'm running with a black background here, and
shr lightened the colour of the text to a grey one that was readable.
If the background had been white, I think it would have left the text
completely black.
At least that's how it's supposed to work.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#19791: 25.0.50; Bad HTML rendering
2015-02-06 15:44 ` Eli Zaretskii
@ 2015-02-06 18:09 ` Stefan Monnier
2015-02-07 1:32 ` Lars Ingebrigtsen
0 siblings, 1 reply; 20+ messages in thread
From: Stefan Monnier @ 2015-02-06 18:09 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 19791, rms
>> > It specifies black letters, but it's a bug to blindly obey that.
>> Unless it specified this color specifically because it wanted the text
>> to be invisible.
> Not in this case.
I know; I was just pointing out that we might need to be careful with
the corner cases.
Stefan
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#19791: 25.0.50; Bad HTML rendering
2015-02-06 17:14 ` Lars Ingebrigtsen
@ 2015-02-06 18:59 ` Eli Zaretskii
2015-02-07 1:30 ` Lars Ingebrigtsen
0 siblings, 1 reply; 20+ messages in thread
From: Eli Zaretskii @ 2015-02-06 18:59 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 19791, rms
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: 19791@debbugs.gnu.org, rms@gnu.org
> Date: Sat, 07 Feb 2015 04:14:23 +1100
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > Do you mean that shr.el will change the colors it produces depending
> > on the background color? Because I don't seem to see this, maybe I'm
> > doing something wrong.
>
> Yes, it's supposed to. I'm running with a black background here, and
> shr lightened the colour of the text to a grey one that was readable.
> If the background had been white, I think it would have left the text
> completely black.
>
> At least that's how it's supposed to work.
Where's that in the sources?
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#19791: 25.0.50; Bad HTML rendering
2015-02-06 18:59 ` Eli Zaretskii
@ 2015-02-07 1:30 ` Lars Ingebrigtsen
2015-02-07 11:57 ` Eli Zaretskii
0 siblings, 1 reply; 20+ messages in thread
From: Lars Ingebrigtsen @ 2015-02-07 1:30 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 19791, rms
Eli Zaretskii <eliz@gnu.org> writes:
> Where's that in the sources?
`shr-color-check' and `shr-color-visible'.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#19791: 25.0.50; Bad HTML rendering
2015-02-06 18:09 ` Stefan Monnier
@ 2015-02-07 1:32 ` Lars Ingebrigtsen
0 siblings, 0 replies; 20+ messages in thread
From: Lars Ingebrigtsen @ 2015-02-07 1:32 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 19791, rms
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> I know; I was just pointing out that we might need to be careful with
> the corner cases.
The colours should probably not be adjusted if the HTML document
provides both the background colour and the foreground colour. That's
done today, though.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#19791: 25.0.50; Bad HTML rendering
2015-02-06 15:31 ` Stefan Monnier
2015-02-06 15:44 ` Eli Zaretskii
@ 2015-02-07 7:14 ` Ivan Shmakov
2015-02-07 7:25 ` Matthew Carter
2015-02-07 12:44 ` Richard Stallman
2 siblings, 1 reply; 20+ messages in thread
From: Ivan Shmakov @ 2015-02-07 7:14 UTC (permalink / raw)
To: 19791
>>>>> Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>> It specifies black letters, but it's a bug to blindly obey that.
> Unless it specified this color specifically because it wanted the
> text to be invisible.
Except that the user should be free to override that.
The “major” browsers already allow that, e. g., via the Stylish
extension (see [1, 2]), and I believe that EWW should re-use
their approach; namely: a. support proper CSS cascading;
b. allow for custom (user-defined) styles.
That being said, being myself a user of EWW on a 16-color
Linux tty, I don’t see much value in trying to render
HTML-specified colors, anyway. I’ve just disabled the feature
over a year ago, – and never wanted it back.
[1] https://addons.mozilla.org/en-US/firefox/addon/stylish/
[2] https://userstyles.org/
--
FSF associate member #7257 http://boycottsystemd.org/ … 3013 B6A0 230E 334A
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#19791: 25.0.50; Bad HTML rendering
2015-02-07 7:14 ` Ivan Shmakov
@ 2015-02-07 7:25 ` Matthew Carter
2015-02-07 11:50 ` Ivan Shmakov
0 siblings, 1 reply; 20+ messages in thread
From: Matthew Carter @ 2015-02-07 7:25 UTC (permalink / raw)
To: 19791
Ivan Shmakov <ivan@siamics.net> writes:
>>>>>> Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>
> >> It specifies black letters, but it's a bug to blindly obey that.
>
> > Unless it specified this color specifically because it wanted the
> > text to be invisible.
>
> Except that the user should be free to override that.
>
> The “major” browsers already allow that, e. g., via the Stylish
> extension (see [1, 2]), and I believe that EWW should re-use
> their approach; namely: a. support proper CSS cascading;
> b. allow for custom (user-defined) styles.
>
> That being said, being myself a user of EWW on a 16-color
> Linux tty, I don’t see much value in trying to render
> HTML-specified colors, anyway. I’ve just disabled the feature
> over a year ago, – and never wanted it back.
>
> [1] https://addons.mozilla.org/en-US/firefox/addon/stylish/
> [2] https://userstyles.org/
Is there a way to disable background colors while leaving font colors
in-tact? I hate having the background colored (either the full screen
or behind text), but a little color on the words is nice in my opinion
(I use a 256 color tty).
--
Matthew Carter (m@ahungry.com)
http://ahungry.com
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#19791: 25.0.50; Bad HTML rendering
2015-02-07 7:25 ` Matthew Carter
@ 2015-02-07 11:50 ` Ivan Shmakov
0 siblings, 0 replies; 20+ messages in thread
From: Ivan Shmakov @ 2015-02-07 11:50 UTC (permalink / raw)
To: 19791
>>>>> Matthew Carter <m@ahungry.com> writes:
>>>>> Ivan Shmakov <ivan@siamics.net> writes:
[…]
>> That being said, being myself a user of EWW on a 16-color Linux tty,
>> I don’t see much value in trying to render HTML-specified colors,
>> anyway. I’ve just disabled the feature over a year ago, – and never
>> wanted it back.
[…]
> Is there a way to disable background colors while leaving font colors
> in-tact?
Not any I’m aware of.
Anyway, SHR currently only supports “direct” styling (for
instance, it will colorize <i style="color: #080" />, but /not/
<i class="binomen" />, – even when the applicable CSS has
‘.binomen { color: #080; }’), so SHR support for colors is to be
taken with a grain of salt.
(And there’s a similar issue with multicolumn layouts, BTW.)
> I hate having the background colored (either the full screen or
> behind text), but a little color on the words is nice in my opinion
> (I use a 256 color tty).
Note that even when the support for colors proper is disabled,
SHR will still use the shr-link, bold and italic faces for the
contents of the respective HTML elements, as defined by the
hard-coded mapping (yes, no CSS support there yet, either.)
IMO, this gives just that little color on the words which is
reasonable.
--
FSF associate member #7257 np. Dust to Dust — Leviathan 3013 B6A0 230E 334A
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#19791: 25.0.50; Bad HTML rendering
2015-02-07 1:30 ` Lars Ingebrigtsen
@ 2015-02-07 11:57 ` Eli Zaretskii
2015-02-08 17:52 ` Eli Zaretskii
0 siblings, 1 reply; 20+ messages in thread
From: Eli Zaretskii @ 2015-02-07 11:57 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 19791, rms
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: 19791@debbugs.gnu.org, rms@gnu.org
> Date: Sat, 07 Feb 2015 12:30:42 +1100
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > Where's that in the sources?
>
> `shr-color-check' and `shr-color-visible'.
I think I see the problem: it is somehow related to bug #19802. In
particular, even if I do this:
M-: (set-frame-parameter (selected-frame) 'background-color "black") RET
I still get nil from (frame-parameter nil 'background-color). And
shr-color-check relies on the latter to report the background color of
the frame.
So I guess solving that bug will also solve this, or at least move
closer to its solution.
Richard, can you confirm that you see on your system the same problem
with 'background-color' frame parameter on a TTY as described above,
i.e. that setting that parameter in frame's parameter alist doesn't
cause frame-parameter to return the value?
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#19791: 25.0.50; Bad HTML rendering
2015-02-06 13:19 ` Lars Ingebrigtsen
2015-02-06 14:49 ` Eli Zaretskii
@ 2015-02-07 12:43 ` Richard Stallman
2015-02-07 13:09 ` Eli Zaretskii
1 sibling, 1 reply; 20+ messages in thread
From: Richard Stallman @ 2015-02-07 12:43 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 19791
[[[ To any NSA and FBI agents reading my email: please consider ]]]
[[[ whether defending the US Constitution against all enemies, ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]
> You're running Emacs on a tty? Have you told Emacs what the background
> colour is? I think the function is `set-background-color'.
I did (set-background-color "black") but it did not change anything.
I also tried (setq frame-background-mode 'dark) but it did not change
anything.
--
Dr Richard Stallman
President, Free Software Foundation
51 Franklin St
Boston MA 02110
USA
www.fsf.org www.gnu.org
Skype: No way! See stallman.org/skype.html.
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#19791: 25.0.50; Bad HTML rendering
2015-02-06 15:31 ` Stefan Monnier
2015-02-06 15:44 ` Eli Zaretskii
2015-02-07 7:14 ` Ivan Shmakov
@ 2015-02-07 12:44 ` Richard Stallman
2 siblings, 0 replies; 20+ messages in thread
From: Richard Stallman @ 2015-02-07 12:44 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 19791
[[[ To any NSA and FBI agents reading my email: please consider ]]]
[[[ whether defending the US Constitution against all enemies, ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]
> > It specifies black letters, but it's a bug to blindly obey that.
> Unless it specified this color specifically because it wanted the text
> to be invisible.
That is unlikely to be the case, but _even if it is_, it doesn't
change the conclusion. Emacs should serve the user who wants to see
the text, rather than someone else who wanted to hide it.
--
Dr Richard Stallman
President, Free Software Foundation
51 Franklin St
Boston MA 02110
USA
www.fsf.org www.gnu.org
Skype: No way! See stallman.org/skype.html.
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#19791: 25.0.50; Bad HTML rendering
2015-02-07 12:43 ` Richard Stallman
@ 2015-02-07 13:09 ` Eli Zaretskii
0 siblings, 0 replies; 20+ messages in thread
From: Eli Zaretskii @ 2015-02-07 13:09 UTC (permalink / raw)
To: rms; +Cc: 19791, larsi
> Date: Sat, 07 Feb 2015 07:43:26 -0500
> From: Richard Stallman <rms@gnu.org>
> Cc: 19791@debbugs.gnu.org
>
> I did (set-background-color "black") but it did not change anything.
>
> I also tried (setq frame-background-mode 'dark) but it did not change
> anything.
These all are manifestations of bug #19802. I'm working on fixing it.
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#19791: 25.0.50; Bad HTML rendering
2015-02-07 11:57 ` Eli Zaretskii
@ 2015-02-08 17:52 ` Eli Zaretskii
2015-12-25 22:30 ` Lars Ingebrigtsen
0 siblings, 1 reply; 20+ messages in thread
From: Eli Zaretskii @ 2015-02-08 17:52 UTC (permalink / raw)
To: Richard Stallman; +Cc: 19791, larsi
> Date: Sat, 07 Feb 2015 13:57:04 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 19791@debbugs.gnu.org, rms@gnu.org
>
> > From: Lars Ingebrigtsen <larsi@gnus.org>
> > Cc: 19791@debbugs.gnu.org, rms@gnu.org
> > Date: Sat, 07 Feb 2015 12:30:42 +1100
> >
> > Eli Zaretskii <eliz@gnu.org> writes:
> >
> > > Where's that in the sources?
> >
> > `shr-color-check' and `shr-color-visible'.
>
> I think I see the problem: it is somehow related to bug #19802. In
> particular, even if I do this:
>
> M-: (set-frame-parameter (selected-frame) 'background-color "black") RET
>
> I still get nil from (frame-parameter nil 'background-color). And
> shr-color-check relies on the latter to report the background color of
> the frame.
>
> So I guess solving that bug will also solve this, or at least move
> closer to its solution.
This turned out to be broken in more than one way, some of them only
on master. The patch to fix them, relative to the current master, is
below. I installed the changes on the branch and will install the
master part shortly.
Richard, could you please see if this solves the problem with
"invisible" colors in HTML mails for you? It did for me.
diff --git a/lisp/frame.el b/lisp/frame.el
index ecb433e..8dce86b 100644
--- a/lisp/frame.el
+++ b/lisp/frame.el
@@ -259,6 +259,10 @@ (defun frame-notice-user-settings ()
(let ((newparms (frame-parameters))
(frame (selected-frame)))
(tty-handle-reverse-video frame newparms)
+ ;; tty-handle-reverse-video might change the frame's
+ ;; color parameters, and we need to use the updated
+ ;; value below.
+ (setq newparms (frame-parameters))
;; If we changed the background color, we need to update
;; the background-mode parameter, and maybe some faces,
;; too.
@@ -266,7 +270,7 @@ (defun frame-notice-user-settings ()
(unless (or (assq 'background-mode initial-frame-alist)
(assq 'background-mode default-frame-alist))
(frame-set-background-mode frame))
- (face-set-after-frame-default frame))))))
+ (face-set-after-frame-default frame newparms))))))
;; If the initial frame is still around, apply initial-frame-alist
;; and default-frame-alist to it.
@@ -1200,7 +1204,9 @@ (defun set-background-color (color-name)
(modify-frame-parameters (selected-frame)
(list (cons 'background-color color-name)))
(or window-system
- (face-set-after-frame-default (selected-frame))))
+ (face-set-after-frame-default (selected-frame)
+ (list
+ (cons 'background-color color-name)))))
(defun set-foreground-color (color-name)
"Set the foreground color of the selected frame to COLOR-NAME.
@@ -1210,7 +1216,9 @@ (defun set-foreground-color (color-name)
(modify-frame-parameters (selected-frame)
(list (cons 'foreground-color color-name)))
(or window-system
- (face-set-after-frame-default (selected-frame))))
+ (face-set-after-frame-default (selected-frame)
+ (list
+ (cons 'foreground-color color-name)))))
(defun set-cursor-color (color-name)
"Set the text cursor color of the selected frame to COLOR-NAME.
diff --git a/src/frame.c b/src/frame.c
index 96fe377..9060f56 100644
--- a/src/frame.c
+++ b/src/frame.c
@@ -2615,7 +2615,12 @@ It is a list of elements of the form (PARM . VALUE), where PARM is a symbol.
important when param_alist's notion of colors is
"unspecified". We need to do the same here. */
if (STRINGP (value) && !FRAME_WINDOW_P (f))
- value = frame_unspecified_color (f, value);
+ {
+ Lisp_Object tem = frame_unspecified_color (f, value);
+
+ if (!NILP (tem))
+ value = tem;
+ }
}
else
value = Fcdr (Fassq (parameter, Fframe_parameters (frame)));
diff --git a/src/xfaces.c b/src/xfaces.c
index 6e01ab0..6866aa8 100644
--- a/src/xfaces.c
+++ b/src/xfaces.c
@@ -5703,7 +5703,7 @@ ALIST is an alist of (REGISTRY ALTERNATIVE1 ALTERNATIVE2 ...) entries.
if (STRINGP (color)
&& SCHARS (color)
&& CONSP (Vtty_defined_color_alist)
- && (def = assq_no_quit (color, call1 (Qtty_color_alist, frame)),
+ && (def = assoc_no_quit (color, call1 (Qtty_color_alist, frame)),
CONSP (def)))
{
/* Associations in tty-defined-color-alist are of the form
^ permalink raw reply related [flat|nested] 20+ messages in thread
* bug#19791: 25.0.50; Bad HTML rendering
2015-02-08 17:52 ` Eli Zaretskii
@ 2015-12-25 22:30 ` Lars Ingebrigtsen
2015-12-26 6:14 ` Richard Stallman
0 siblings, 1 reply; 20+ messages in thread
From: Lars Ingebrigtsen @ 2015-12-25 22:30 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 19791, Richard Stallman
Eli Zaretskii <eliz@gnu.org> writes:
> This turned out to be broken in more than one way, some of them only
> on master. The patch to fix them, relative to the current master, is
> below. I installed the changes on the branch and will install the
> master part shortly.
>
> Richard, could you please see if this solves the problem with
> "invisible" colors in HTML mails for you? It did for me.
I can't see any further followup here, so I'm assuming this was fixed,
and I'm closing the bug report. Please open if this turns out to be
wrong.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 20+ messages in thread
* bug#19791: 25.0.50; Bad HTML rendering
2015-12-25 22:30 ` Lars Ingebrigtsen
@ 2015-12-26 6:14 ` Richard Stallman
0 siblings, 0 replies; 20+ messages in thread
From: Richard Stallman @ 2015-12-26 6:14 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 19791
[[[ To any NSA and FBI agents reading my email: please consider ]]]
[[[ whether defending the US Constitution against all enemies, ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]
I confirm that the bug no longer happens in the Emacs sources
I fetched today. Thanks.
--
Dr Richard Stallman
President, Free Software Foundation (gnu.org, fsf.org)
Internet Hall-of-Famer (internethalloffame.org)
Skype: No way! See stallman.org/skype.html.
^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2015-12-26 6:14 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-06 12:41 bug#19791: 25.0.50; Bad HTML rendering Richard Stallman
2015-02-06 13:19 ` Lars Ingebrigtsen
2015-02-06 14:49 ` Eli Zaretskii
2015-02-06 17:14 ` Lars Ingebrigtsen
2015-02-06 18:59 ` Eli Zaretskii
2015-02-07 1:30 ` Lars Ingebrigtsen
2015-02-07 11:57 ` Eli Zaretskii
2015-02-08 17:52 ` Eli Zaretskii
2015-12-25 22:30 ` Lars Ingebrigtsen
2015-12-26 6:14 ` Richard Stallman
2015-02-07 12:43 ` Richard Stallman
2015-02-07 13:09 ` Eli Zaretskii
2015-02-06 15:31 ` Stefan Monnier
2015-02-06 15:44 ` Eli Zaretskii
2015-02-06 18:09 ` Stefan Monnier
2015-02-07 1:32 ` Lars Ingebrigtsen
2015-02-07 7:14 ` Ivan Shmakov
2015-02-07 7:25 ` Matthew Carter
2015-02-07 11:50 ` Ivan Shmakov
2015-02-07 12:44 ` Richard Stallman
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).