unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Mattias Engdegård" <mattiase@acm.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Juri Linkov <juri@linkov.net>,
	39121@debbugs.gnu.org, Tino Calancha <tino.calancha@gmail.com>
Subject: bug#39121: 27.0.60; occur: Add bindings for  next-error-no-select
Date: Fri, 23 Jul 2021 19:16:02 +0200	[thread overview]
Message-ID: <D05FE035-4E8C-4D19-9CA6-7C467F689A2B@acm.org> (raw)
In-Reply-To: <871r7pazx1.fsf@gnus.org>

23 juli 2021 kl. 16.05 skrev Lars Ingebrigtsen <larsi@gnus.org>:

> (defvar occur-highlight-regexp t
>  "Regexp matching part of visited source lines to highlight temporarily.
> Highlight entire line if t; don't highlight source lines if nil.")
> 
> So I think your patch looks correct.

Well yes, but that variable itself isn't really useful -- it is really just something transplanted from compilation-mode in order to achieve the same highlighting effect in Occur, but Occur shouldn't need it at all. So my patch is a bit rubbish; we could do better.

Currently, Occur buffers use `occur-target` properties to direct each line to the start of the first match on that line. We could use the property to indicating the exact extents (intervals) of matches, instead. For example, a buffer containing

 VENI VIDI VICI

with the Occur search regexp "VI.I", currently results in a line in *Occur* having the property `occur-target` with a marker to the start of 'VIDI' as value. Instead, we could make the value be ((m1 . m2) (m3 . m4)) where m1..m4 mark the beginning and end of 'VIDI' and 'VICI' respectively. Then occur-highlight-regexp could be done away entirely.






  reply	other threads:[~2021-07-23 17:16 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CD8A4158-1AD5-4997-8F36-8F8E7DF9BD32@acm.org>
2021-07-15 22:10 ` bug#39121: 27.0.60; occur: Add bindings for next-error-no-select Juri Linkov
2021-07-16 13:20   ` Mattias Engdegård
2021-07-23 13:32   ` Mattias Engdegård
2021-07-23 14:05     ` Lars Ingebrigtsen
2021-07-23 17:16       ` Mattias Engdegård [this message]
2021-07-24 11:46         ` Lars Ingebrigtsen
2021-07-24 17:29           ` Mattias Engdegård
2021-07-25  6:41             ` Lars Ingebrigtsen
2021-07-25  9:16               ` Eli Zaretskii
2021-07-25 10:55                 ` Mattias Engdegård
2021-07-25 11:39                   ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-25 14:45                     ` Mattias Engdegård
2021-07-25 11:49                   ` Eli Zaretskii
2021-07-25 15:09                     ` Mattias Engdegård
2021-07-25 16:27                       ` Eli Zaretskii
2021-07-25 18:54                         ` Mattias Engdegård
2021-07-25 19:23                           ` Eli Zaretskii
2021-07-25 19:30                             ` Mattias Engdegård
2021-07-26 12:43                               ` Eli Zaretskii
2021-07-25 10:06               ` Mattias Engdegård
2020-01-13 20:51 Tino Calancha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D05FE035-4E8C-4D19-9CA6-7C467F689A2B@acm.org \
    --to=mattiase@acm.org \
    --cc=39121@debbugs.gnu.org \
    --cc=juri@linkov.net \
    --cc=larsi@gnus.org \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).