unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Mattias Engdegård" <mattiase@acm.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org, juri@linkov.net, 39121@debbugs.gnu.org,
	tino.calancha@gmail.com
Subject: bug#39121: 27.0.60; occur: Add bindings for  next-error-no-select
Date: Sun, 25 Jul 2021 20:54:47 +0200	[thread overview]
Message-ID: <408C22B8-4A9D-409F-8610-1AE86294FC20@acm.org> (raw)
In-Reply-To: <83czr6we8z.fsf@gnu.org>

25 juli 2021 kl. 18.27 skrev Eli Zaretskii <eliz@gnu.org>:

> The NEWS file doesn't necessarily describe only stuff documented
> somewhere, it also describes changes that aren't documented anywhere
> but the source code.

Yes, but then it's always something that affects the user in some way, isn't it? Mentioning changed internals doesn't seem to be standard practice, but I could be wrong about that. Would you point out a few examples of where we described changed aspects of undocumented implementation details in NEWS? That would support your view and help me understand it better.

The question is also whether it should be documented at all. The fact that it never was before, as well as the general ad-hoc nature of the interface, are strong indicators that it probably shouldn't be.

As a case in point: until Lars and I fixed it, the use of occur-mode in tex-mode.el had been broken since at least Emacs 24, in equal parts for reasons of bit-rot (implementation details changed) and incorrect assumptions of interface invariants. And this is an Emacs core package.

>  Suppose someone read the source of replace.el,
> found out about this property, and uses it to do something, either
> privately or for some 3rd-part package.  Put yourself in the shows of
> that person and ask yourself whether you'd like to know that this kind
> of change has been installed in Emacs.

The `occur-target` property alone is far from sufficient for populating occur-mode buffers; it is one implementation detail of many. A little knowledge and all that.

It would have been different if we had changed the implementation incompatibly; in such case, I agree it would have been polite to issue a notice about it. But nothing should break as a result of the change we are talking about.

> Since you introduced the new format, you probably thought it to be
> better than the existing one, right?  Then telling others about that
> would be a good service, IMO.

The change was made exclusively for improving Occur itself, and the external packages that I have seen would generally draw little advantage from doing anything differently. Of course, I haven't seen them all, but having other people depending on implementation details of your software is a maintenance burden which either impedes progress.






  reply	other threads:[~2021-07-25 18:54 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CD8A4158-1AD5-4997-8F36-8F8E7DF9BD32@acm.org>
2021-07-15 22:10 ` bug#39121: 27.0.60; occur: Add bindings for next-error-no-select Juri Linkov
2021-07-16 13:20   ` Mattias Engdegård
2021-07-23 13:32   ` Mattias Engdegård
2021-07-23 14:05     ` Lars Ingebrigtsen
2021-07-23 17:16       ` Mattias Engdegård
2021-07-24 11:46         ` Lars Ingebrigtsen
2021-07-24 17:29           ` Mattias Engdegård
2021-07-25  6:41             ` Lars Ingebrigtsen
2021-07-25  9:16               ` Eli Zaretskii
2021-07-25 10:55                 ` Mattias Engdegård
2021-07-25 11:39                   ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-25 14:45                     ` Mattias Engdegård
2021-07-25 11:49                   ` Eli Zaretskii
2021-07-25 15:09                     ` Mattias Engdegård
2021-07-25 16:27                       ` Eli Zaretskii
2021-07-25 18:54                         ` Mattias Engdegård [this message]
2021-07-25 19:23                           ` Eli Zaretskii
2021-07-25 19:30                             ` Mattias Engdegård
2021-07-26 12:43                               ` Eli Zaretskii
2021-07-25 10:06               ` Mattias Engdegård
2020-01-13 20:51 Tino Calancha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=408C22B8-4A9D-409F-8610-1AE86294FC20@acm.org \
    --to=mattiase@acm.org \
    --cc=39121@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=juri@linkov.net \
    --cc=larsi@gnus.org \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).