From: "Mattias Engdegård" <mattiase@acm.org>
To: Juri Linkov <juri@linkov.net>
Cc: 39121@debbugs.gnu.org, Tino Calancha <tino.calancha@gmail.com>
Subject: bug#39121: 27.0.60; occur: Add bindings for next-error-no-select
Date: Fri, 16 Jul 2021 15:20:49 +0200 [thread overview]
Message-ID: <3B9A92C1-F93C-46C4-8F8D-9059D61EBF98@acm.org> (raw)
In-Reply-To: <87r1fzi7c3.fsf@mail.linkov.net>
16 juli 2021 kl. 00.10 skrev Juri Linkov <juri@linkov.net>:
> It seems `compilation-highlight-regexp` was supposed to duplicate the logic
> of the existing variable `compilation-highlight-regexp` that is t by default.
Yes, you are probably right. It's not obvious that using the same code is a good fit for Occur.
Specifically, compilation-mode can, in the best case, use the parsed location interval (starting and ending columns). When only a line number is available, it's not possible to do much better than highlighting the entire line. (The grep command uses what appears to be smelly hacks for more precise locations.)
In contrast, for Occur the exact position should always be available since Emacs made the search. Wouldn't it make sense to use it, instead of matching regexps again?
next prev parent reply other threads:[~2021-07-16 13:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CD8A4158-1AD5-4997-8F36-8F8E7DF9BD32@acm.org>
2021-07-15 22:10 ` bug#39121: 27.0.60; occur: Add bindings for next-error-no-select Juri Linkov
2021-07-16 13:20 ` Mattias Engdegård [this message]
2021-07-23 13:32 ` Mattias Engdegård
2021-07-23 14:05 ` Lars Ingebrigtsen
2021-07-23 17:16 ` Mattias Engdegård
2021-07-24 11:46 ` Lars Ingebrigtsen
2021-07-24 17:29 ` Mattias Engdegård
2021-07-25 6:41 ` Lars Ingebrigtsen
2021-07-25 9:16 ` Eli Zaretskii
2021-07-25 10:55 ` Mattias Engdegård
2021-07-25 11:39 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-25 14:45 ` Mattias Engdegård
2021-07-25 11:49 ` Eli Zaretskii
2021-07-25 15:09 ` Mattias Engdegård
2021-07-25 16:27 ` Eli Zaretskii
2021-07-25 18:54 ` Mattias Engdegård
2021-07-25 19:23 ` Eli Zaretskii
2021-07-25 19:30 ` Mattias Engdegård
2021-07-26 12:43 ` Eli Zaretskii
2021-07-25 10:06 ` Mattias Engdegård
2020-01-13 20:51 Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B9A92C1-F93C-46C4-8F8D-9059D61EBF98@acm.org \
--to=mattiase@acm.org \
--cc=39121@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).