unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Reuben Thomas <rrt@sc3d.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 24745@debbugs.gnu.org
Subject: bug#24745: 25.1.50; whitespace.el: fix beginning/end of buffer checks
Date: Thu, 3 Nov 2016 12:38:42 +0000	[thread overview]
Message-ID: <CAOnWdoiHsmWW2bGubpkAkgDwD+=BT7xP9YRqMgKx9pM0VUJdFA@mail.gmail.com> (raw)
In-Reply-To: <a8fbfa25-a8e8-5a9b-1944-56c73a5c0cfd@yandex.ru>

[-- Attachment #1: Type: text/plain, Size: 1027 bytes --]

On 3 November 2016 at 01:06, Dmitry Gutov <dgutov@yandex.ru> wrote:

>
> > * lisp/whitespace.el (whitespace-report-region): force parameter
> previously changed whitespace-style globally. Fix this, and use
>
> Please honor sentence-end-double-space, which is set to t in
> .dir-locals.el. Here and in other log messages.
>

I have sentence-end-double-space customized to nil, and a find-file hook
that changes it according to the contents of the buffer. I changed this
hook function so that it only ever sets sentence-end-double-space, and
never clears it.

After this, I find that the variable is correctly overridden by
.dir-locals.el in some magit buffers, but not in COMMIT_EDITMSG buffers
(which are in text-mode). I don't know whether this is something to do with
commit buffers being invoked via emacsclient.

Anyway, I ensured the spacing manually, and filed a magit bug. I thought
this problem might be of interest to other Emacs maintainers, as magit
seems to be (rightfully!) quite popular.

-- 
http://rrt.sc3d.org

[-- Attachment #2: Type: text/html, Size: 1816 bytes --]

  reply	other threads:[~2016-11-03 12:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-20 12:32 bug#24745: 25.1.50; whitespace.el: fix beginning/end of buffer checks Reuben Thomas
2016-10-20 22:43 ` Dmitry Gutov
2016-10-21 14:42   ` Reuben Thomas
2016-10-21 14:45     ` Dmitry Gutov
2016-10-21 14:52       ` Reuben Thomas
2016-10-24 23:36         ` Dmitry Gutov
2016-10-25 18:44           ` Reuben Thomas
2016-10-25 22:45             ` Dmitry Gutov
2016-10-25 23:26               ` Reuben Thomas
2016-11-01 15:32                 ` Reuben Thomas
2016-11-03  1:07                   ` Dmitry Gutov
2016-11-03 12:39                     ` Reuben Thomas
2016-11-03  1:06                 ` Dmitry Gutov
2016-11-03 12:38                   ` Reuben Thomas [this message]
     [not found] ` <handler.24745.B.14769667565022.ack@debbugs.gnu.org>
2016-10-21 14:38   ` bug#24745: Acknowledgement (25.1.50; whitespace.el: fix beginning/end of buffer checks) Reuben Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOnWdoiHsmWW2bGubpkAkgDwD+=BT7xP9YRqMgKx9pM0VUJdFA@mail.gmail.com' \
    --to=rrt@sc3d.org \
    --cc=24745@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).