From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Reuben Thomas Newsgroups: gmane.emacs.bugs Subject: bug#24745: 25.1.50; whitespace.el: fix beginning/end of buffer checks Date: Thu, 3 Nov 2016 12:38:42 +0000 Message-ID: References: <87pomv6w1h.fsf@sc3d.org> <83402aab-73d0-eeae-1df1-c717caf198ba@yandex.ru> <39a8c955-928a-1551-3943-b8ccfda38eca@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c0ecc5e7b87bf054064d6aa X-Trace: blaine.gmane.org 1478176756 17162 195.159.176.226 (3 Nov 2016 12:39:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 3 Nov 2016 12:39:16 +0000 (UTC) Cc: 24745@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 03 13:39:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2HIU-0003hQ-FE for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Nov 2016 13:39:10 +0100 Original-Received: from localhost ([::1]:60966 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2HIX-0001P0-6O for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Nov 2016 08:39:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2HIQ-0001Oj-1y for bug-gnu-emacs@gnu.org; Thu, 03 Nov 2016 08:39:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2HIM-0005nf-Um for bug-gnu-emacs@gnu.org; Thu, 03 Nov 2016 08:39:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54059) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c2HIM-0005nY-Nv for bug-gnu-emacs@gnu.org; Thu, 03 Nov 2016 08:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1c2HIM-0001au-C6 for bug-gnu-emacs@gnu.org; Thu, 03 Nov 2016 08:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Nov 2016 12:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24745 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24745-submit@debbugs.gnu.org id=B24745.14781767316111 (code B ref 24745); Thu, 03 Nov 2016 12:39:02 +0000 Original-Received: (at 24745) by debbugs.gnu.org; 3 Nov 2016 12:38:51 +0000 Original-Received: from localhost ([127.0.0.1]:41225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2HIB-0001aU-9Y for submit@debbugs.gnu.org; Thu, 03 Nov 2016 08:38:51 -0400 Original-Received: from mail-lf0-f53.google.com ([209.85.215.53]:34290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c2HI8-0001aF-UO for 24745@debbugs.gnu.org; Thu, 03 Nov 2016 08:38:49 -0400 Original-Received: by mail-lf0-f53.google.com with SMTP id b81so36714021lfe.1 for <24745@debbugs.gnu.org>; Thu, 03 Nov 2016 05:38:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=SL++qQ/JoYmmfzHBtGGR3pW+PO4LgvD2i7rsx9m6+Dk=; b=E9ge9/uWH94thf9lJ2sEq0gCD9WhLsBfMjLA0GhKmg4Ylvqquo1U6xwSc/vlMxH0ns KOQ21Dn6MehrKWbn06ivaJ5eEa+ILqMyBLaGQ5UmymJ5qCrjbedKf9h/xAQdz17FfLmT swTgCgrflN9tfbVHjj8pW3U72164+VV8IAFtg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=SL++qQ/JoYmmfzHBtGGR3pW+PO4LgvD2i7rsx9m6+Dk=; b=WjTOeD7VtDX44UCaAue1rv73O2giffdIC6QUV7TNQE7P8j87UPN0bf4xHfInP50fwh CBl8rHzhZ6/9mAS7MGGy90LhcafaFYy+5Guf/24lcOtclHppSWD3eSJcU3qubgl87Ldm 66ztu89iY7S/bUePRnOMYZmLCNmlo6H6YHkvZfXyHt/XrvC44sG/aoK5OwZBoqi9du7d sk73tO8YgNHpYPegveqxP38iYfVmLQTInVLho0vAK/+/qJwwUrBmcv/DXg0AWq0pDwZd 8kvjDXei/SJaW4GaGHU2nBAvlV5S8HKG7ZukTT4WbiGsJxF1MnrALij+NEklJNHmEgn4 b00A== X-Gm-Message-State: ABUngvcTsUZM8p1KXzSDUAJTk6iFN6jHb1WPwX9v1mJI9yqLOwvohfbbsL28wsb4NqZ94RvVYltplVLg5z+t+tpH X-Received: by 10.25.234.145 with SMTP id y17mr5359512lfi.25.1478176722872; Thu, 03 Nov 2016 05:38:42 -0700 (PDT) Original-Received: by 10.25.158.206 with HTTP; Thu, 3 Nov 2016 05:38:42 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:125297 Archived-At: --94eb2c0ecc5e7b87bf054064d6aa Content-Type: text/plain; charset=UTF-8 On 3 November 2016 at 01:06, Dmitry Gutov wrote: > > > * lisp/whitespace.el (whitespace-report-region): force parameter > previously changed whitespace-style globally. Fix this, and use > > Please honor sentence-end-double-space, which is set to t in > .dir-locals.el. Here and in other log messages. > I have sentence-end-double-space customized to nil, and a find-file hook that changes it according to the contents of the buffer. I changed this hook function so that it only ever sets sentence-end-double-space, and never clears it. After this, I find that the variable is correctly overridden by .dir-locals.el in some magit buffers, but not in COMMIT_EDITMSG buffers (which are in text-mode). I don't know whether this is something to do with commit buffers being invoked via emacsclient. Anyway, I ensured the spacing manually, and filed a magit bug. I thought this problem might be of interest to other Emacs maintainers, as magit seems to be (rightfully!) quite popular. -- http://rrt.sc3d.org --94eb2c0ecc5e7b87bf054064d6aa Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On = 3 November 2016 at 01:06, Dmitry Gutov <dgutov@yandex.ru> wro= te:

> * lisp/whitespace.el (whitespace-report-region): force parameter
previously changed whitespace-style globally. Fix this, and use

Please honor sentence-end-double-space, which is set to t in .dir-locals.el= . Here and in other log messages.

I have sentence-end-double-space customized to nil, and a find-file hook= that changes it according to the contents of the buffer. I changed this ho= ok function so that it only ever sets sentence-end-double-space, and never = clears it.

=
After this, I = find that the variable is correctly overridden by .dir-locals.el in some ma= git buffers, but not in COMMIT_EDITMSG buffers (which are in text-mode). I = don't know whether this is something to do with commit buffers being in= voked via emacsclient.

An= yway, I ensured the spacing manually, and filed a magit bug. I thought this= problem might be of interest to other Emacs maintainers, as magit seems to= be (rightfully!) quite popular.

--
http://rrt.sc3d.org
--94eb2c0ecc5e7b87bf054064d6aa--