From: Dmitry Gutov <dgutov@yandex.ru>
To: Reuben Thomas <rrt@sc3d.org>
Cc: 24745@debbugs.gnu.org
Subject: bug#24745: 25.1.50; whitespace.el: fix beginning/end of buffer checks
Date: Tue, 25 Oct 2016 02:36:59 +0300 [thread overview]
Message-ID: <83402aab-73d0-eeae-1df1-c717caf198ba@yandex.ru> (raw)
In-Reply-To: <CAOnWdogJBQ_co3hMMStYHbArQJt+VDnP5UG553oxPNt9QtuiiA@mail.gmail.com>
On 21.10.2016 17:52, Reuben Thomas wrote:
> emacs -Q
>
> Open a new buffer
>
> Type: SPC foo
>
> Then, whitespace-report will show an X in the second column (problems
> detected) for "Empty lines at end of buffer".
Thanks. I get it now.
A few comments on the patches themselves:
- "remove duplicate documentation from the Commentary" sounds fine to
me, but maybe we should leave something in its stead. The first part can
be replaced with a reference to the `whitespace-style' docstring. The
second one... is it really that out of date? The list of variables seems
like it can be useful.
- The commit messages don't follow the ChangeLog format, see
https://www.gnu.org/prep/standards/html_node/Change-Logs.html, or simply
the existing commit messages.
next prev parent reply other threads:[~2016-10-24 23:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 12:32 bug#24745: 25.1.50; whitespace.el: fix beginning/end of buffer checks Reuben Thomas
2016-10-20 22:43 ` Dmitry Gutov
2016-10-21 14:42 ` Reuben Thomas
2016-10-21 14:45 ` Dmitry Gutov
2016-10-21 14:52 ` Reuben Thomas
2016-10-24 23:36 ` Dmitry Gutov [this message]
2016-10-25 18:44 ` Reuben Thomas
2016-10-25 22:45 ` Dmitry Gutov
2016-10-25 23:26 ` Reuben Thomas
2016-11-01 15:32 ` Reuben Thomas
2016-11-03 1:07 ` Dmitry Gutov
2016-11-03 12:39 ` Reuben Thomas
2016-11-03 1:06 ` Dmitry Gutov
2016-11-03 12:38 ` Reuben Thomas
[not found] ` <handler.24745.B.14769667565022.ack@debbugs.gnu.org>
2016-10-21 14:38 ` bug#24745: Acknowledgement (25.1.50; whitespace.el: fix beginning/end of buffer checks) Reuben Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83402aab-73d0-eeae-1df1-c717caf198ba@yandex.ru \
--to=dgutov@yandex.ru \
--cc=24745@debbugs.gnu.org \
--cc=rrt@sc3d.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).