bug#48998: 28.0.50; pyton readline warning improve

bug#48998: 28.0.50; pyton readline warning improve

[Ben Schw]

[-- Attachment #1.1: Type: text/plain, Size: 279 bytes --]

See attached patch.
lisp/progmodes/python.el (python-shell-completion-native-turn-on-maybe):
If you just start out with python it is not obvious that "readline" is a
pip package that you can install. And as a new user you will get this
warning because readline is not installed.

[-- Attachment #1.2: Type: text/html, Size: 381 bytes --]

[-- Attachment #2: BUGS --]
[-- Type: application/octet-stream, Size: 932 bytes --]

If you think you may have found a bug in GNU Emacs, please read the
Bugs section of the Emacs manual for advice on

(1) how to tell when to report a bug, and
(2) how to write a useful bug report and what information it needs to have.

You can read the Bugs section of the manual from inside Emacs.
Start Emacs, and press
  C-h r       (to view the Emacs manual)
  m Bugs RET  (to go to the section on Bugs)
Or you can use the standalone Info program:
  info emacs
  m Bugs RET
(Standalone Info is part of the Texinfo distribution, not part of the
Emacs distribution.)

Printed copies of the Emacs manual can be purchased from the Free
Software Foundation's online store at <https://shop.fsf.org/>.

If necessary, you can read the manual without an info program:

    cat info/emacs* | more "+/^File: emacs.*,  Node: Bugs,"


Please first check the file etc/PROBLEMS (e.g. with C-h C-p in Emacs) to
make sure it isn't a known issue.

bug#48998: 28.0.50; pyton readline warning improve

[Eli Zaretskii]

> From: Ben Schw <benjamin.schwerdtner@gmail.com>
> Date: Sun, 13 Jun 2021 10:29:58 +0200
> 
> See attached patch.
> lisp/progmodes/python.el (python-shell-completion-native-turn-on-maybe):
> If you just start out with python it is not obvious that "readline" is a
> pip package that you can install. And as a new user you will get this
> warning because readline is not installed.

Thanks, but which file is your patch for?  And how is that patch
relevant to the issue with python.el which you describe?

bug#48998: Python readline warning improve

[Ben Schw]

[-- Attachment #1.1: Type: text/plain, Size: 125 bytes --]

I probalby made a mistake with the patch.
The new attached one is correct.
It ads a single line in lisp/progmodes/python.el.

[-- Attachment #1.2: Type: text/html, Size: 166 bytes --]

[-- Attachment #2: 0001-Improve-readline-warn.patch --]
[-- Type: text/x-patch, Size: 1160 bytes --]

From c35aa8b6d3e1da42d5aae1bc118bf9c3c97c5a24 Mon Sep 17 00:00:00 2001
From: Benj <Benjamin.Schwerdtner@gmail.com>
Date: Sun, 13 Jun 2021 10:09:14 +0200
Subject: [PATCH] Improve readline warn

* lisp/progmodes/python.el (python-shell-completion-native-turn-on-maybe)
Copyright-paperwork-exempt: yes
---
 lisp/progmodes/python.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el
index f7267bdef2..947889ed11 100644
--- a/lisp/progmodes/python.el
+++ b/lisp/progmodes/python.el
@@ -3691,7 +3691,8 @@ python-shell-completion-native-turn-on-maybe
             (format "was t and %S is not part of the "
                     (file-name-nondirectory python-shell-interpreter))
             "`python-shell-completion-native-disabled-interpreters' "
-            "list.  Native completions have been disabled locally. "))
+            "list.  Native completions have been disabled locally. "
+            "Or install the python package \"readline\". "))
           (python-shell-completion-native-turn-off msg))))))
 
 (defun python-shell-completion-native-turn-on-maybe-with-msg ()
-- 
2.25.1

bug#48998: 28.0.50; pyton readline warning improve

[Lars Ingebrigtsen]

Ben Schw <benjamin.schwerdtner@gmail.com> writes:

> I probalby made a mistake with the patch. 
> The new attached one is correct. 
> It ads a single line in lisp/progmodes/python.el. 

Thanks; applied with a minor rewording to Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#48998: 28.0.50; pyton readline warning improve

[Ben Schw]

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

Sick! Thanks for emacs

On Wed, Nov 10, 2021 at 10:07 AM Lars Ingebrigtsen <larsi@gnus.org> wrote:

> Ben Schw <benjamin.schwerdtner@gmail.com> writes:
>
> > I probalby made a mistake with the patch.
> > The new attached one is correct.
> > It ads a single line in lisp/progmodes/python.el.
>
> Thanks; applied with a minor rewording to Emacs 29.
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no
>

[-- Attachment #2: Type: text/html, Size: 931 bytes --]

bug#48998: 28.0.50; pyton readline warning improve

[Stefan Kangas]

Ben Schw <benjamin.schwerdtner@gmail.com> writes:

> See attached patch.
> lisp/progmodes/python.el (python-shell-completion-native-turn-on-maybe):
> If you just start out with python it is not obvious that "readline" is a
> pip package that you can install. And as a new user you will get this
> warning because readline is not installed.

Could you provide a recipe for how to reproduce the error you see?

Thanks in advance.