unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ben Schw <benjamin.schwerdtner@gmail.com>
To: 48998@debbugs.gnu.org
Subject: bug#48998: Python readline warning improve
Date: Mon, 21 Jun 2021 08:30:33 +0200	[thread overview]
Message-ID: <CAOiYe4aXoyKS3sDz7cWNSJK=Q-DB=6yofR-73NF647-ZS61bzw@mail.gmail.com> (raw)
In-Reply-To: <CAOiYe4ZbPVqz9SeDJ2dhzhAf+YE69phRg-=f=ZF5Vyae-QAgTA@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 125 bytes --]

I probalby made a mistake with the patch.
The new attached one is correct.
It ads a single line in lisp/progmodes/python.el.

[-- Attachment #1.2: Type: text/html, Size: 166 bytes --]

[-- Attachment #2: 0001-Improve-readline-warn.patch --]
[-- Type: text/x-patch, Size: 1160 bytes --]

From c35aa8b6d3e1da42d5aae1bc118bf9c3c97c5a24 Mon Sep 17 00:00:00 2001
From: Benj <Benjamin.Schwerdtner@gmail.com>
Date: Sun, 13 Jun 2021 10:09:14 +0200
Subject: [PATCH] Improve readline warn

* lisp/progmodes/python.el (python-shell-completion-native-turn-on-maybe)
Copyright-paperwork-exempt: yes
---
 lisp/progmodes/python.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el
index f7267bdef2..947889ed11 100644
--- a/lisp/progmodes/python.el
+++ b/lisp/progmodes/python.el
@@ -3691,7 +3691,8 @@ python-shell-completion-native-turn-on-maybe
             (format "was t and %S is not part of the "
                     (file-name-nondirectory python-shell-interpreter))
             "`python-shell-completion-native-disabled-interpreters' "
-            "list.  Native completions have been disabled locally. "))
+            "list.  Native completions have been disabled locally. "
+            "Or install the python package \"readline\". "))
           (python-shell-completion-native-turn-off msg))))))
 
 (defun python-shell-completion-native-turn-on-maybe-with-msg ()
-- 
2.25.1


  parent reply	other threads:[~2021-06-21  6:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-13  8:29 bug#48998: 28.0.50; pyton readline warning improve Ben Schw
2021-06-13  8:46 ` Eli Zaretskii
2021-06-21  6:30 ` Ben Schw [this message]
2021-11-10  9:07   ` Lars Ingebrigtsen
2021-11-10 15:28     ` Ben Schw
2021-10-24  7:11 ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOiYe4aXoyKS3sDz7cWNSJK=Q-DB=6yofR-73NF647-ZS61bzw@mail.gmail.com' \
    --to=benjamin.schwerdtner@gmail.com \
    --cc=48998@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).