unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#58098: Improve composition rules for Gumrukhi
@ 2022-09-26 18:43 समीर सिंह Sameer Singh
  2022-09-26 18:47 ` समीर सिंह Sameer Singh
  0 siblings, 1 reply; 9+ messages in thread
From: समीर सिंह Sameer Singh @ 2022-09-26 18:43 UTC (permalink / raw)
  To: 58098

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

Hi
In this patch I have added support for Gurmukhi Addak, Yakash, Udaat etc to
improve its composition rules.
I have also added the word "Gurmukhi" to the doc-string of punjabi-itrans
and punjabi-inscript so that they could be more easily found.

Finally I have also added support for chess symbols.

Please review the patch, it will be attached in the next mail.
Thanks.

[-- Attachment #2: Type: text/html, Size: 497 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#58098: Improve composition rules for Gumrukhi
  2022-09-26 18:43 bug#58098: Improve composition rules for Gumrukhi समीर सिंह Sameer Singh
@ 2022-09-26 18:47 ` समीर सिंह Sameer Singh
  2022-09-26 20:00   ` समीर सिंह Sameer Singh
  0 siblings, 1 reply; 9+ messages in thread
From: समीर सिंह Sameer Singh @ 2022-09-26 18:47 UTC (permalink / raw)
  To: 58098


[-- Attachment #1.1: Type: text/plain, Size: 511 bytes --]

On Tue, Sep 27, 2022 at 12:13 AM समीर सिंह Sameer Singh <
lumarzeli30@gmail.com> wrote:

> Hi
> In this patch I have added support for Gurmukhi Addak, Yakash, Udaat etc
> to improve its composition rules.
> I have also added the word "Gurmukhi" to the doc-string of punjabi-itrans
> and punjabi-inscript so that they could be more easily found.
>
> Finally I have also added support for chess symbols.
>
> Please review the patch, it will be attached in the next mail.
> Thanks.
>

[-- Attachment #1.2: Type: text/html, Size: 888 bytes --]

[-- Attachment #2: 0001-Improve-Gurmukhi-composition-rules-Bug-58098.patch --]
[-- Type: text/x-patch, Size: 3875 bytes --]

From 09669d027d59e9434b31ae6bf7cceaf1f518937f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0=20=E0=A4=B8=E0=A4=BF?=
 =?UTF-8?q?=E0=A4=82=E0=A4=B9=20Sameer=20Singh?= <lumarzeli30@gmail.com>
Date: Tue, 27 Sep 2022 00:03:23 +0530
Subject: [PATCH] Improve Gurmukhi composition rules (Bug#58098)

* lisp/language/indian.el: Improve composition rules for Gurmukhi.
* lisp/leim/quail/indian.el: Improve documentation for punjabi-itrans
and punjabi-inscript.

* lisp/international/fontset.el (script-representative-chars)
(setup-default-fontset): Support Chess Symbols.
---
 lisp/international/fontset.el | 6 ++++--
 lisp/language/indian.el       | 9 +++++----
 lisp/leim/quail/indian.el     | 4 ++--
 3 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/lisp/international/fontset.el b/lisp/international/fontset.el
index 99c7848704..23ef17488d 100644
--- a/lisp/international/fontset.el
+++ b/lisp/international/fontset.el
@@ -300,7 +300,8 @@ font-encoding-charset-alist
 	(ottoman-siyaq-number #x1ed01)
 	(mahjong-tile #x1F000)
 	(domino-tile #x1F030)
-        (emoji #x1F300 #x1F600)))
+        (emoji #x1F300 #x1F600)
+        (chess-symbol #x1FA00 #x1FA67)))
 
 (defvar otf-script-alist)
 
@@ -836,7 +837,8 @@ setup-default-fontset
                     tai-tham
 		    mahjong-tile
 		    domino-tile
-                    emoji))
+                    emoji
+                    chess-symbol))
     (set-fontset-font "fontset-default"
 		      script (font-spec :registry "iso10646-1" :script script)
 		      nil 'append))
diff --git a/lisp/language/indian.el b/lisp/language/indian.el
index 407173827f..81b7cbd99b 100644
--- a/lisp/language/indian.el
+++ b/lisp/language/indian.el
@@ -340,23 +340,24 @@ bengali-composable-pattern
 
 (defconst gurmukhi-composable-pattern
   (let ((table
-	 '(("a" . "[\u0A01\u0A02\u0A70]") ; SIGN ADAK BINDI .. BINDI, TIPPI
+	 '(("a" . "[\u0A01\u0A02\u0A70\u0A71\u0A75]") ; SIGN ADAK BINDI .. BINDI, TIPPI, ADDAK, YAKASH
 	   ("A" . "\u0A03")		; SIGN VISARGA
-	   ("V" . "[\u0A05-\u0A14]")	; independent vowel
+	   ("V" . "[\u0A05-\u0A14\u0A72\u0A73]")	; independent vowel
 	   ("C" . "[\u0A15-\u0A39\u0A59-\u0A5E]")	; consonant
 	   ("Y" . "[\u0A2F\u0A30\u0A35\u0A39]") ; YA, RA, VA, HA
 	   ("n" . "\u0A3C")		; NUKTA
 	   ("v" . "[\u0A3E-\u0A4C]")	; vowel sign
 	   ("H" . "\u0A4D")		; VIRAMA
+           ("s" . "\u0A51")		; stress sign
 	   ("N" . "\u200C")		; ZWNJ
 	   ("J" . "\u200D")		; ZWJ
 	   ("X" . "[\u0A00-\u0A7F]"))))	; all coverage
     (indian-compose-regexp
      (concat
       ;; consonant-based syllables, or
-      "Cn?\\(?:J?HJ?Cn?\\)*\\(?:H[NJ]?\\|v*n?a?A?\\)\\|"
+      "Cn?\\(?:J?HJ?Cn?\\)*\\(?:H[NJ]?\\|v*n?a?s?v?A?\\)\\|"
       ;; syllables with an independent vowel, or
-      "Vn?\\(?:J?HY\\)?v*n?a?A?\\|"
+      "Vn?\\(?:J?HY\\)?v*n?a?s?A?\\|"
       ;; special consonant form, or
       "JHY\\|"
       ;; any other singleton characters
diff --git a/lisp/leim/quail/indian.el b/lisp/leim/quail/indian.el
index 431d8369c1..0594ae7beb 100644
--- a/lisp/leim/quail/indian.el
+++ b/lisp/leim/quail/indian.el
@@ -82,7 +82,7 @@ "\\''"
     (quail-define-package "punjabi-itrans" "Punjabi" "PnjIT" t "Punjabi ITRANS"))
 (quail-define-indian-trans-package
  indian-pnj-itrans-v5-hash "punjabi-itrans" "Punjabi" "PnjIT"
- "Punjabi transliteration by ITRANS method.")
+ "Punjabi (Gurmukhi) transliteration by ITRANS method.")
 
 (if nil
     (quail-define-package "gujarati-itrans" "Gujarati" "GjrIT" t "Gujarati ITRANS"))
@@ -631,7 +631,7 @@ inscript-tml-keytable
 (quail-define-inscript-package
  indian-pnj-base-table inscript-dev-keytable
  "punjabi-inscript" "Punjabi" "PnjIS"
- "Punjabi keyboard Inscript.")
+ "Punjabi (Gurmukhi) keyboard Inscript.")
 
 (if nil
     (quail-define-package "gujarati-inscript" "Gujarati" "GjrIS" t "Gujarati keyboard Inscript"))
-- 
2.37.3


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* bug#58098: Improve composition rules for Gumrukhi
  2022-09-26 18:47 ` समीर सिंह Sameer Singh
@ 2022-09-26 20:00   ` समीर सिंह Sameer Singh
  2022-09-27 13:12     ` Eli Zaretskii
  0 siblings, 1 reply; 9+ messages in thread
From: समीर सिंह Sameer Singh @ 2022-09-26 20:00 UTC (permalink / raw)
  To: 58098


[-- Attachment #1.1: Type: text/plain, Size: 863 bytes --]

Looks like I was wrong about adding "Gurmukhi" to the doc-strings in the
input method, they do not show up and will also not improve
searchability even if they were there, so here is the revised patch without
it.

On Tue, Sep 27, 2022 at 12:17 AM समीर सिंह Sameer Singh <
lumarzeli30@gmail.com> wrote:

>
>
> On Tue, Sep 27, 2022 at 12:13 AM समीर सिंह Sameer Singh <
> lumarzeli30@gmail.com> wrote:
>
>> Hi
>> In this patch I have added support for Gurmukhi Addak, Yakash, Udaat etc
>> to improve its composition rules.
>> I have also added the word "Gurmukhi" to the doc-string of punjabi-itrans
>> and punjabi-inscript so that they could be more easily found.
>>
>> Finally I have also added support for chess symbols.
>>
>> Please review the patch, it will be attached in the next mail.
>> Thanks.
>>
>

[-- Attachment #1.2: Type: text/html, Size: 1538 bytes --]

[-- Attachment #2: 0001-Improve-Gurmukhi-composition-rules-Bug-58098.patch --]
[-- Type: text/x-patch, Size: 2822 bytes --]

From a5344e6b827f8db4b4db10f3dacf5587dc199525 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0=20=E0=A4=B8=E0=A4=BF?=
 =?UTF-8?q?=E0=A4=82=E0=A4=B9=20Sameer=20Singh?= <lumarzeli30@gmail.com>
Date: Tue, 27 Sep 2022 00:03:23 +0530
Subject: [PATCH] Improve Gurmukhi composition rules (Bug#58098)

* lisp/language/indian.el: Improve composition rules for Gurmukhi.

* lisp/international/fontset.el (script-representative-chars)
(setup-default-fontset): Support Chess Symbols.
---
 lisp/international/fontset.el | 6 ++++--
 lisp/language/indian.el       | 9 +++++----
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/lisp/international/fontset.el b/lisp/international/fontset.el
index 99c7848704..23ef17488d 100644
--- a/lisp/international/fontset.el
+++ b/lisp/international/fontset.el
@@ -300,7 +300,8 @@ font-encoding-charset-alist
 	(ottoman-siyaq-number #x1ed01)
 	(mahjong-tile #x1F000)
 	(domino-tile #x1F030)
-        (emoji #x1F300 #x1F600)))
+        (emoji #x1F300 #x1F600)
+        (chess-symbol #x1FA00 #x1FA67)))
 
 (defvar otf-script-alist)
 
@@ -836,7 +837,8 @@ setup-default-fontset
                     tai-tham
 		    mahjong-tile
 		    domino-tile
-                    emoji))
+                    emoji
+                    chess-symbol))
     (set-fontset-font "fontset-default"
 		      script (font-spec :registry "iso10646-1" :script script)
 		      nil 'append))
diff --git a/lisp/language/indian.el b/lisp/language/indian.el
index 407173827f..81b7cbd99b 100644
--- a/lisp/language/indian.el
+++ b/lisp/language/indian.el
@@ -340,23 +340,24 @@ bengali-composable-pattern
 
 (defconst gurmukhi-composable-pattern
   (let ((table
-	 '(("a" . "[\u0A01\u0A02\u0A70]") ; SIGN ADAK BINDI .. BINDI, TIPPI
+	 '(("a" . "[\u0A01\u0A02\u0A70\u0A71\u0A75]") ; SIGN ADAK BINDI .. BINDI, TIPPI, ADDAK, YAKASH
 	   ("A" . "\u0A03")		; SIGN VISARGA
-	   ("V" . "[\u0A05-\u0A14]")	; independent vowel
+	   ("V" . "[\u0A05-\u0A14\u0A72\u0A73]")	; independent vowel
 	   ("C" . "[\u0A15-\u0A39\u0A59-\u0A5E]")	; consonant
 	   ("Y" . "[\u0A2F\u0A30\u0A35\u0A39]") ; YA, RA, VA, HA
 	   ("n" . "\u0A3C")		; NUKTA
 	   ("v" . "[\u0A3E-\u0A4C]")	; vowel sign
 	   ("H" . "\u0A4D")		; VIRAMA
+           ("s" . "\u0A51")		; stress sign
 	   ("N" . "\u200C")		; ZWNJ
 	   ("J" . "\u200D")		; ZWJ
 	   ("X" . "[\u0A00-\u0A7F]"))))	; all coverage
     (indian-compose-regexp
      (concat
       ;; consonant-based syllables, or
-      "Cn?\\(?:J?HJ?Cn?\\)*\\(?:H[NJ]?\\|v*n?a?A?\\)\\|"
+      "Cn?\\(?:J?HJ?Cn?\\)*\\(?:H[NJ]?\\|v*n?a?s?v?A?\\)\\|"
       ;; syllables with an independent vowel, or
-      "Vn?\\(?:J?HY\\)?v*n?a?A?\\|"
+      "Vn?\\(?:J?HY\\)?v*n?a?s?A?\\|"
       ;; special consonant form, or
       "JHY\\|"
       ;; any other singleton characters
-- 
2.37.3


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* bug#58098: Improve composition rules for Gumrukhi
  2022-09-26 20:00   ` समीर सिंह Sameer Singh
@ 2022-09-27 13:12     ` Eli Zaretskii
  2022-09-27 13:52       ` समीर सिंह Sameer Singh
  0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2022-09-27 13:12 UTC (permalink / raw)
  To: समीर सिंह Sameer Singh
  Cc: 58098

> From: समीर सिंह Sameer Singh
>  <lumarzeli30@gmail.com>
> Date: Tue, 27 Sep 2022 01:30:31 +0530
> 
> --- a/lisp/international/fontset.el
> +++ b/lisp/international/fontset.el
> @@ -300,7 +300,8 @@ font-encoding-charset-alist
>  	(ottoman-siyaq-number #x1ed01)
>  	(mahjong-tile #x1F000)
>  	(domino-tile #x1F030)
> -        (emoji #x1F300 #x1F600)))
> +        (emoji #x1F300 #x1F600)
> +        (chess-symbol #x1FA00 #x1FA67)))

I don't understand this part: why should we require #x1FA67?  Did you
perhaps mean this:

      (chess-symbol . [#x1FA00 #x1FA67])

> @@ -836,7 +837,8 @@ setup-default-fontset
>                      tai-tham
>  		    mahjong-tile
>  		    domino-tile
> -                    emoji))
> +                    emoji
> +                    chess-symbol))

We already have the setup for chess-symbol, below this line where you
are making changes.  Is it not enough for some reason?





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#58098: Improve composition rules for Gumrukhi
  2022-09-27 13:12     ` Eli Zaretskii
@ 2022-09-27 13:52       ` समीर सिंह Sameer Singh
  2022-09-27 14:08         ` Eli Zaretskii
  0 siblings, 1 reply; 9+ messages in thread
From: समीर सिंह Sameer Singh @ 2022-09-27 13:52 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 58098

[-- Attachment #1: Type: text/plain, Size: 1712 bytes --]

>
> I don't understand this part: why should we require #x1FA67?  Did you
> perhaps mean this:
>
>       (chess-symbol . [#x1FA00 #x1FA67])


Isn't the script-representative-chars used to improve font selection by
requesting more characters?
So does the specific character requested have any effect? because I chose
it randomly.

We already have the setup for chess-symbol, below this line where you
> are making changes.  Is it not enough for some reason?
>

Prior to this patch the chess symbol block was not rendered on my machine
despite having its font (Noto Sans Symbols2)

On Tue, Sep 27, 2022 at 6:43 PM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: समीर सिंह Sameer Singh
> >  <lumarzeli30@gmail.com>
> > Date: Tue, 27 Sep 2022 01:30:31 +0530
> >
> > --- a/lisp/international/fontset.el
> > +++ b/lisp/international/fontset.el
> > @@ -300,7 +300,8 @@ font-encoding-charset-alist
> >       (ottoman-siyaq-number #x1ed01)
> >       (mahjong-tile #x1F000)
> >       (domino-tile #x1F030)
> > -        (emoji #x1F300 #x1F600)))
> > +        (emoji #x1F300 #x1F600)
> > +        (chess-symbol #x1FA00 #x1FA67)))
>
> I don't understand this part: why should we require #x1FA67?  Did you
> perhaps mean this:
>
>       (chess-symbol . [#x1FA00 #x1FA67])
>
> > @@ -836,7 +837,8 @@ setup-default-fontset
> >                      tai-tham
> >                   mahjong-tile
> >                   domino-tile
> > -                    emoji))
> > +                    emoji
> > +                    chess-symbol))
>
> We already have the setup for chess-symbol, below this line where you
> are making changes.  Is it not enough for some reason?
>

[-- Attachment #2: Type: text/html, Size: 2621 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#58098: Improve composition rules for Gumrukhi
  2022-09-27 13:52       ` समीर सिंह Sameer Singh
@ 2022-09-27 14:08         ` Eli Zaretskii
  2022-09-27 15:24           ` समीर सिंह Sameer Singh
  0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2022-09-27 14:08 UTC (permalink / raw)
  To: समीर सिंह Sameer Singh
  Cc: 58098

> From: समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
> Date: Tue, 27 Sep 2022 19:22:09 +0530
> Cc: 58098@debbugs.gnu.org
> 
>  I don't understand this part: why should we require #x1FA67?  Did you
>  perhaps mean this:
> 
>        (chess-symbol . [#x1FA00 #x1FA67])
> 
> Isn't the script-representative-chars used to improve font selection by requesting more characters?
> So does the specific character requested have any effect? because I chose it randomly.

The form

       (chess-symbol #x1FA00 #x1FA67)

requires that _both_ #x1FA00 and #x1FA67 be supported by a font, for
it to be eligible to display chess-symbols.  By contrast, the form

       (chess-symbol . [#x1FA00 #x1FA67])

requires that _either_ of the two characters is supported.  So my
question is: do we really want _both_ of the characters supported by a
font, and if not, do we really want Emacs to reject such a font?

Did you look at what #x1FA67 looks like?  It is not a "traditional"
chess symbol.  And neither are the characters that are its neighbors.

>  We already have the setup for chess-symbol, below this line where you
>  are making changes.  Is it not enough for some reason?
> 
> Prior to this patch the chess symbol block was not rendered on my machine despite having its font (Noto
> Sans Symbols2) 

You don't have Symbola installed?





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#58098: Improve composition rules for Gumrukhi
  2022-09-27 14:08         ` Eli Zaretskii
@ 2022-09-27 15:24           ` समीर सिंह Sameer Singh
  2022-09-28 12:39             ` Eli Zaretskii
  0 siblings, 1 reply; 9+ messages in thread
From: समीर सिंह Sameer Singh @ 2022-09-27 15:24 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 58098


[-- Attachment #1.1: Type: text/plain, Size: 3474 bytes --]

The form
>
>        (chess-symbol #x1FA00 #x1FA67)
>
> requires that _both_ #x1FA00 and #x1FA67 be supported by a font, for
> it to be eligible to display chess-symbols.  By contrast, the form
>
>        (chess-symbol . [#x1FA00 #x1FA67])
>
> requires that _either_ of the two characters is supported.  So my
> question is: do we really want _both_ of the characters supported by a
> font, and if not, do we really want Emacs to reject such a font?
>

I have updated the patch accordingly and replaced (chess-symbol #x1FA00
#x1FA67) with  (chess-symbol . [#x1FA00 #x1FA67])

> You don't have Symbola installed?

I have the Symbola font installed via the gdouros-symbola-fonts package on
my Fedora37 system, but it does not seem to support
the chess-symbols block as verified by hb-view.
Its description in the fedora wiki also does not mention the chess-symbols
block:

> Symbola covers the following scripts and symbols supported by The Unicode
> Standard 5.2: Basic Latin, Latin-1 Supplement, Latin Extended-A, IPA
> Extensions, Spacing Modifier Letters, Greek and Coptic, Cyrillic, Cyrillic
> Supplementary, General Punctuation, Superscripts and Subscripts, Combining
> Diacritical Marks for Symbols, Letterlike Symbols, Number Forms, Arrows,
> Mathematical Operators, Miscellaneous Technical, Control Pictures, Optical
> Character Recognition, Box Drawing, Block Elements, Geometric Shapes,
> Miscellaneous Symbols, Dingbats, Miscellaneous Mathematical Symbols-A,
> Supplemental Arrows-A, Supplemental Arrows-B, Miscellaneous Mathematical
> Symbols-B, Supplemental Mathematical Operators, Miscellaneous Symbols and
> Arrows, Supplemental Punctuation, CJK Symbols and Punctuation, Yijing
> Hexagram Symbols, Vertical Forms, Combining Half Marks, CJK Compatibility
> Forms, Specials, Tai Xuan Jing Symbols, Counting Rod Numerals, Mathematical
> Alphanumeric Symbols, Mahjong Tile Symbols, Domino Tile Symbols.
>

On Tue, Sep 27, 2022 at 7:38 PM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
> > Date: Tue, 27 Sep 2022 19:22:09 +0530
> > Cc: 58098@debbugs.gnu.org
> >
> >  I don't understand this part: why should we require #x1FA67?  Did you
> >  perhaps mean this:
> >
> >        (chess-symbol . [#x1FA00 #x1FA67])
> >
> > Isn't the script-representative-chars used to improve font selection by
> requesting more characters?
> > So does the specific character requested have any effect? because I
> chose it randomly.
>
> The form
>
>        (chess-symbol #x1FA00 #x1FA67)
>
> requires that _both_ #x1FA00 and #x1FA67 be supported by a font, for
> it to be eligible to display chess-symbols.  By contrast, the form
>
>        (chess-symbol . [#x1FA00 #x1FA67])
>
> requires that _either_ of the two characters is supported.  So my
> question is: do we really want _both_ of the characters supported by a
> font, and if not, do we really want Emacs to reject such a font?
>
> Did you look at what #x1FA67 looks like?  It is not a "traditional"
> chess symbol.  And neither are the characters that are its neighbors.
>
> >  We already have the setup for chess-symbol, below this line where you
> >  are making changes.  Is it not enough for some reason?
> >
> > Prior to this patch the chess symbol block was not rendered on my
> machine despite having its font (Noto
> > Sans Symbols2)
>
> You don't have Symbola installed?
>

[-- Attachment #1.2: Type: text/html, Size: 5168 bytes --]

[-- Attachment #2: 0001-Improve-Gurmukhi-composition-rules-Bug-58098.patch --]
[-- Type: text/x-patch, Size: 2826 bytes --]

From a5344e6b827f8db4b4db10f3dacf5587dc199525 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0=20=E0=A4=B8=E0=A4=BF?=
 =?UTF-8?q?=E0=A4=82=E0=A4=B9=20Sameer=20Singh?= <lumarzeli30@gmail.com>
Date: Tue, 27 Sep 2022 00:03:23 +0530
Subject: [PATCH] Improve Gurmukhi composition rules (Bug#58098)

* lisp/language/indian.el: Improve composition rules for Gurmukhi.

* lisp/international/fontset.el (script-representative-chars)
(setup-default-fontset): Support Chess Symbols.
---
 lisp/international/fontset.el | 6 ++++--
 lisp/language/indian.el       | 9 +++++----
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/lisp/international/fontset.el b/lisp/international/fontset.el
index 99c7848704..23ef17488d 100644
--- a/lisp/international/fontset.el
+++ b/lisp/international/fontset.el
@@ -300,7 +300,8 @@ font-encoding-charset-alist
 	(ottoman-siyaq-number #x1ed01)
 	(mahjong-tile #x1F000)
 	(domino-tile #x1F030)
-        (emoji #x1F300 #x1F600)))
+        (emoji #x1F300 #x1F600)
+        (chess-symbol . [#x1FA00 #x1FA67])))
 
 (defvar otf-script-alist)
 
@@ -836,7 +837,8 @@ setup-default-fontset
                     tai-tham
 		    mahjong-tile
 		    domino-tile
-                    emoji))
+                    emoji
+                    chess-symbol))
     (set-fontset-font "fontset-default"
 		      script (font-spec :registry "iso10646-1" :script script)
 		      nil 'append))
diff --git a/lisp/language/indian.el b/lisp/language/indian.el
index 407173827f..81b7cbd99b 100644
--- a/lisp/language/indian.el
+++ b/lisp/language/indian.el
@@ -340,23 +340,24 @@ bengali-composable-pattern
 
 (defconst gurmukhi-composable-pattern
   (let ((table
-	 '(("a" . "[\u0A01\u0A02\u0A70]") ; SIGN ADAK BINDI .. BINDI, TIPPI
+	 '(("a" . "[\u0A01\u0A02\u0A70\u0A71\u0A75]") ; SIGN ADAK BINDI .. BINDI, TIPPI, ADDAK, YAKASH
 	   ("A" . "\u0A03")		; SIGN VISARGA
-	   ("V" . "[\u0A05-\u0A14]")	; independent vowel
+	   ("V" . "[\u0A05-\u0A14\u0A72\u0A73]")	; independent vowel
 	   ("C" . "[\u0A15-\u0A39\u0A59-\u0A5E]")	; consonant
 	   ("Y" . "[\u0A2F\u0A30\u0A35\u0A39]") ; YA, RA, VA, HA
 	   ("n" . "\u0A3C")		; NUKTA
 	   ("v" . "[\u0A3E-\u0A4C]")	; vowel sign
 	   ("H" . "\u0A4D")		; VIRAMA
+           ("s" . "\u0A51")		; stress sign
 	   ("N" . "\u200C")		; ZWNJ
 	   ("J" . "\u200D")		; ZWJ
 	   ("X" . "[\u0A00-\u0A7F]"))))	; all coverage
     (indian-compose-regexp
      (concat
       ;; consonant-based syllables, or
-      "Cn?\\(?:J?HJ?Cn?\\)*\\(?:H[NJ]?\\|v*n?a?A?\\)\\|"
+      "Cn?\\(?:J?HJ?Cn?\\)*\\(?:H[NJ]?\\|v*n?a?s?v?A?\\)\\|"
       ;; syllables with an independent vowel, or
-      "Vn?\\(?:J?HY\\)?v*n?a?A?\\|"
+      "Vn?\\(?:J?HY\\)?v*n?a?s?A?\\|"
       ;; special consonant form, or
       "JHY\\|"
       ;; any other singleton characters
-- 
2.37.3


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* bug#58098: Improve composition rules for Gumrukhi
  2022-09-27 15:24           ` समीर सिंह Sameer Singh
@ 2022-09-28 12:39             ` Eli Zaretskii
  2022-09-28 12:57               ` समीर सिंह Sameer Singh
  0 siblings, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2022-09-28 12:39 UTC (permalink / raw)
  To: समीर सिंह Sameer Singh
  Cc: 58098-done

> From: समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
> Date: Tue, 27 Sep 2022 20:54:22 +0530
> Cc: 58098@debbugs.gnu.org
> 
>  The form
> 
>         (chess-symbol #x1FA00 #x1FA67)
> 
>  requires that _both_ #x1FA00 and #x1FA67 be supported by a font, for
>  it to be eligible to display chess-symbols.  By contrast, the form
> 
>         (chess-symbol . [#x1FA00 #x1FA67])
> 
>  requires that _either_ of the two characters is supported.  So my
>  question is: do we really want _both_ of the characters supported by a
>  font, and if not, do we really want Emacs to reject such a font?
> 
>  I have updated the patch accordingly and replaced (chess-symbol #x1FA00 #x1FA67) with 
>  (chess-symbol . [#x1FA00 #x1FA67])
> 
>  > You don't have Symbola installed?
> 
>  I have the Symbola font installed via the gdouros-symbola-fonts package on my Fedora37 system, but
>  it does not seem to support
>  the chess-symbols block as verified by hb-view.
>  Its description in the fedora wiki also does not mention the chess-symbols block:
> 
>  Symbola covers the following scripts and symbols supported by The Unicode Standard 5.2:
>  Basic Latin, Latin-1 Supplement, Latin Extended-A, IPA Extensions, Spacing Modifier Letters,
>  Greek and Coptic, Cyrillic, Cyrillic Supplementary, General Punctuation, Superscripts and
>  Subscripts, Combining Diacritical Marks for Symbols, Letterlike Symbols, Number Forms,
>  Arrows, Mathematical Operators, Miscellaneous Technical, Control Pictures, Optical Character
>  Recognition, Box Drawing, Block Elements, Geometric Shapes, Miscellaneous Symbols,
>  Dingbats, Miscellaneous Mathematical Symbols-A, Supplemental Arrows-A, Supplemental
>  Arrows-B, Miscellaneous Mathematical Symbols-B, Supplemental Mathematical Operators,
>  Miscellaneous Symbols and Arrows, Supplemental Punctuation, CJK Symbols and Punctuation,
>  Yijing Hexagram Symbols, Vertical Forms, Combining Half Marks, CJK Compatibility Forms,
>  Specials, Tai Xuan Jing Symbols, Counting Rod Numerals, Mathematical Alphanumeric
>  Symbols, Mahjong Tile Symbols, Domino Tile Symbols. 

OK, I installed this on master.





^ permalink raw reply	[flat|nested] 9+ messages in thread

* bug#58098: Improve composition rules for Gumrukhi
  2022-09-28 12:39             ` Eli Zaretskii
@ 2022-09-28 12:57               ` समीर सिंह Sameer Singh
  0 siblings, 0 replies; 9+ messages in thread
From: समीर सिंह Sameer Singh @ 2022-09-28 12:57 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 58098-done

[-- Attachment #1: Type: text/plain, Size: 2375 bytes --]

Thanks!

On Wed, Sep 28, 2022 at 6:09 PM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
> > Date: Tue, 27 Sep 2022 20:54:22 +0530
> > Cc: 58098@debbugs.gnu.org
> >
> >  The form
> >
> >         (chess-symbol #x1FA00 #x1FA67)
> >
> >  requires that _both_ #x1FA00 and #x1FA67 be supported by a font, for
> >  it to be eligible to display chess-symbols.  By contrast, the form
> >
> >         (chess-symbol . [#x1FA00 #x1FA67])
> >
> >  requires that _either_ of the two characters is supported.  So my
> >  question is: do we really want _both_ of the characters supported by a
> >  font, and if not, do we really want Emacs to reject such a font?
> >
> >  I have updated the patch accordingly and replaced (chess-symbol #x1FA00
> #x1FA67) with
> >  (chess-symbol . [#x1FA00 #x1FA67])
> >
> >  > You don't have Symbola installed?
> >
> >  I have the Symbola font installed via the gdouros-symbola-fonts package
> on my Fedora37 system, but
> >  it does not seem to support
> >  the chess-symbols block as verified by hb-view.
> >  Its description in the fedora wiki also does not mention the
> chess-symbols block:
> >
> >  Symbola covers the following scripts and symbols supported by The
> Unicode Standard 5.2:
> >  Basic Latin, Latin-1 Supplement, Latin Extended-A, IPA Extensions,
> Spacing Modifier Letters,
> >  Greek and Coptic, Cyrillic, Cyrillic Supplementary, General
> Punctuation, Superscripts and
> >  Subscripts, Combining Diacritical Marks for Symbols, Letterlike
> Symbols, Number Forms,
> >  Arrows, Mathematical Operators, Miscellaneous Technical, Control
> Pictures, Optical Character
> >  Recognition, Box Drawing, Block Elements, Geometric Shapes,
> Miscellaneous Symbols,
> >  Dingbats, Miscellaneous Mathematical Symbols-A, Supplemental Arrows-A,
> Supplemental
> >  Arrows-B, Miscellaneous Mathematical Symbols-B, Supplemental
> Mathematical Operators,
> >  Miscellaneous Symbols and Arrows, Supplemental Punctuation, CJK Symbols
> and Punctuation,
> >  Yijing Hexagram Symbols, Vertical Forms, Combining Half Marks, CJK
> Compatibility Forms,
> >  Specials, Tai Xuan Jing Symbols, Counting Rod Numerals, Mathematical
> Alphanumeric
> >  Symbols, Mahjong Tile Symbols, Domino Tile Symbols.
>
> OK, I installed this on master.
>

[-- Attachment #2: Type: text/html, Size: 2981 bytes --]

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2022-09-28 12:57 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-26 18:43 bug#58098: Improve composition rules for Gumrukhi समीर सिंह Sameer Singh
2022-09-26 18:47 ` समीर सिंह Sameer Singh
2022-09-26 20:00   ` समीर सिंह Sameer Singh
2022-09-27 13:12     ` Eli Zaretskii
2022-09-27 13:52       ` समीर सिंह Sameer Singh
2022-09-27 14:08         ` Eli Zaretskii
2022-09-27 15:24           ` समीर सिंह Sameer Singh
2022-09-28 12:39             ` Eli Zaretskii
2022-09-28 12:57               ` समीर सिंह Sameer Singh

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).