bug#58424: [PATCH] Ensure emacs-pgtk does not get stuck after iconify-frame

bug#58424: [PATCH] Ensure emacs-pgtk does not get stuck after iconify-frame

[समीर सिंह Sameer Singh]

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

steps to reproduce
1. configure emacs to use pgtk
2. emacs -Q
3. C-z or M-x iconify-frame
4. Restore emacs by clicking on its icon
Emacs does not display characters any more.

I believe this bug is similar to bug#42655 except this time it is for pgtk
and not lucid.

I believe I have fixed this problem and will attach a patch in the next
mail, but the thing is I have no idea how I fixed it so please check for
any unintended consequences.

Thanks

[-- Attachment #2: Type: text/html, Size: 608 bytes --]

bug#58424: [PATCH] Ensure emacs-pgtk does not get stuck after iconify-frame

[समीर सिंह Sameer Singh]

[-- Attachment #1.1: Type: text/plain, Size: 601 bytes --]

On Tue, Oct 11, 2022 at 6:11 AM समीर सिंह Sameer Singh <
lumarzeli30@gmail.com> wrote:

> steps to reproduce
> 1. configure emacs to use pgtk
> 2. emacs -Q
> 3. C-z or M-x iconify-frame
> 4. Restore emacs by clicking on its icon
> Emacs does not display characters any more.
>
> I believe this bug is similar to bug#42655 except this time it is for pgtk
> and not lucid.
>
> I believe I have fixed this problem and will attach a patch in the next
> mail, but the thing is I have no idea how I fixed it so please check for
> any unintended consequences.
>
> Thanks
>

[-- Attachment #1.2: Type: text/html, Size: 998 bytes --]

[-- Attachment #2: 0001-Ensure-emacs-pgtk-does-not-get-stuck-after-iconify-f.patch --]
[-- Type: text/x-patch, Size: 951 bytes --]

From 95c5157430e807c43e731b6e696fe05fb31f2979 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0=20=E0=A4=B8=E0=A4=BF?=
 =?UTF-8?q?=E0=A4=82=E0=A4=B9=20Sameer=20Singh?= <lumarzeli30@gmail.com>
Date: Tue, 11 Oct 2022 05:48:25 +0530
Subject: [PATCH] Ensure emacs-pgtk does not get stuck after iconify-frame
 (bug#58424)

* src/pgtkterm.c (pgtk_iconify_frame):
change visibilty of frame to 1.
---
 src/pgtkterm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/pgtkterm.c b/src/pgtkterm.c
index 491ba33882..c9d74e089f 100644
--- a/src/pgtkterm.c
+++ b/src/pgtkterm.c
@@ -733,7 +733,7 @@ pgtk_iconify_frame (struct frame *f)
 	gtk_widget_show_all (FRAME_GTK_OUTER_WIDGET (f));
 
       gtk_window_iconify (GTK_WINDOW (FRAME_GTK_OUTER_WIDGET (f)));
-      SET_FRAME_VISIBLE (f, 0);
+      SET_FRAME_VISIBLE (f, 1);
       SET_FRAME_ICONIFIED (f, true);
       unblock_input ();
       return;
-- 
2.37.3

bug#58424: [PATCH] Ensure emacs-pgtk does not get stuck after iconify-frame

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

forcemerge 55836 58424

समीर सिंह Sameer Singh <lumarzeli30@gmail.com> writes:

> On Tue, Oct 11, 2022 at 6:11 AM समीर सिंह Sameer Singh <lumarzeli30@gmail.com> wrote:
>
>  steps to reproduce
>  1. configure emacs to use pgtk
>  2. emacs -Q
>  3. C-z or M-x iconify-frame
>  4. Restore emacs by clicking on its icon
>  Emacs does not display characters any more.
>
>  I believe this bug is similar to bug#42655 except this time it is for pgtk and not lucid.
>
>  I believe I have fixed this problem and will attach a patch in the next mail, but the thing is I have no idea how I fixed it so please check for any unintended
>  consequences.

This is definitely not the right fix.

I'm still looking into that problem, and will definitely fix it before
November.

bug#58424: [PATCH] Ensure emacs-pgtk does not get stuck after iconify-frame

[समीर सिंह Sameer Singh]

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

>
> forcemerge 55836 58424


oops, looks like I missed this discussion.

Thanks for working on this, I will wait for a fix.

On Tue, Oct 11, 2022 at 9:11 AM Po Lu <luangruo@yahoo.com> wrote:

> forcemerge 55836 58424
>
> समीर सिंह Sameer Singh <lumarzeli30@gmail.com> writes:
>
> > On Tue, Oct 11, 2022 at 6:11 AM समीर सिंह Sameer Singh <
> lumarzeli30@gmail.com> wrote:
> >
> >  steps to reproduce
> >  1. configure emacs to use pgtk
> >  2. emacs -Q
> >  3. C-z or M-x iconify-frame
> >  4. Restore emacs by clicking on its icon
> >  Emacs does not display characters any more.
> >
> >  I believe this bug is similar to bug#42655 except this time it is for
> pgtk and not lucid.
> >
> >  I believe I have fixed this problem and will attach a patch in the next
> mail, but the thing is I have no idea how I fixed it so please check for
> any unintended
> >  consequences.
>
> This is definitely not the right fix.
>
> I'm still looking into that problem, and will definitely fix it before
> November.
>

[-- Attachment #2: Type: text/html, Size: 1737 bytes --]