unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "समीर सिंह Sameer Singh" <lumarzeli30@gmail.com>
To: 58424@debbugs.gnu.org
Subject: bug#58424: [PATCH] Ensure emacs-pgtk does not get stuck after iconify-frame
Date: Tue, 11 Oct 2022 06:14:13 +0530	[thread overview]
Message-ID: <CAOR1sLwxhgRuaHHjgZa0gJtfpXo9SZX=WSWS4mQaN981aC3o5g@mail.gmail.com> (raw)
In-Reply-To: <CAOR1sLz8x9t2J6Nx2voutYZOxn5oC16AJ6P3p7aaJV-yXohkaQ@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 601 bytes --]

On Tue, Oct 11, 2022 at 6:11 AM समीर सिंह Sameer Singh <
lumarzeli30@gmail.com> wrote:

> steps to reproduce
> 1. configure emacs to use pgtk
> 2. emacs -Q
> 3. C-z or M-x iconify-frame
> 4. Restore emacs by clicking on its icon
> Emacs does not display characters any more.
>
> I believe this bug is similar to bug#42655 except this time it is for pgtk
> and not lucid.
>
> I believe I have fixed this problem and will attach a patch in the next
> mail, but the thing is I have no idea how I fixed it so please check for
> any unintended consequences.
>
> Thanks
>

[-- Attachment #1.2: Type: text/html, Size: 998 bytes --]

[-- Attachment #2: 0001-Ensure-emacs-pgtk-does-not-get-stuck-after-iconify-f.patch --]
[-- Type: text/x-patch, Size: 951 bytes --]

From 95c5157430e807c43e731b6e696fe05fb31f2979 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E0=A4=B8=E0=A4=AE=E0=A5=80=E0=A4=B0=20=E0=A4=B8=E0=A4=BF?=
 =?UTF-8?q?=E0=A4=82=E0=A4=B9=20Sameer=20Singh?= <lumarzeli30@gmail.com>
Date: Tue, 11 Oct 2022 05:48:25 +0530
Subject: [PATCH] Ensure emacs-pgtk does not get stuck after iconify-frame
 (bug#58424)

* src/pgtkterm.c (pgtk_iconify_frame):
change visibilty of frame to 1.
---
 src/pgtkterm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/pgtkterm.c b/src/pgtkterm.c
index 491ba33882..c9d74e089f 100644
--- a/src/pgtkterm.c
+++ b/src/pgtkterm.c
@@ -733,7 +733,7 @@ pgtk_iconify_frame (struct frame *f)
 	gtk_widget_show_all (FRAME_GTK_OUTER_WIDGET (f));
 
       gtk_window_iconify (GTK_WINDOW (FRAME_GTK_OUTER_WIDGET (f)));
-      SET_FRAME_VISIBLE (f, 0);
+      SET_FRAME_VISIBLE (f, 1);
       SET_FRAME_ICONIFIED (f, true);
       unblock_input ();
       return;
-- 
2.37.3


  reply	other threads:[~2022-10-11  0:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-11  0:41 bug#58424: [PATCH] Ensure emacs-pgtk does not get stuck after iconify-frame समीर सिंह Sameer Singh
2022-10-11  0:44 ` समीर सिंह Sameer Singh [this message]
2022-10-11  3:41   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-11  4:04     ` समीर सिंह Sameer Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOR1sLwxhgRuaHHjgZa0gJtfpXo9SZX=WSWS4mQaN981aC3o5g@mail.gmail.com' \
    --to=lumarzeli30@gmail.com \
    --cc=58424@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).