From: Liu Hui <liuhui1610@gmail.com>
To: Jim Porter <jporterbugs@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
66700@debbugs.gnu.org, Sean Whitton <spwhitton@spwhitton.name>
Subject: bug#66700: 30.0.50; Some history is missing with multiple eshell buffers
Date: Thu, 16 Nov 2023 17:47:43 +0800 [thread overview]
Message-ID: <CAOQTW-P0ZaEpCmZ5Q09uQ-vt6rmxnCpky8kPXd9dhKqbaXSpfQ@mail.gmail.com> (raw)
In-Reply-To: <2daab250-42dc-37bd-acc4-8c1366763425@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 849 bytes --]
Jim Porter <jporterbugs@gmail.com> 于2023年11月15日周三 01:15写道:
>
> On 11/14/2023 4:43 AM, Sean Whitton wrote:
> > On Tue 14 Nov 2023 at 02:32pm +02, Eli Zaretskii wrote:
> >>
> >> IMO, this is too soon to change the default behavior in incompatible
> >> ways. We need to wait for a while, perhaps at least one major
> >> release, before we do that.
> >
> > This is fair enough. It would be really useful to have the default
> > behaviour now for those of used to it from other shells, though -- Liu,
> > perhaps you would be interested in adding a defcustom?
>
> Yeah, I think a defcustom would be good here. That would also make it
> easier for us to test out the new code and find any bugs.
Thank you all for your suggestions. A defcustom has been added in the
attached patch without changing previous behavior.
[-- Attachment #2: 0001-Add-option-eshell-history-append.patch --]
[-- Type: text/x-patch, Size: 2381 bytes --]
From e2cd3a9d28b35806d4e6a83e98f0dc25550651e2 Mon Sep 17 00:00:00 2001
From: Liu Hui <liuhui1610@gmail.com>
Date: Thu, 16 Nov 2023 11:45:28 +0800
Subject: [PATCH] Add option `eshell-history-append'
* lisp/eshell/em-hist.el (eshell-history-append): New option.
(eshell--save-history): New function.
(eshell-hist-initialize):
(eshell-save-some-history): Replace eshell-write-history with
eshell--save-history, which respects the new option.
---
lisp/eshell/em-hist.el | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/lisp/eshell/em-hist.el b/lisp/eshell/em-hist.el
index cf03f8399a6..79336204847 100644
--- a/lisp/eshell/em-hist.el
+++ b/lisp/eshell/em-hist.el
@@ -116,6 +116,12 @@ eshell-save-history-on-exit
(const :tag "Ask" ask)
(const :tag "Always save" t)))
+(defcustom eshell-history-append nil
+ "If non-nil, append new entries to the history file when saving history."
+ :type '(choice (const :tag "Overwrite history file" nil)
+ (const :tag "Append new entries to file" t))
+ :version "30.1")
+
(defcustom eshell-input-filter 'eshell-input-filter-default
"Predicate for filtering additions to input history.
Takes one argument, the input. If non-nil, the input may be saved on
@@ -294,17 +300,21 @@ eshell-hist-initialize
(if eshell-history-file-name
(eshell-read-history nil t))
- (add-hook 'eshell-exit-hook #'eshell-write-history nil t))
+ (add-hook 'eshell-exit-hook #'eshell--save-history nil t))
(unless eshell-history-ring
(setq eshell-history-ring (make-ring eshell-history-size)))
- (add-hook 'eshell-exit-hook #'eshell-write-history nil t)
+ (add-hook 'eshell-exit-hook #'eshell--save-history nil t)
(add-hook 'kill-emacs-query-functions #'eshell-save-some-history)
(add-hook 'eshell-input-filter-functions #'eshell-add-to-history nil t))
+(defun eshell--save-history ()
+ "Save the history for current Eshell buffer."
+ (eshell-write-history nil eshell-history-append))
+
(defun eshell-save-some-history ()
"Save the history for any open Eshell buffers."
(dolist (buf (buffer-list))
@@ -318,7 +328,7 @@ eshell-save-some-history
(format-message
"Save input history for Eshell buffer `%s'? "
(buffer-name buf)))))
- (eshell-write-history)))))
+ (eshell--save-history)))))
t)
(defun eshell/history (&rest args)
--
2.25.1
next prev parent reply other threads:[~2023-11-16 9:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 12:14 bug#66700: 30.0.50; Some history is missing with multiple eshell buffers Liu Hui
2023-11-14 4:40 ` Liu Hui
2023-11-14 12:32 ` Eli Zaretskii
2023-11-14 12:43 ` Sean Whitton
2023-11-14 17:15 ` Jim Porter
2023-11-16 9:47 ` Liu Hui [this message]
2023-12-06 15:33 ` Sean Whitton
2023-12-07 10:23 ` Liu Hui
2023-12-07 11:33 ` Sean Whitton
2023-12-08 22:53 ` Jim Porter
2023-11-15 9:59 ` Liu Hui
2023-11-15 12:22 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOQTW-P0ZaEpCmZ5Q09uQ-vt6rmxnCpky8kPXd9dhKqbaXSpfQ@mail.gmail.com \
--to=liuhui1610@gmail.com \
--cc=66700@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jporterbugs@gmail.com \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).