unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Liu Hui <liuhui1610@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: jporterbugs@gmail.com, 66700@debbugs.gnu.org
Subject: bug#66700: 30.0.50; Some history is missing with multiple eshell buffers
Date: Wed, 15 Nov 2023 17:59:23 +0800	[thread overview]
Message-ID: <CAOQTW-MjE17T8hA=gXLddaVagWMuBzqvM6WwSqeGyjSyTp_bxg@mail.gmail.com> (raw)
In-Reply-To: <838r70tt11.fsf@gnu.org>

Hi Eli,

Eli Zaretskii <eliz@gnu.org> 于2023年11月14日周二 20:32写道:

> > Since Eshell can append new history now, I think it makes sense to
> > change the default behavior from overwriting to appending, i.e., using
> > '(eshell-write-history nil t)' in eshell-exit-hook and
> > eshell-save-some-history. WDYT?
>
> IMO, this is too soon to change the default behavior in incompatible
> ways.  We need to wait for a while, perhaps at least one major
> release, before we do that.
>
> Thanks.

It is not an incompatible change at the user level. It is actually a
bug fix for people using multiple eshell sessions. For people using a
single eshell buffer, the history inside eshell, when reading back
from the file, is always same no matter how history is saved, and the
only difference is the content of history file.

As others have suggested, we could add an option to toggle the
behavior with appending new history as the default. It allows more
testing and users can easily revert back to old behavior. Do you think
it is acceptable?





  parent reply	other threads:[~2023-11-15  9:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-23 12:14 bug#66700: 30.0.50; Some history is missing with multiple eshell buffers Liu Hui
2023-11-14  4:40 ` Liu Hui
2023-11-14 12:32   ` Eli Zaretskii
2023-11-14 12:43     ` Sean Whitton
2023-11-14 17:15       ` Jim Porter
2023-11-16  9:47         ` Liu Hui
2023-12-06 15:33           ` Sean Whitton
2023-12-07 10:23             ` Liu Hui
2023-12-07 11:33               ` Sean Whitton
2023-12-08 22:53                 ` Jim Porter
2023-11-15  9:59     ` Liu Hui [this message]
2023-11-15 12:22       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOQTW-MjE17T8hA=gXLddaVagWMuBzqvM6WwSqeGyjSyTp_bxg@mail.gmail.com' \
    --to=liuhui1610@gmail.com \
    --cc=66700@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=jporterbugs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).