From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Liu Hui Newsgroups: gmane.emacs.bugs Subject: bug#66700: 30.0.50; Some history is missing with multiple eshell buffers Date: Thu, 16 Nov 2023 17:47:43 +0800 Message-ID: References: <838r70tt11.fsf@gnu.org> <878r70ec8u.fsf@melete.silentflame.com> <2daab250-42dc-37bd-acc4-8c1366763425@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000f48a1c060a41e9f9" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23971"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 66700@debbugs.gnu.org, Sean Whitton To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 16 10:49:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r3Yzz-00064q-7b for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Nov 2023 10:49:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3Yzh-00011E-JP; Thu, 16 Nov 2023 04:49:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3Yzf-000113-Cg for bug-gnu-emacs@gnu.org; Thu, 16 Nov 2023 04:49:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r3Yzf-00063u-2y for bug-gnu-emacs@gnu.org; Thu, 16 Nov 2023 04:49:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r3Yze-0000Gf-7L for bug-gnu-emacs@gnu.org; Thu, 16 Nov 2023 04:49:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Liu Hui Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Nov 2023 09:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66700 X-GNU-PR-Package: emacs Original-Received: via spool by 66700-submit@debbugs.gnu.org id=B66700.1700128084640 (code B ref 66700); Thu, 16 Nov 2023 09:49:02 +0000 Original-Received: (at 66700) by debbugs.gnu.org; 16 Nov 2023 09:48:04 +0000 Original-Received: from localhost ([127.0.0.1]:54489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3Yyh-0000AC-9W for submit@debbugs.gnu.org; Thu, 16 Nov 2023 04:48:03 -0500 Original-Received: from mail-vs1-xe35.google.com ([2607:f8b0:4864:20::e35]:53747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3Yyd-00008v-Tx for 66700@debbugs.gnu.org; Thu, 16 Nov 2023 04:48:01 -0500 Original-Received: by mail-vs1-xe35.google.com with SMTP id ada2fe7eead31-45d8c405696so229069137.3 for <66700@debbugs.gnu.org>; Thu, 16 Nov 2023 01:48:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700128074; x=1700732874; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=lmWhdWxmYpLnsAYcvcWr7PmMvr3TuVSFyKjn9n0ao8o=; b=IWYgQ4JwJE6dIzM734rYdNtXY5symWvipdCKP+g2eQnO62YlwrSTMeoSHX0xWHZyM/ A7Mxv/VFWiO3kpGyJhkyG/a9XOrowjp5J9SkZLgY82vMGDKngWcd1HNx49K/zeQissCT 7GXOF/aUFCaBRpTuf5vAvGDg0F8ivwXjn9YulecsAjvuHTukErFfw6kctinC/8KlGdCI IALv25+7t5ENYpAqrbeEAE7+qW/MFVTMEbNrjSsH02vGhRfEwNhsTmJwWFKcOtmb/IWb q44z2J+/CPam5ZLhAmby6VPsz+IHtw1g6fC3Mu7UQ1dzMvFhcwxgAQOmZq5YrCAmk6zZ CYig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700128074; x=1700732874; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lmWhdWxmYpLnsAYcvcWr7PmMvr3TuVSFyKjn9n0ao8o=; b=RjSJs9oNBNqL7OxtwsliGbsCRuVef/yl6xcPLluhh9A96V6l7ZZun14rfatiVv4V4J SVHsf84RJlaMrG01oe5U/zFo/d+138zrNGsuJAZtDmScn/TfhE5b7wvBoa5zHopfyJAr XWCoc1CJSX5/qqq45RbpJSfKewrDbkD/XYXHCqXjuuisQkIlJbWs7GefdUL59T+Nu9Tg ns6P8uUrnQlMy8p4f2rrpXnE/dAZOi3eK9UtHcnfEufNKAtdE1ZUNOFStXpUAuA9cBgV FB8hv1j3MVGQFuYVkEGjfirIOWAfx5Vl31ENlUrO608m3+awf2Sl7O1U+ILrn9sesY/g IHrQ== X-Gm-Message-State: AOJu0Ywj6dvnjywFOlJChMYK49/TKr+1wvGc2n3PC2B61EU2U8rtPxGJ AgYNpPHr9ur+sndNhCapPFW94LvfHCqE2/F7jo0= X-Google-Smtp-Source: AGHT+IHQ1YxhQFTiu9TH9nSRZWL5dB60SOhaBstPQa2EHeNgNRtLYX55gXL19UnVEKYMpTd8iuRoPfS5ad96Qc/lKiQ= X-Received: by 2002:a05:6102:1625:b0:45f:654a:f3b with SMTP id cu37-20020a056102162500b0045f654a0f3bmr19413105vsb.19.1700128074512; Thu, 16 Nov 2023 01:47:54 -0800 (PST) In-Reply-To: <2daab250-42dc-37bd-acc4-8c1366763425@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274446 Archived-At: --000000000000f48a1c060a41e9f9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Jim Porter =E4=BA=8E2023=E5=B9=B411=E6=9C=8815=E6= =97=A5=E5=91=A8=E4=B8=89 01:15=E5=86=99=E9=81=93=EF=BC=9A > > On 11/14/2023 4:43 AM, Sean Whitton wrote: > > On Tue 14 Nov 2023 at 02:32pm +02, Eli Zaretskii wrote: > >> > >> IMO, this is too soon to change the default behavior in incompatible > >> ways. We need to wait for a while, perhaps at least one major > >> release, before we do that. > > > > This is fair enough. It would be really useful to have the default > > behaviour now for those of used to it from other shells, though -- Liu, > > perhaps you would be interested in adding a defcustom? > > Yeah, I think a defcustom would be good here. That would also make it > easier for us to test out the new code and find any bugs. Thank you all for your suggestions. A defcustom has been added in the attached patch without changing previous behavior. --000000000000f48a1c060a41e9f9 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Add-option-eshell-history-append.patch" Content-Disposition: attachment; filename="0001-Add-option-eshell-history-append.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lp10b73q0 RnJvbSBlMmNkM2E5ZDI4YjM1ODA2ZDRlNmE4M2U5OGYwZGMyNTU1MDY1MWUyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaXUgSHVpIDxsaXVodWkxNjEwQGdtYWlsLmNvbT4KRGF0ZTog VGh1LCAxNiBOb3YgMjAyMyAxMTo0NToyOCArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIEFkZCBvcHRp b24gYGVzaGVsbC1oaXN0b3J5LWFwcGVuZCcKCiogbGlzcC9lc2hlbGwvZW0taGlzdC5lbCAoZXNo ZWxsLWhpc3RvcnktYXBwZW5kKTogTmV3IG9wdGlvbi4KKGVzaGVsbC0tc2F2ZS1oaXN0b3J5KTog TmV3IGZ1bmN0aW9uLgooZXNoZWxsLWhpc3QtaW5pdGlhbGl6ZSk6Cihlc2hlbGwtc2F2ZS1zb21l LWhpc3RvcnkpOiBSZXBsYWNlIGVzaGVsbC13cml0ZS1oaXN0b3J5IHdpdGgKZXNoZWxsLS1zYXZl LWhpc3RvcnksIHdoaWNoIHJlc3BlY3RzIHRoZSBuZXcgb3B0aW9uLgotLS0KIGxpc3AvZXNoZWxs L2VtLWhpc3QuZWwgfCAxNiArKysrKysrKysrKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTMgaW5z ZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2VzaGVsbC9lbS1o aXN0LmVsIGIvbGlzcC9lc2hlbGwvZW0taGlzdC5lbAppbmRleCBjZjAzZjgzOTlhNi4uNzkzMzYy MDQ4NDcgMTAwNjQ0Ci0tLSBhL2xpc3AvZXNoZWxsL2VtLWhpc3QuZWwKKysrIGIvbGlzcC9lc2hl bGwvZW0taGlzdC5lbApAQCAtMTE2LDYgKzExNiwxMiBAQCBlc2hlbGwtc2F2ZS1oaXN0b3J5LW9u LWV4aXQKIAkJIChjb25zdCA6dGFnICJBc2siIGFzaykKIAkJIChjb25zdCA6dGFnICJBbHdheXMg c2F2ZSIgdCkpKQogCisoZGVmY3VzdG9tIGVzaGVsbC1oaXN0b3J5LWFwcGVuZCBuaWwKKyAgIklm IG5vbi1uaWwsIGFwcGVuZCBuZXcgZW50cmllcyB0byB0aGUgaGlzdG9yeSBmaWxlIHdoZW4gc2F2 aW5nIGhpc3RvcnkuIgorICA6dHlwZSAnKGNob2ljZSAoY29uc3QgOnRhZyAiT3ZlcndyaXRlIGhp c3RvcnkgZmlsZSIgbmlsKQorCQkgKGNvbnN0IDp0YWcgIkFwcGVuZCBuZXcgZW50cmllcyB0byBm aWxlIiB0KSkKKyAgOnZlcnNpb24gIjMwLjEiKQorCiAoZGVmY3VzdG9tIGVzaGVsbC1pbnB1dC1m aWx0ZXIgJ2VzaGVsbC1pbnB1dC1maWx0ZXItZGVmYXVsdAogICAiUHJlZGljYXRlIGZvciBmaWx0 ZXJpbmcgYWRkaXRpb25zIHRvIGlucHV0IGhpc3RvcnkuCiBUYWtlcyBvbmUgYXJndW1lbnQsIHRo ZSBpbnB1dC4gIElmIG5vbi1uaWwsIHRoZSBpbnB1dCBtYXkgYmUgc2F2ZWQgb24KQEAgLTI5NCwx NyArMzAwLDIxIEBAIGVzaGVsbC1oaXN0LWluaXRpYWxpemUKICAgICAoaWYgZXNoZWxsLWhpc3Rv cnktZmlsZS1uYW1lCiAJKGVzaGVsbC1yZWFkLWhpc3RvcnkgbmlsIHQpKQogCi0gICAgKGFkZC1o b29rICdlc2hlbGwtZXhpdC1ob29rICMnZXNoZWxsLXdyaXRlLWhpc3RvcnkgbmlsIHQpKQorICAg IChhZGQtaG9vayAnZXNoZWxsLWV4aXQtaG9vayAjJ2VzaGVsbC0tc2F2ZS1oaXN0b3J5IG5pbCB0 KSkKIAogICAodW5sZXNzIGVzaGVsbC1oaXN0b3J5LXJpbmcKICAgICAoc2V0cSBlc2hlbGwtaGlz dG9yeS1yaW5nIChtYWtlLXJpbmcgZXNoZWxsLWhpc3Rvcnktc2l6ZSkpKQogCi0gIChhZGQtaG9v ayAnZXNoZWxsLWV4aXQtaG9vayAjJ2VzaGVsbC13cml0ZS1oaXN0b3J5IG5pbCB0KQorICAoYWRk LWhvb2sgJ2VzaGVsbC1leGl0LWhvb2sgIydlc2hlbGwtLXNhdmUtaGlzdG9yeSBuaWwgdCkKIAog ICAoYWRkLWhvb2sgJ2tpbGwtZW1hY3MtcXVlcnktZnVuY3Rpb25zICMnZXNoZWxsLXNhdmUtc29t ZS1oaXN0b3J5KQogCiAgIChhZGQtaG9vayAnZXNoZWxsLWlucHV0LWZpbHRlci1mdW5jdGlvbnMg Iydlc2hlbGwtYWRkLXRvLWhpc3RvcnkgbmlsIHQpKQogCisoZGVmdW4gZXNoZWxsLS1zYXZlLWhp c3RvcnkgKCkKKyAgIlNhdmUgdGhlIGhpc3RvcnkgZm9yIGN1cnJlbnQgRXNoZWxsIGJ1ZmZlci4i CisgIChlc2hlbGwtd3JpdGUtaGlzdG9yeSBuaWwgZXNoZWxsLWhpc3RvcnktYXBwZW5kKSkKKwog KGRlZnVuIGVzaGVsbC1zYXZlLXNvbWUtaGlzdG9yeSAoKQogICAiU2F2ZSB0aGUgaGlzdG9yeSBm b3IgYW55IG9wZW4gRXNoZWxsIGJ1ZmZlcnMuIgogICAoZG9saXN0IChidWYgKGJ1ZmZlci1saXN0 KSkKQEAgLTMxOCw3ICszMjgsNyBAQCBlc2hlbGwtc2F2ZS1zb21lLWhpc3RvcnkKIAkJCShmb3Jt YXQtbWVzc2FnZQogCQkJICJTYXZlIGlucHV0IGhpc3RvcnkgZm9yIEVzaGVsbCBidWZmZXIgYCVz Jz8gIgogCQkJIChidWZmZXItbmFtZSBidWYpKSkpKQotCSAgICAgIChlc2hlbGwtd3JpdGUtaGlz dG9yeSkpKSkpCisJICAgICAgKGVzaGVsbC0tc2F2ZS1oaXN0b3J5KSkpKSkKICAgdCkKIAogKGRl ZnVuIGVzaGVsbC9oaXN0b3J5ICgmcmVzdCBhcmdzKQotLSAKMi4yNS4xCgo= --000000000000f48a1c060a41e9f9--