From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Liu Hui Newsgroups: gmane.emacs.bugs Subject: bug#66700: 30.0.50; Some history is missing with multiple eshell buffers Date: Wed, 15 Nov 2023 17:59:23 +0800 Message-ID: References: <838r70tt11.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15869"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, 66700@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 15 17:04:46 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r3INf-0003hu-K1 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Nov 2023 17:04:43 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3IN5-0000H1-Ox; Wed, 15 Nov 2023 11:04:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3IN3-0000GP-PX for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 11:04:06 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r3IN1-00071m-8y for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 11:04:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r3IN0-0001Kh-04 for bug-gnu-emacs@gnu.org; Wed, 15 Nov 2023 11:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Liu Hui Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Nov 2023 16:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66700 X-GNU-PR-Package: emacs Original-Received: via spool by 66700-submit@debbugs.gnu.org id=B66700.17000642335108 (code B ref 66700); Wed, 15 Nov 2023 16:04:01 +0000 Original-Received: (at 66700) by debbugs.gnu.org; 15 Nov 2023 16:03:53 +0000 Original-Received: from localhost ([127.0.0.1]:52978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IMr-0001KK-8C for submit@debbugs.gnu.org; Wed, 15 Nov 2023 11:03:53 -0500 Original-Received: from mail-vs1-xe31.google.com ([2607:f8b0:4864:20::e31]:52711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3IMm-0001K4-Ao for 66700@debbugs.gnu.org; Wed, 15 Nov 2023 11:03:52 -0500 Original-Received: by mail-vs1-xe31.google.com with SMTP id ada2fe7eead31-45fb946612bso2137806137.1 for <66700@debbugs.gnu.org>; Wed, 15 Nov 2023 08:03:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700064223; x=1700669023; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jBHmdolKqm6sL9YnjLj63t1WuFzOO9gXHWmBDqk4k78=; b=ii4QesvrAVDjIVJTnnIDdC+il6q6EVbsvUrnv4/C4j1DFS4ctuYUrOHAP0JpuupV0C tNPe28dO3uwVwvZVu7P5tjv6iUvgsAADFTGkeT71GyqmsM8MzruvqpgMIZqLBYUDMq2B KrqxQkpe9YTR8+Uwja4FRok1BKTTbyis/RjeRZn8GbOnVB4cUEBIPIzw2M+ywwmTcM0b fEAnI+/RBVJX/AQDwzDHT/d6aD6GN+tZbR1hHzKwmVETH6hbuoVDZ0hw6LhnG2wzc+Em 992+6n9bU9UdwXOTJ9tiZ7HyuqACJMVptRxqFZnx4ZwB2cUT9pYhDHO9HD4eWEOLMPJQ Kdjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700064223; x=1700669023; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jBHmdolKqm6sL9YnjLj63t1WuFzOO9gXHWmBDqk4k78=; b=vTO8M0vUan7uoWpwPIAcsuaq2Q9ghObdVWE3h3USSriTB74lsJPgpv/bWUjIf+MWRN /AwOqI7ZQG41ECyXYwPZu4467DI+svaCrPVIFCsvaOK5VmCbbgJUiVN+ApA5BMO/rXis K8TIlUJ4qA1b7gJdtvw2N68j9FhFOxLn2PiESch7M2AmLZT+qr/FlH1IQdZuYAD60zI5 53YOJjzQRAMq7OzMk2C20oS6Kagu1XeC1uz+KxjB/piQz35epZVOtj/G2miy0D/MB28X tvHLNVLjWIRpYQERrbCk9ePRcFpT59bq66Bggo+1VN2uD/1bVA2ULXXGXqFAEStCLhza dfJQ== X-Gm-Message-State: AOJu0Yy0UYuGAmnXUa2lsmRg3akwLNNbXW7jwUlgQEWgxxuShWReKJZC b4PhfCMAbEJMl8NSgn6Qn0uQrMisSYTuvhMPua+QwayZtjDLFw== X-Google-Smtp-Source: AGHT+IFa7DaAXjAZ7V1BvC7ZqZkImb9Gg+8X4cQvDxGUCNOnzCAh2t4YpzAyhl9pLb/Goe8q0XpuISNW5mDeeb5vOX4= X-Received: by 2002:a05:6102:2455:b0:45f:398:aba5 with SMTP id g21-20020a056102245500b0045f0398aba5mr11277882vss.32.1700042375301; Wed, 15 Nov 2023 01:59:35 -0800 (PST) In-Reply-To: <838r70tt11.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274357 Archived-At: Hi Eli, Eli Zaretskii =E4=BA=8E2023=E5=B9=B411=E6=9C=8814=E6=97=A5= =E5=91=A8=E4=BA=8C 20:32=E5=86=99=E9=81=93=EF=BC=9A > > Since Eshell can append new history now, I think it makes sense to > > change the default behavior from overwriting to appending, i.e., using > > '(eshell-write-history nil t)' in eshell-exit-hook and > > eshell-save-some-history. WDYT? > > IMO, this is too soon to change the default behavior in incompatible > ways. We need to wait for a while, perhaps at least one major > release, before we do that. > > Thanks. It is not an incompatible change at the user level. It is actually a bug fix for people using multiple eshell sessions. For people using a single eshell buffer, the history inside eshell, when reading back from the file, is always same no matter how history is saved, and the only difference is the content of history file. As others have suggested, we could add an option to toggle the behavior with appending new history as the default. It allows more testing and users can easily revert back to old behavior. Do you think it is acceptable?