From: Spencer Baugh <sbaugh@janestreet.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: sbaugh@catern.com, 62958@debbugs.gnu.org
Subject: bug#62958: [PATCH] Set PAGER=cat in comint.el
Date: Tue, 9 May 2023 13:01:07 -0400 [thread overview]
Message-ID: <CAO=BR8N-=uQtNEaEmEQ_XynNYpSQmZVD1mWYC5_AYFEV6XYQ-w@mail.gmail.com> (raw)
In-Reply-To: <83sfc5a1ag.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1458 bytes --]
On Tue, May 9, 2023, 12:58 Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Spencer Baugh <sbaugh@janestreet.com>
> > Cc: sbaugh@catern.com, 62958@debbugs.gnu.org
> > Date: Tue, 09 May 2023 12:53:24 -0400
> >
> > > OK, but what's the purpose of the addition you were proposing? It
> > > basically says that sometimes paging should not be disabled, but since
> > > this is a defcustom, and the default is not to disable paging, that
> > > already speaks volumes about the same issue, right?
> >
> > My addition says:
> > - sometimes paging should not be disabled (for programs like "git log")
> > - but if you're going to disable it anyway, commands like `vc-print-log'
> > become more useful (because it's an alternative to "git log")
> >
> > The purpose of the addition is to communicate the second part. (And
> > since I think the primary way most people will encounter this is through
> > "git log", I think it's worth mentioning `vc-print-log' specifically)
>
> I'm asking why this is not already obvious from the fact that this is
> a defcustom, by default off. All your addition says is "don't disable
> paging in all cases, sometimes it can be useful". But we already said
> that, in effect, by making the paging enabled by default. So there's
> no reason to have that text, as it isn't instrumental, and doesn't add
> anything.
>
How does "this is a defcustom, by default off" communicate "you should use
vc-print-log if you turn this on"?
>
[-- Attachment #2: Type: text/html, Size: 2411 bytes --]
next prev parent reply other threads:[~2023-05-09 17:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 21:57 bug#62958: [PATCH] Set PAGER=cat in comint.el Spencer Baugh
2023-04-20 6:43 ` Eli Zaretskii
2023-04-20 15:47 ` Spencer Baugh
2023-04-20 15:56 ` Eli Zaretskii
2023-04-20 16:01 ` Spencer Baugh
2023-05-05 6:35 ` Eli Zaretskii
2023-05-08 19:38 ` Spencer Baugh
2023-05-09 5:08 ` Eli Zaretskii
2023-05-09 14:55 ` sbaugh
2023-05-09 15:46 ` Eli Zaretskii
2023-05-09 16:30 ` Spencer Baugh
2023-05-09 16:43 ` Eli Zaretskii
2023-05-09 16:53 ` Spencer Baugh
2023-05-09 16:59 ` Eli Zaretskii
2023-05-09 17:01 ` Spencer Baugh [this message]
2023-05-09 17:05 ` Eli Zaretskii
2023-05-09 17:13 ` Spencer Baugh
2023-05-09 18:58 ` Eli Zaretskii
2023-05-16 19:49 ` Spencer Baugh
2023-05-17 11:32 ` Eli Zaretskii
2023-05-17 14:55 ` Spencer Baugh
2023-05-19 6:09 ` Eli Zaretskii
2023-05-26 11:31 ` Eli Zaretskii
2023-05-09 17:03 ` Eli Zaretskii
2023-05-10 16:39 ` Juri Linkov
2023-05-10 16:59 ` Eli Zaretskii
2023-05-10 18:13 ` Gregory Heytings
2023-05-12 17:49 ` Juri Linkov
2023-05-12 22:21 ` Gregory Heytings
2023-04-26 7:54 ` Philip Kaludercic
2023-04-26 9:15 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAO=BR8N-=uQtNEaEmEQ_XynNYpSQmZVD1mWYC5_AYFEV6XYQ-w@mail.gmail.com' \
--to=sbaugh@janestreet.com \
--cc=62958@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=sbaugh@catern.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).