From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Paul Rankin <hello@paulwrankin.com>
Cc: 24073@debbugs.gnu.org
Subject: bug#24073: 24.5; outline-on-heading-p sees any invisible text property as outline invisible
Date: Thu, 28 Jul 2016 22:07:03 -0400 [thread overview]
Message-ID: <CAM-tV-_mLup3eTv-W84ow9vdnxKkioN+Yawf_YEei5mPzXRHMg@mail.gmail.com> (raw)
In-Reply-To: <1469679952.1866840.678960241.470C9887@webmail.messagingengine.com>
On Thu, Jul 28, 2016 at 12:25 AM, Paul Rankin <hello@paulwrankin.com> wrote:
> I've tried to create an advice patch for the benefit of users affected by the bug to make outline-invisible-p return t for either 'outline or t, nil otherwise...
>
> (advice-add 'outline-invisible-p :filter-return
> (lambda (return) (eq return (or 'outline t)))
> '((name . "fountain-mode-patch")))
>
> However, it appears that other compiled functions in outline that call outline-invisible-p do not respect this advice, e.g.
>
> 1. navigate to heading affected by above bug
> 2. M-: (outline-on-heading-p)
> => nil
> 3. navigate to (defun outline-on-heading-p ...) in outline.el
> 4. C-M-x
> 5. repeat 1. and 2.
> => t
>
> Do compiled functions not respect advice added to functions that they call?
I think it's because outline-invisible-p is a defsubst, so when
compiled, callers don't actually reference the symbol
`outline-invisible-p' at all.
next prev parent reply other threads:[~2016-07-29 2:07 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 8:12 bug#24073: 24.5; outline-on-heading-p sees any invisible text property as outline inviisble Paul Rankin
2016-07-26 9:29 ` Paul Rankin
2016-07-26 15:14 ` Eli Zaretskii
2016-07-27 5:43 ` Paul Rankin
2016-07-28 4:25 ` bug#24073: 24.5; outline-on-heading-p sees any invisible text property as outline invisible Paul Rankin
2016-07-29 2:07 ` Noam Postavsky [this message]
2016-08-01 9:37 ` Paul Rankin
2016-08-01 14:16 ` npostavs
2016-08-02 3:27 ` Paul Rankin
2016-08-02 3:47 ` Noam Postavsky
2016-08-02 4:22 ` Paul Rankin
2016-08-02 14:27 ` Noam Postavsky
2016-08-02 7:20 ` Paul Rankin
2016-08-02 14:31 ` Noam Postavsky
2016-08-03 3:18 ` Paul Rankin
2016-08-31 1:12 ` bug#24073: 25.1-rc2 Paul Rankin
2016-08-31 2:41 ` Eli Zaretskii
2016-08-31 2:56 ` Paul Rankin
2016-08-31 8:59 ` John Wiegley
2016-08-31 9:12 ` Nicolas Petton
2016-08-31 14:25 ` Eli Zaretskii
2016-09-03 4:38 ` Paul Rankin
2016-09-18 14:39 ` Eli Zaretskii
2016-09-18 14:45 ` Nicolas Goaziou
2016-09-18 14:53 ` Eli Zaretskii
2016-09-19 9:40 ` Paul Rankin
2016-09-19 16:48 ` Eli Zaretskii
2016-09-20 5:37 ` Bastien Guerry
2016-09-30 8:06 ` Bastien Guerry
2017-03-30 8:18 ` Paul Rankin
2017-03-31 0:16 ` npostavs
2017-04-01 6:40 ` Paul Rankin
2017-04-01 7:20 ` Andreas Schwab
2017-04-01 8:06 ` Paul Rankin
2017-04-01 8:20 ` Andreas Schwab
2017-04-01 9:11 ` Paul Rankin
2017-04-01 9:37 ` Andreas Schwab
2017-04-01 10:18 ` Paul Rankin
2017-04-01 11:44 ` Eli Zaretskii
2017-04-01 12:05 ` Paul Rankin
2017-04-01 11:48 ` Andreas Schwab
2016-09-18 15:34 ` Bastien Guerry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAM-tV-_mLup3eTv-W84ow9vdnxKkioN+Yawf_YEei5mPzXRHMg@mail.gmail.com \
--to=npostavs@users.sourceforge.net \
--cc=24073@debbugs.gnu.org \
--cc=hello@paulwrankin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).