From: Eli Zaretskii <eliz@gnu.org>
To: Paul Rankin <hello@paulwrankin.com>, Bastien Guerry <bzg@gnu.org>
Cc: 24073@debbugs.gnu.org, emacs-orgmode@gnu.org
Subject: bug#24073: 25.1-rc2
Date: Sun, 18 Sep 2016 17:39:52 +0300 [thread overview]
Message-ID: <83lgypi85j.fsf@gnu.org> (raw)
In-Reply-To: <1472877535.1718060.714506377.6182C525@webmail.messagingengine.com> (message from Paul Rankin on Sat, 03 Sep 2016 14:38:55 +1000)
Ping!
Bastien, could you or someone else please look into this and provide
your comments? TIA.
> From: Paul Rankin <hello@paulwrankin.com>
> Cc: 24073@debbugs.gnu.org, emacs-orgmode@gnu.org
> Date: Sat, 03 Sep 2016 14:38:55 +1000
>
> Eli Zaretskii <eliz@gnu.org> on Wed, 31 Aug 2016 17:25 +0300:
> > > From: Paul Rankin <hello@paulwrankin.com>
> > > Date: Wed, 31 Aug 2016 12:56:13 +1000
> > > Cc: 24073@debbugs.gnu.org
> > >
> > > >> The fix seems trivial to me so I'm wondering if there is anything holding it
> > > >> up from being included in 25?
> > > >
> > > > Yes, the fact that Emacs 25 is for all practical purposes already
> > > > released.
> > >
> > > Okay. 25.2?
> >
> > I don't see why not, provided that Org developers give us their
> > blessing. Please bring this to their attention on the Org list, or
> > ask them to speak up here. I don't want us to make any changes that
> > could adversely affect Org without consulting them first.
>
> Dear Org Mode maintainers,
>
> Looping you in on a proposed bug fix for `outline-invisible-p'.
>
> Briefly, the problem is the function returns non-nil for any invisible
> text property when it should only do so for the outline property. As a
> defsubst, it is difficult to patch for other affected programs.
>
> Diff pasted:
>
> --- /usr/local/Cellar/emacs/25.1-rc2/share/emacs/25.1/lisp/outline.el.gz
> +++ #<buffer outline.el.gz>
> @@ -388,9 +388,9 @@
> nil 'move))
>
> (defsubst outline-invisible-p (&optional pos)
> - "Non-nil if the character after POS is invisible.
> + "Non-nil if the character after POS has outline invisible property.
> If POS is nil, use `point' instead."
> - (get-char-property (or pos (point)) 'invisible))
> + (eq (get-char-property (or pos (point)) 'invisible) 'outline))
>
> (defun outline-back-to-heading (&optional invisible-ok)
> "Move to previous heading line, or beg of this line if it's a heading.
>
> Diff finished. Sat Sep 3 14:35:22 2016
>
next prev parent reply other threads:[~2016-09-18 14:39 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 8:12 bug#24073: 24.5; outline-on-heading-p sees any invisible text property as outline inviisble Paul Rankin
2016-07-26 9:29 ` Paul Rankin
2016-07-26 15:14 ` Eli Zaretskii
2016-07-27 5:43 ` Paul Rankin
2016-07-28 4:25 ` bug#24073: 24.5; outline-on-heading-p sees any invisible text property as outline invisible Paul Rankin
2016-07-29 2:07 ` Noam Postavsky
2016-08-01 9:37 ` Paul Rankin
2016-08-01 14:16 ` npostavs
2016-08-02 3:27 ` Paul Rankin
2016-08-02 3:47 ` Noam Postavsky
2016-08-02 4:22 ` Paul Rankin
2016-08-02 14:27 ` Noam Postavsky
2016-08-02 7:20 ` Paul Rankin
2016-08-02 14:31 ` Noam Postavsky
2016-08-03 3:18 ` Paul Rankin
2016-08-31 1:12 ` bug#24073: 25.1-rc2 Paul Rankin
2016-08-31 2:41 ` Eli Zaretskii
2016-08-31 2:56 ` Paul Rankin
2016-08-31 8:59 ` John Wiegley
2016-08-31 9:12 ` Nicolas Petton
2016-08-31 14:25 ` Eli Zaretskii
2016-09-03 4:38 ` Paul Rankin
2016-09-18 14:39 ` Eli Zaretskii [this message]
2016-09-18 14:45 ` Nicolas Goaziou
2016-09-18 14:53 ` Eli Zaretskii
2016-09-19 9:40 ` Paul Rankin
2016-09-19 16:48 ` Eli Zaretskii
2016-09-20 5:37 ` Bastien Guerry
2016-09-30 8:06 ` Bastien Guerry
2017-03-30 8:18 ` Paul Rankin
2017-03-31 0:16 ` npostavs
2017-04-01 6:40 ` Paul Rankin
2017-04-01 7:20 ` Andreas Schwab
2017-04-01 8:06 ` Paul Rankin
2017-04-01 8:20 ` Andreas Schwab
2017-04-01 9:11 ` Paul Rankin
2017-04-01 9:37 ` Andreas Schwab
2017-04-01 10:18 ` Paul Rankin
2017-04-01 11:44 ` Eli Zaretskii
2017-04-01 12:05 ` Paul Rankin
2017-04-01 11:48 ` Andreas Schwab
2016-09-18 15:34 ` Bastien Guerry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lgypi85j.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=24073@debbugs.gnu.org \
--cc=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=hello@paulwrankin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).