From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#24073: 24.5; outline-on-heading-p sees any invisible text property as outline invisible Date: Thu, 28 Jul 2016 22:07:03 -0400 Message-ID: References: <1469520753.418402.676896009.00AAC0DE@webmail.messagingengine.com> <1469679952.1866840.678960241.470C9887@webmail.messagingengine.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1469758109 6043 80.91.229.3 (29 Jul 2016 02:08:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Jul 2016 02:08:29 +0000 (UTC) Cc: 24073@debbugs.gnu.org To: Paul Rankin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 29 04:08:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bSxDm-0002FS-VG for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Jul 2016 04:08:19 +0200 Original-Received: from localhost ([::1]:56645 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSxDg-0006s5-JH for geb-bug-gnu-emacs@m.gmane.org; Thu, 28 Jul 2016 22:08:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSxDa-0006s0-P8 for bug-gnu-emacs@gnu.org; Thu, 28 Jul 2016 22:08:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSxDW-0007QG-IL for bug-gnu-emacs@gnu.org; Thu, 28 Jul 2016 22:08:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52557) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSxDW-0007QC-Dj for bug-gnu-emacs@gnu.org; Thu, 28 Jul 2016 22:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bSxDW-0006Z2-6s for bug-gnu-emacs@gnu.org; Thu, 28 Jul 2016 22:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Jul 2016 02:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24073 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24073-submit@debbugs.gnu.org id=B24073.146975803425180 (code B ref 24073); Fri, 29 Jul 2016 02:08:02 +0000 Original-Received: (at 24073) by debbugs.gnu.org; 29 Jul 2016 02:07:14 +0000 Original-Received: from localhost ([127.0.0.1]:49854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bSxCk-0006Y4-I9 for submit@debbugs.gnu.org; Thu, 28 Jul 2016 22:07:14 -0400 Original-Received: from mail-oi0-f45.google.com ([209.85.218.45]:36341) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bSxCf-0006Xm-Qj for 24073@debbugs.gnu.org; Thu, 28 Jul 2016 22:07:12 -0400 Original-Received: by mail-oi0-f45.google.com with SMTP id w18so88436178oiw.3 for <24073@debbugs.gnu.org>; Thu, 28 Jul 2016 19:07:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=QuffGTQHn7RMGAher7hvltNNq1gfBw+Z4JWWpM6n99E=; b=KgwsntBXcIek7LumhsWKC2RUQOThESPldIWyKkgprcJ87+Ppfzv43d1OS4nQv591Gt gBI3c+ZV7GQKgC+vyzEdHGHh7rn9qn11It+8pybzVchfgVcdaUVBU5TKs23XqlEbtrpg fVIn065YIARtEAMQvpap4vqDQt3WIt6AYv0LGaO2V/XmM7J/botbqTKUKV/HEGk44dv3 twOj6u5po1v9YMQVqVDDI4YhYCjq/OxW8G+DEfetXcBrDu3jIfyT64RWrliIqPNVbm/H DOjO1BbbxuOAXDynaXYtYVmRf90/4dakGxAWq6Y1gdu6LRH6F4efJ60RMdusiMU8+7/o p9/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=QuffGTQHn7RMGAher7hvltNNq1gfBw+Z4JWWpM6n99E=; b=ItAhzTlbep3SA9EdLps4oGclgdhshcitySoZe/90jaralCY/XDFwpVj0Eszd/gDfYL YzhWLpyEeYoBryccHeQWH7iEM2c7QzbvlAZCEA6bX6thoV10v1Ragt7m180R6j5WzxME LByOGCJYlJtUmOcE9X9xLPes7fQWTue1VtMl5wl53wBaFfcUDZgfRByaLEkH6rlW5A0O SZpzElaMmox8cA/qYsKXO/bn6NCw9wBmKmhPIGorUzZS7NA30IqFd6aMSqzbki+Mgk00 XyI9GEcSnDI2CuvAn6w2JPyfL6KXvJhpiKJIRhGfuSppnT7cScidZjef/2xGX3hDbY5J /aAg== X-Gm-Message-State: AEkoouukuQHNtg/u6x5Q9DlOHDPEqe+HOyn88JfNd+f6OGOSHdlOw/OKbTn9SS9j5ijykzIrHMU9L7OFzwncgw== X-Received: by 10.202.102.75 with SMTP id a72mr23045046oic.40.1469758024261; Thu, 28 Jul 2016 19:07:04 -0700 (PDT) Original-Received: by 10.157.7.161 with HTTP; Thu, 28 Jul 2016 19:07:03 -0700 (PDT) In-Reply-To: <1469679952.1866840.678960241.470C9887@webmail.messagingengine.com> X-Google-Sender-Auth: 5RcxPy4-6EVOlWPVXVFNdTMF_aQ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121664 Archived-At: On Thu, Jul 28, 2016 at 12:25 AM, Paul Rankin wrote: > I've tried to create an advice patch for the benefit of users affected by the bug to make outline-invisible-p return t for either 'outline or t, nil otherwise... > > (advice-add 'outline-invisible-p :filter-return > (lambda (return) (eq return (or 'outline t))) > '((name . "fountain-mode-patch"))) > > However, it appears that other compiled functions in outline that call outline-invisible-p do not respect this advice, e.g. > > 1. navigate to heading affected by above bug > 2. M-: (outline-on-heading-p) > => nil > 3. navigate to (defun outline-on-heading-p ...) in outline.el > 4. C-M-x > 5. repeat 1. and 2. > => t > > Do compiled functions not respect advice added to functions that they call? I think it's because outline-invisible-p is a defsubst, so when compiled, callers don't actually reference the symbol `outline-invisible-p' at all.