unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 21681@debbugs.gnu.org
Subject: bug#21681: [PATCH] Fix formatting of lexical-binding at eof warning
Date: Wed, 14 Oct 2015 22:30:43 -0400	[thread overview]
Message-ID: <CAM-tV-8jcYU3wT3ZCLk9jCaLNNRkoO75EpT_GdiXKi-kTdz9qw@mail.gmail.com> (raw)
In-Reply-To: <83si5dw7w9.fsf@gnu.org>

On 10/14/15, Eli Zaretskii <eliz@gnu.org> wrote:
> Having now looked at the code, I actually don't understand why the
> documentation says the symbol should be a custom group.

I would speculate it's a way to encourage some convergence of warning
types, so that users are able to suppress several at once.

I did an rgrep on the Emacs source tree for display-warning|lwarn,
only 2 calls pass a list for TYPE, both in lisp/progmodes/python.el:

./lisp/progmodes/python.el:2247:
          (lwarn
           '(python python-shell-prompt-regexp)
./lisp/progmodes/python.el:3443:
       (t (lwarn
           '(python python-shell-completion-native-turn-on-maybe)


There are several mistaken uses of :warning or :error, and the rest
use a general symbol that says little beyond which package a warning
might be coming from; around half are custom groups, but none very
specific.

Symbols used:

(get 'alloc          'custom-group) ;=> ((gc-cons-threshold custom-variable)
(get 'todo           'custom-group) ;=> nil
(get 'org            'custom-group) ;=> ((org-babel custom-group)...
(get 'initialization 'custom-group) ;=> ((user-emacs-directory-warning
custom-variable)...
(get 'url            'custom-group) ;=> ((url-file custom-group)...
(get 'gnus-server    'custom-group) ;=> nil
(get 'mule           'custom-group) ;=> ((keyboard-coding-system
custom-variable)...
(get 'server         'custom-group) ;=> ((server-use-tcp custom-variable)...
(get 'file-error     'custom-group) ;=> nil
(get 'rmail          'custom-group) ;=> nil
(get 'check-declare  'custom-group) ;=> nil
(get 'smie           'custom-group) ;=> ((smie-blink-matching-inners
custom-variable)...
(get 'bytecomp       'custom-group) ;=> ((emacs-lisp-file-regexp
custom-variable)...
(get 'mail           'custom-group) ;=> ((mail-host-address custom-variable)...
(get 'python         'custom-group) ;=> nil
(get 'erc            'custom-group) ;=> nil
(get 'soap-client    'custom-group) ;=> nil
(get 'custom         'custom-group) ;=> nil
(get 'bzrmerge       'custom-group) ;=> nil





  reply	other threads:[~2015-10-15  2:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-13 22:51 bug#21681: [PATCH] Fix formatting of lexical-binding at eof warning Noam Postavsky
2015-10-14 16:28 ` Eli Zaretskii
2015-10-14 16:56   ` Noam Postavsky
2015-10-14 17:42     ` Eli Zaretskii
2015-10-14 17:47       ` Noam Postavsky
2015-10-14 17:53         ` Eli Zaretskii
2015-10-14 19:46           ` Eli Zaretskii
2015-10-15  2:30             ` Noam Postavsky [this message]
2015-10-31 22:36         ` Noam Postavsky
2016-01-24 18:43           ` Noam Postavsky
2016-01-24 18:51             ` Eli Zaretskii
2016-01-24 19:34               ` Noam Postavsky
2016-01-25 17:07                 ` Eli Zaretskii
2016-01-31 15:56                   ` Noam Postavsky
2016-02-03 17:49                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM-tV-8jcYU3wT3ZCLk9jCaLNNRkoO75EpT_GdiXKi-kTdz9qw@mail.gmail.com \
    --to=npostavs@users.sourceforge.net \
    --cc=21681@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).