unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: 21681@debbugs.gnu.org
Subject: bug#21681: [PATCH] Fix formatting of lexical-binding at eof warning
Date: Wed, 14 Oct 2015 20:42:25 +0300	[thread overview]
Message-ID: <831tcxxs72.fsf@gnu.org> (raw)
In-Reply-To: <CAM-tV--GqXmv=gUtXDG8HJrs0_FwL+SYh_-1oqccKPR8rUu2Bw@mail.gmail.com>

> Date: Wed, 14 Oct 2015 12:56:28 -0400
> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Cc: 21681@debbugs.gnu.org
> 
> On Wed, Oct 14, 2015 at 12:28 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> > Why 'files', and not something more concrete, like
> > 'file-local-variables'?
> 
> The docstring for display-warning says the TYPE arg should be a custom group.
> 
> display-warning doesn't actually enforce this, and it looks like the
> choice of symbol(s) is only relevant to warning-suppress-log-types.
> Perhaps the TYPE should be '(files local-variables) so the user can
> suppress it along with all files warnings or just suppress it on it's
> own, but display-warning only prints the 1st symbol of the list so the
> warning text itself wouldn't change.

I find "files" no more explanatory that "warning".  If we lack
infrastructure to display meaningful messages that unequivocally point
to the nature of the problem, let's add the missing infrastructure.

Thanks.





  reply	other threads:[~2015-10-14 17:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-13 22:51 bug#21681: [PATCH] Fix formatting of lexical-binding at eof warning Noam Postavsky
2015-10-14 16:28 ` Eli Zaretskii
2015-10-14 16:56   ` Noam Postavsky
2015-10-14 17:42     ` Eli Zaretskii [this message]
2015-10-14 17:47       ` Noam Postavsky
2015-10-14 17:53         ` Eli Zaretskii
2015-10-14 19:46           ` Eli Zaretskii
2015-10-15  2:30             ` Noam Postavsky
2015-10-31 22:36         ` Noam Postavsky
2016-01-24 18:43           ` Noam Postavsky
2016-01-24 18:51             ` Eli Zaretskii
2016-01-24 19:34               ` Noam Postavsky
2016-01-25 17:07                 ` Eli Zaretskii
2016-01-31 15:56                   ` Noam Postavsky
2016-02-03 17:49                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=831tcxxs72.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=21681@debbugs.gnu.org \
    --cc=npostavs@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).