From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#21681: [PATCH] Fix formatting of lexical-binding at eof warning Date: Wed, 14 Oct 2015 22:30:43 -0400 Message-ID: References: <83fv1dxvmq.fsf@gnu.org> <831tcxxs72.fsf@gnu.org> <83y4f5wd3w.fsf@gnu.org> <83si5dw7w9.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1444876352 23978 80.91.229.3 (15 Oct 2015 02:32:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 15 Oct 2015 02:32:32 +0000 (UTC) Cc: 21681@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 15 04:32:23 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZmYL8-0008VP-96 for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Oct 2015 04:32:22 +0200 Original-Received: from localhost ([::1]:45453 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmYL7-0002Un-GT for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Oct 2015 22:32:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44844) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmYJt-0002OL-S8 for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2015 22:31:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmYJq-0008EV-MQ for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2015 22:31:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60619) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmYJq-0008EM-Im for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2015 22:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZmYJq-0007qd-AC for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2015 22:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Oct 2015 02:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21681 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 21681-submit@debbugs.gnu.org id=B21681.144487624830143 (code B ref 21681); Thu, 15 Oct 2015 02:31:02 +0000 Original-Received: (at 21681) by debbugs.gnu.org; 15 Oct 2015 02:30:48 +0000 Original-Received: from localhost ([127.0.0.1]:51327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZmYJb-0007q6-7t for submit@debbugs.gnu.org; Wed, 14 Oct 2015 22:30:48 -0400 Original-Received: from mail-wi0-f182.google.com ([209.85.212.182]:33280) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZmYJX-0007px-PX for 21681@debbugs.gnu.org; Wed, 14 Oct 2015 22:30:44 -0400 Original-Received: by wijp11 with SMTP id p11so8446529wij.0 for <21681@debbugs.gnu.org>; Wed, 14 Oct 2015 19:30:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=DZZFVeRNEm6ADuyZgSlU0P2sZwurAlLezBtWAr68LHU=; b=wl2DOR6v615sxQz23f6mpPJZeoHloIoAcq/hcWmv7mTsc0v03YbEj8sd06EMkvVIIu L4TfAUiD4RSMSPIztvDXJkBb3m/PTBxO9rCf902WhRsh99KOTE7tP7zudX7jjUz1+Bid TPlSL5/7w5/8QrEp+4+LZE9C+tPHI30siPzt/eje6gVMFf3yCXl8ZsGIygmrgFQwKOl0 qGbwx+uUgW9A/mRHnaS9+PPuJ38nh4U0lJ/fuD6p8ht6wB1DkomrHd3qALUCVAPWB+W1 ygfihYJKR7XW4Yx9pWZ6Y1ND3vVxAq1X3NDcsSsy71exjhUIgtIfY+SfTCPKrBimqGVp XXhQ== X-Received: by 10.194.185.16 with SMTP id ey16mr8587267wjc.32.1444876243071; Wed, 14 Oct 2015 19:30:43 -0700 (PDT) Original-Received: by 10.28.210.68 with HTTP; Wed, 14 Oct 2015 19:30:43 -0700 (PDT) In-Reply-To: <83si5dw7w9.fsf@gnu.org> X-Google-Sender-Auth: qq8OelYUzc4J5ITRB2zoZBasPKI X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:107630 Archived-At: On 10/14/15, Eli Zaretskii wrote: > Having now looked at the code, I actually don't understand why the > documentation says the symbol should be a custom group. I would speculate it's a way to encourage some convergence of warning types, so that users are able to suppress several at once. I did an rgrep on the Emacs source tree for display-warning|lwarn, only 2 calls pass a list for TYPE, both in lisp/progmodes/python.el: ./lisp/progmodes/python.el:2247: (lwarn '(python python-shell-prompt-regexp) ./lisp/progmodes/python.el:3443: (t (lwarn '(python python-shell-completion-native-turn-on-maybe) There are several mistaken uses of :warning or :error, and the rest use a general symbol that says little beyond which package a warning might be coming from; around half are custom groups, but none very specific. Symbols used: (get 'alloc 'custom-group) ;=> ((gc-cons-threshold custom-variable) (get 'todo 'custom-group) ;=> nil (get 'org 'custom-group) ;=> ((org-babel custom-group)... (get 'initialization 'custom-group) ;=> ((user-emacs-directory-warning custom-variable)... (get 'url 'custom-group) ;=> ((url-file custom-group)... (get 'gnus-server 'custom-group) ;=> nil (get 'mule 'custom-group) ;=> ((keyboard-coding-system custom-variable)... (get 'server 'custom-group) ;=> ((server-use-tcp custom-variable)... (get 'file-error 'custom-group) ;=> nil (get 'rmail 'custom-group) ;=> nil (get 'check-declare 'custom-group) ;=> nil (get 'smie 'custom-group) ;=> ((smie-blink-matching-inners custom-variable)... (get 'bytecomp 'custom-group) ;=> ((emacs-lisp-file-regexp custom-variable)... (get 'mail 'custom-group) ;=> ((mail-host-address custom-variable)... (get 'python 'custom-group) ;=> nil (get 'erc 'custom-group) ;=> nil (get 'soap-client 'custom-group) ;=> nil (get 'custom 'custom-group) ;=> nil (get 'bzrmerge 'custom-group) ;=> nil