unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 21284@debbugs.gnu.org, Keith David Bershatsky <esq@lawlist.com>,
	Marcin Borkowski <mbork@mbork.pl>
Subject: bug#21284: 25.0.50; `completion-file-name-table' should/not use `nreverse'?
Date: Mon, 6 Jun 2016 19:12:01 -0400	[thread overview]
Message-ID: <CAM-tV--2R8rXcEKg87SRn5ayMe3g85V1Znh4ERBXw1gdSKa6Rg@mail.gmail.com> (raw)
In-Reply-To: <83mvmytm2v.fsf@gnu.org>

tag 21284 - unreproducible
severity 21284 minor
quit

On Mon, Jun 6, 2016 at 10:43 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> I suspect that there's a hidden factor here: the order in which the
> 'readdir' libc function returns the directory entries.  On GNU/Linux,
> the order is arbitrary (AFAIK, it's the order of the entries in the
> directory file).  On MS-Windows, the order is alphabetic, so reversing
> will produce the reverse alphabetic order.  I don't know what happens
> on OS X.

Oh yeah, I see reversed order on Windows.

On Mon, Jun 6, 2016 at 12:19 PM, Keith David Bershatsky <esq@lawlist.com> wrote:
> I am on OS X and the default sort order is alphabetic, which gets reversed by `completion-file-name-table` because it uses `nreverse'.

Actually, the result from `file-name-all-completions` is already
reversed. `completion-file-name-table` then reverses it twice: once in
the loop (dolist (tem all) (... (push tem comp))), and the `nreverse`
call to undo it.





  reply	other threads:[~2016-06-06 23:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-17 17:25 bug#21284: 25.0.50; `completion-file-name-table' should/not use `nreverse'? Keith David Bershatsky
2016-05-04  7:40 ` Marcin Borkowski
2016-05-04 18:14 ` Keith David Bershatsky
2022-02-13  8:52   ` bug#21284: eshell does not sort completion candidates Lars Ingebrigtsen
2022-03-14 10:33     ` Lars Ingebrigtsen
2016-06-06  2:50 ` bug#21284: 25.0.50; `completion-file-name-table' should/not use `nreverse'? Noam Postavsky
2016-06-06 14:43   ` Eli Zaretskii
2016-06-06 23:12     ` Noam Postavsky [this message]
2016-06-06 16:19 ` Keith David Bershatsky
2016-06-06 18:50   ` Eli Zaretskii
2016-06-08  2:43     ` Noam Postavsky
2016-06-06 20:00 ` Keith David Bershatsky
2016-06-07  2:36   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAM-tV--2R8rXcEKg87SRn5ayMe3g85V1Znh4ERBXw1gdSKa6Rg@mail.gmail.com \
    --to=npostavs@users.sourceforge.net \
    --cc=21284@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=esq@lawlist.com \
    --cc=mbork@mbork.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).