unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Marcin Borkowski <mbork@mbork.pl>
To: Keith David Bershatsky <esq@lawlist.com>
Cc: 21284@debbugs.gnu.org
Subject: bug#21284: 25.0.50; `completion-file-name-table' should/not use `nreverse'?
Date: Wed, 04 May 2016 09:40:00 +0200	[thread overview]
Message-ID: <87wpnaxodr.fsf@mbork.pl> (raw)
In-Reply-To: <m2egj1rfnq.wl%esq@lawlist.com> (Keith David Bershatsky's message of "Mon, 17 Aug 2015 10:25:13 -0700")

On 2015-08-17, at 10:25, Keith David Bershatsky <esq@lawlist.com> wrote:

> The function `completion-file-name-table' uses `(setq all (nreverse comp))' instead of `(setq all comp)'.
>
> This has the effect of reversing what was accomplished when `pcomplete-compare-entry-function' is set to `'string-lessp'.
>
> In a nutshell, the completions are in reverse alphabetical order as a result of `(setq all (nreverse comp))'.
>
> This was tested in an eshell buffer by typing at a prompt:  rm [space tab]; and, with `lawlist-eshell-cmpl-compare-entry-function` set to `'string-lessp'.

Hi,

I tried to reproduce it on GNU Emacs 25.1.50.9 (commit fafdfcb) and
failed.  However, I'm not sure whether I understood your report
correctly.  My Emacs doesn't seem to have
`lawlist-eshell-cmpl-compare-entry-function', only
`eshell-cmpl-compare-entry-function'.  Did you mean that variable?
I tried to set it to `'string-lessp', but nothing seemed to change after
"rm [space] [tab]" in Eshell.

> Thanks,
>
> Keith

Best,

-- 
Marcin





  reply	other threads:[~2016-05-04  7:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-17 17:25 bug#21284: 25.0.50; `completion-file-name-table' should/not use `nreverse'? Keith David Bershatsky
2016-05-04  7:40 ` Marcin Borkowski [this message]
2016-05-04 18:14 ` Keith David Bershatsky
2022-02-13  8:52   ` bug#21284: eshell does not sort completion candidates Lars Ingebrigtsen
2022-03-14 10:33     ` Lars Ingebrigtsen
2016-06-06  2:50 ` bug#21284: 25.0.50; `completion-file-name-table' should/not use `nreverse'? Noam Postavsky
2016-06-06 14:43   ` Eli Zaretskii
2016-06-06 23:12     ` Noam Postavsky
2016-06-06 16:19 ` Keith David Bershatsky
2016-06-06 18:50   ` Eli Zaretskii
2016-06-08  2:43     ` Noam Postavsky
2016-06-06 20:00 ` Keith David Bershatsky
2016-06-07  2:36   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpnaxodr.fsf@mbork.pl \
    --to=mbork@mbork.pl \
    --cc=21284@debbugs.gnu.org \
    --cc=esq@lawlist.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).