From: Eli Zaretskii <eliz@gnu.org>
To: Keith David Bershatsky <esq@lawlist.com>
Cc: 21284@debbugs.gnu.org, mbork@mbork.pl, npostavs@users.sourceforge.net
Subject: bug#21284: 25.0.50; `completion-file-name-table' should/not use `nreverse'?
Date: Tue, 07 Jun 2016 05:36:30 +0300 [thread overview]
Message-ID: <83shwpsp1t.fsf@gnu.org> (raw)
In-Reply-To: <m2lh2igk9j.wl%esq@lawlist.com> (message from Keith David Bershatsky on Mon, 06 Jun 2016 13:00:40 -0700)
> Date: Mon, 06 Jun 2016 13:00:40 -0700
> From: Keith David Bershatsky <esq@lawlist.com>
> Cc: 21284@debbugs.gnu.org,Marcin Borkowski <mbork@mbork.pl>,Noam Postavsky <npostavs@users.sourceforge.net>
>
> If there is/are valid reason(s) to reverse the order, then perhaps consider mentioning one or more of those reasons in a comment within `completion-file-name-table' along with a mention of bug 21284.
>
> If there is no valid reason whatsoever to reverse the order, then perhaps consider removing `nreverse` from `completion-file-name-table`.
>
> If the issue is "de minimus", then the bug report can be closed without further ado.
I believe the reason is the usual one: we create the list by pushing
each new element onto it, so the result comes in reverse order of the
files. The call to nreverse then restores the original order. IOW,
this is an implementation detail.
prev parent reply other threads:[~2016-06-07 2:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 17:25 bug#21284: 25.0.50; `completion-file-name-table' should/not use `nreverse'? Keith David Bershatsky
2016-05-04 7:40 ` Marcin Borkowski
2016-05-04 18:14 ` Keith David Bershatsky
2022-02-13 8:52 ` bug#21284: eshell does not sort completion candidates Lars Ingebrigtsen
2022-03-14 10:33 ` Lars Ingebrigtsen
2016-06-06 2:50 ` bug#21284: 25.0.50; `completion-file-name-table' should/not use `nreverse'? Noam Postavsky
2016-06-06 14:43 ` Eli Zaretskii
2016-06-06 23:12 ` Noam Postavsky
2016-06-06 16:19 ` Keith David Bershatsky
2016-06-06 18:50 ` Eli Zaretskii
2016-06-08 2:43 ` Noam Postavsky
2016-06-06 20:00 ` Keith David Bershatsky
2016-06-07 2:36 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83shwpsp1t.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=21284@debbugs.gnu.org \
--cc=esq@lawlist.com \
--cc=mbork@mbork.pl \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).