* bug#13293: 24.2.91; eshell completion cycles fail in pre-test
@ 2012-12-28 16:19 Charles Rendleman
2012-12-30 18:57 ` Glenn Morris
0 siblings, 1 reply; 4+ messages in thread
From: Charles Rendleman @ 2012-12-28 16:19 UTC (permalink / raw)
To: 13293
[-- Attachment #1: Type: text/plain, Size: 384 bytes --]
A prescription for exhibiting the bug
$ mkdir -p t/test-1 t/test-2 t/test-3
$ emacs -Q -nw
M-x eshell
type cd t/<TAB>
expands to 'cd t/test-3'
pressing repeated <TAB>s does not cycle t/test-1, t/test-2, t/test-3
Expected behavior (consistent with emacs 24.2): that the first <TAB> expand
to one of t/test-3, and repeated <TAB>s cycle amongst 't/test-1',
't/test-2', and 't/test-3'.
[-- Attachment #2: Type: text/html, Size: 583 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#13293: 24.2.91; eshell completion cycles fail in pre-test
2012-12-28 16:19 bug#13293: 24.2.91; eshell completion cycles fail in pre-test Charles Rendleman
@ 2012-12-30 18:57 ` Glenn Morris
2012-12-30 19:04 ` Glenn Morris
0 siblings, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2012-12-30 18:57 UTC (permalink / raw)
To: Charles Rendleman; +Cc: 13293
Charles Rendleman wrote:
> A prescription for exhibiting the bug
>
> $ mkdir -p t/test-1 t/test-2 t/test-3
> $ emacs -Q -nw
> M-x eshell
> type cd t/<TAB>
> expands to 'cd t/test-3'
> pressing repeated <TAB>s does not cycle t/test-1, t/test-2, t/test-3
Looks like we need to add eshell-pcomplete to the list in the function
pcomplete:
(memq last-command '(pcomplete
pcomplete-expand-and-complete
pcomplete-reverse))
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#13293: 24.2.91; eshell completion cycles fail in pre-test
2012-12-30 18:57 ` Glenn Morris
@ 2012-12-30 19:04 ` Glenn Morris
2012-12-31 21:28 ` Glenn Morris
0 siblings, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2012-12-30 19:04 UTC (permalink / raw)
To: Charles Rendleman; +Cc: 13293
Glenn Morris wrote:
> Looks like we need to add eshell-pcomplete to the list in the function
> pcomplete:
>
> (memq last-command '(pcomplete
> pcomplete-expand-and-complete
> pcomplete-reverse))
Or maybe this:
*** lisp/eshell/em-cmpl.el 2012-11-19 19:22:07 +0000
--- lisp/eshell/em-cmpl.el 2012-12-30 19:02:48 +0000
***************
*** 454,461 ****
(defun eshell-pcomplete ()
"Eshell wrapper for `pcomplete'."
(interactive)
(condition-case nil
! (pcomplete)
(text-read-only (completion-at-point)))) ; Workaround for bug#12838.
(provide 'em-cmpl)
--- 454,462 ----
(defun eshell-pcomplete ()
"Eshell wrapper for `pcomplete'."
(interactive)
+ (setq this-command 'pcomplete)
(condition-case nil
! (call-interactively 'pcomplete)
(text-read-only (completion-at-point)))) ; Workaround for bug#12838.
(provide 'em-cmpl)
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#13293: 24.2.91; eshell completion cycles fail in pre-test
2012-12-30 19:04 ` Glenn Morris
@ 2012-12-31 21:28 ` Glenn Morris
0 siblings, 0 replies; 4+ messages in thread
From: Glenn Morris @ 2012-12-31 21:28 UTC (permalink / raw)
To: 13293-done
Version: 24.2.92
Fixed in emacs-24 branch.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-12-31 21:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-28 16:19 bug#13293: 24.2.91; eshell completion cycles fail in pre-test Charles Rendleman
2012-12-30 18:57 ` Glenn Morris
2012-12-30 19:04 ` Glenn Morris
2012-12-31 21:28 ` Glenn Morris
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).