unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: Charles Rendleman <carendle@gmail.com>
Cc: 13293@debbugs.gnu.org
Subject: bug#13293: 24.2.91; eshell completion cycles fail in pre-test
Date: Sun, 30 Dec 2012 14:04:14 -0500	[thread overview]
Message-ID: <iyvcbjjr9t.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <dasj6nqsfv.fsf@fencepost.gnu.org> (Glenn Morris's message of "Sun, 30 Dec 2012 13:57:08 -0500")

Glenn Morris wrote:

> Looks like we need to add eshell-pcomplete to the list in the function
> pcomplete:
>
> (memq last-command '(pcomplete
>                      pcomplete-expand-and-complete
>                      pcomplete-reverse))

Or maybe this:

*** lisp/eshell/em-cmpl.el	2012-11-19 19:22:07 +0000
--- lisp/eshell/em-cmpl.el	2012-12-30 19:02:48 +0000
***************
*** 454,461 ****
  (defun eshell-pcomplete ()
    "Eshell wrapper for `pcomplete'."
    (interactive)
    (condition-case nil
!       (pcomplete)
      (text-read-only (completion-at-point)))) ; Workaround for bug#12838.
  
  (provide 'em-cmpl)
--- 454,462 ----
  (defun eshell-pcomplete ()
    "Eshell wrapper for `pcomplete'."
    (interactive)
+   (setq this-command 'pcomplete)
    (condition-case nil
!       (call-interactively 'pcomplete)
      (text-read-only (completion-at-point)))) ; Workaround for bug#12838.
  
  (provide 'em-cmpl)






  reply	other threads:[~2012-12-30 19:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-28 16:19 bug#13293: 24.2.91; eshell completion cycles fail in pre-test Charles Rendleman
2012-12-30 18:57 ` Glenn Morris
2012-12-30 19:04   ` Glenn Morris [this message]
2012-12-31 21:28     ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=iyvcbjjr9t.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=13293@debbugs.gnu.org \
    --cc=carendle@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).