From: "João Távora" <joaotavora@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 62795@debbugs.gnu.org, xiliuya <xiliuya@aliyun.com>
Subject: bug#62795: 29.0.90; eglot: gdscript default port is 6005
Date: Sat, 15 Apr 2023 09:17:14 +0100 [thread overview]
Message-ID: <CALDnm53X8-KC8YXgV=qoeEwo+aZD5VZTH+1KKTeLqe2zv+ejAQ@mail.gmail.com> (raw)
In-Reply-To: <83cz45efgq.fsf@gnu.org>
On Sat, Apr 15, 2023 at 9:07 AM Eli Zaretskii <eliz@gnu.org> wrote:
>
> > Date: Wed, 12 Apr 2023 18:33:01 +0800
> > From: xiliuya via "Bug reports for GNU Emacs,
> > the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> >
> > The default port for godot lsp is defined in gdscript_language_server.h file:
> > :
> > > bool use_thread = false;
> > > String host = "127.0.0.1";
> > > int port = 6005;
> > > static void thread_main(void *p_userdata);
> > patch:
> >
> > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> > index 10b6c0cc2ca..f61040af636 100644
> > --- a/lisp/progmodes/eglot.el
> > +++ b/lisp/progmodes/eglot.el
> > @@ -230,7 +230,7 @@ eglot-server-programs
> > (erlang-mode . ("erlang_ls" "--transport" "stdio"))
> > ((yaml-ts-mode yaml-mode) . ("yaml-language-server" "--stdio"))
> > (nix-mode . ,(eglot-alternatives '("nil" "rnix-lsp")))
> > - (gdscript-mode . ("localhost" 6008))
> > + (gdscript-mode . ("localhost" 6005))
> > ((fortran-mode f90-mode) . ("fortls"))
> > (futhark-mode . ("futhark" "lsp"))
> > (lua-mode . ,(eglot-alternatives
>
> João, should I install this? Any idea why eglot.el uses an incorrect
> or outdated value?
I don't know. It would be very hard to know. Should Eglot not
work with those presumably older versions of whichever server is
running in localhost?
This is a very poor entry anyway in the db anyway. I didn't even notice
that it's just assuming whatever is on localhost on that port is the
gdscript server. IMO we shouldn't touch it, but I suggest to xiliuya
to show the output of "whatever-executable-launches-the-server --help".
If that executable allows specifying a port, which is probably does
then the :autoport solution can be used like in the ruby entry.
And then we can commit that solution.
Else, I even think this should be just removed entirely
from eglot-server-programs. My intuition tells me it was added by
someone who just wanted eglot-ensure to work for them, but it's
very very brittle. And that person could have easily added that
entry to the config in their configuration.
So in summary, no I don't think Eglot should be tracking this.
João
next prev parent reply other threads:[~2023-04-15 8:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 10:33 bug#62795: 29.0.90; eglot: gdscript default port is 6005 xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-15 8:07 ` Eli Zaretskii
2023-04-15 8:17 ` João Távora [this message]
2023-04-15 12:19 ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-15 13:13 ` João Távora
2023-04-15 13:28 ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-15 14:04 ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16 3:48 ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16 5:49 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16 6:16 ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16 7:36 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16 8:57 ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16 11:08 ` João Távora
2023-04-16 12:29 ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-17 7:33 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-17 8:43 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-17 13:22 ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16 11:16 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm53X8-KC8YXgV=qoeEwo+aZD5VZTH+1KKTeLqe2zv+ejAQ@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=62795@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=xiliuya@aliyun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).