From: "João Távora" <joaotavora@gmail.com>
To: Ruijie Yu <ruijie@netyu.xyz>
Cc: Eli Zaretskii <eliz@gnu.org>,
62795@debbugs.gnu.org, xiliuya <xiliuya@aliyun.com>
Subject: bug#62795: 29.0.90; eglot: gdscript default port is 6005
Date: Sun, 16 Apr 2023 12:16:50 +0100 [thread overview]
Message-ID: <87v8hwyt3x.fsf@gmail.com> (raw)
In-Reply-To: <sdvleis2x7c.fsf@netyu.xyz> (Ruijie Yu's message of "Sun, 16 Apr 2023 13:49:27 +0800")
Ruijie Yu <ruijie@netyu.xyz> writes:
> I am looking at the last bullet point of `eglot-server-programs', at
> which João seems to be hinting: creating a function that guesses (in our
> case, look into config files to search for) the correct port number for
> this lsp server.
Exactly. In the meantime I have already supplied the solution to this
hint, along with some other comments.
> One thing remains for eglot to decide (IMO), is what happens to the
> eglot entry. Do we do one of the two methods below, or is there a
> better way?
>
> ```emacs-lisp
> ;; Method 1: This requires `gdscript-mode-find-lsp' be already defined
> ;; or autoloaded.
> (push (cons 'gdscript-mode #'gdscript-mode-find-lsp))
>
> ;; Method 2.
> (push (cons 'gdscript-mode
> (lambda (i)
> (and (require 'gdscript-mode nil t)
> (fboundp 'gdscript-mode-find-lsp)
> (gdscript-mode-find-lsp i)))))
> ```
That's the idea, though it's missing the second argument to 'push'.
> The rest, including the discussion of how exactly to implement this
> function, should then be handled in the repo of "gdscript-mode", since
> it is not part of GNU Elpa nor NonGNU Elpa.
Right.
prev parent reply other threads:[~2023-04-16 11:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 10:33 bug#62795: 29.0.90; eglot: gdscript default port is 6005 xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-15 8:07 ` Eli Zaretskii
2023-04-15 8:17 ` João Távora
2023-04-15 12:19 ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-15 13:13 ` João Távora
2023-04-15 13:28 ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-15 14:04 ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16 3:48 ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16 5:49 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16 6:16 ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16 7:36 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16 8:57 ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16 11:08 ` João Távora
2023-04-16 12:29 ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-17 7:33 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-17 8:43 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-17 13:22 ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16 11:16 ` João Távora [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8hwyt3x.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=62795@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=ruijie@netyu.xyz \
--cc=xiliuya@aliyun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).