unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: xiliuya via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: Ruijie Yu <ruijie@netyu.xyz>, Eli Zaretskii <eliz@gnu.org>,
	62795@debbugs.gnu.org
Subject: bug#62795: 29.0.90; eglot: gdscript default port is 6005
Date: Sun, 16 Apr 2023 20:29:18 +0800	[thread overview]
Message-ID: <87h6tg3sne.fsf@aliyun.com> (raw)
In-Reply-To: <87zg78yth9.fsf@gmail.com>


João Távora <joaotavora@gmail.com> writes:

> If it's not clear, let us know.

Yes, that's clear. It was my misunderstanding.

> Another detail: I think the use of `awk` can probably be be optimized
> away Elisp code for processing text.  Same for the shell use of $HOME
> which is also has an Elisp abstraction (see docstring of
> `expand-file-name`).  In theory, you don't need shell-command-to-string
> at all.

I have modified it according to your suggestion, is that OK?
I tested it locally and it works.

```emacs-lisp
  (defun gdscript-eglot-contact (&optional _interactive)
    "Produce a suitable value for LSP contact in `eglot-server-programs'."
    (list "localhost"
          (string-to-number
           (with-temp-buffer
             (insert-file-contents
              (expand-file-name "~/.config/godot/editor_settings-4.tres"))
             (goto-char (point-min))
             (goto-char (+ 39 (string-match
                               "network/language_server/remote_port"
                               (buffer-string))))
             (buffer-substring
              (point)
              (line-end-position))))))
```
> If the function is made simple enough and portable across operating
> systems where the Godot engine runs, then a lambda version of it can be
> added to eglot.el IMO.  But it's really better to add it to
> gdscript-mode.el, wherever it is maintained.
>
> João

I submitted this question to the gdscript-mode codebase, but haven't
heard back yet.
[issues/121](https://github.com/godotengine/emacs-gdscript-mode/issues/121)

-- 
xiliuya :)





  reply	other threads:[~2023-04-16 12:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-12 10:33 bug#62795: 29.0.90; eglot: gdscript default port is 6005 xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-15  8:07 ` Eli Zaretskii
2023-04-15  8:17   ` João Távora
2023-04-15 12:19     ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-15 13:13       ` João Távora
2023-04-15 13:28         ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-15 14:04           ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16  3:48         ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16  5:49           ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16  6:16             ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16  7:36               ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16  8:57                 ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16 11:08             ` João Távora
2023-04-16 12:29               ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-04-17  7:33                 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-17  8:43                   ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-17 13:22                     ` xiliuya via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-04-16 11:16             ` João Távora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6tg3sne.fsf@aliyun.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=62795@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=joaotavora@gmail.com \
    --cc=ruijie@netyu.xyz \
    --cc=xiliuya@aliyun.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).