unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Axel Forsman <axel@axelf.se>
Cc: Eli Zaretskii <eliz@gnu.org>,
	65760@debbugs.gnu.org, ivan-p-sokolov@ya.ru,
	glebsmirnov0708@gmail.com
Subject: bug#65760: 29.1; eglot performance issue
Date: Tue, 5 Sep 2023 18:11:19 +0100	[thread overview]
Message-ID: <CALDnm52rQRh4U+aCcyM1fLhbGxEP9ytQn8ETupOcPcdYDWao3g@mail.gmail.com> (raw)
In-Reply-To: <87cyywsghg.fsf@axelf.se>

On Tue, Sep 5, 2023 at 5:59 PM Axel Forsman <axel@axelf.se> wrote:
>
> I disagree with the initial decision to log all JSONRPC events
> by default to begin with, but irregardless,

I'll change the default if you volunteer to share half
the work of answering and debugging bug reports that contain
nothing but screenshots and minimal information with me for
the next year.  Deal?

> should it not be possible to fix the performance issues by
> having jsonrpc--log-event push raw events onto a ring,
> and introducing a second function that
> formats the raw events as strings
> and inserts them into a new buffer that gets displayed.
> That way the expensive pretty printing would be deferred
> to until the events are actually viewed.

Fantastic idea if you can make it work.  You might be able
to use window-configuration-change-hook or something like that.
Anyway, await your patches eagerly, but there can't be any
interface changes M-x eglot-events-buffer and switch to buffer
must work as before.

João





  reply	other threads:[~2023-09-05 17:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-05  9:01 bug#65760: 29.1; eglot performance issue Глеб Смирнов
2023-09-05 15:55 ` Ivan Sokolov
2023-09-05 16:22   ` Eli Zaretskii
2023-09-05 16:25     ` Eli Zaretskii
2023-09-05 16:45       ` João Távora
2023-09-05 16:59       ` Axel Forsman
2023-09-05 17:11         ` João Távora [this message]
2023-09-05 17:20     ` Ivan Sokolov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALDnm52rQRh4U+aCcyM1fLhbGxEP9ytQn8ETupOcPcdYDWao3g@mail.gmail.com \
    --to=joaotavora@gmail.com \
    --cc=65760@debbugs.gnu.org \
    --cc=axel@axelf.se \
    --cc=eliz@gnu.org \
    --cc=glebsmirnov0708@gmail.com \
    --cc=ivan-p-sokolov@ya.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).