unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "João Távora" <joaotavora@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: glebsmirnov0708@gmail.com, ivan-p-sokolov@ya.ru, 65760@debbugs.gnu.org
Subject: bug#65760: 29.1; eglot performance issue
Date: Tue, 5 Sep 2023 17:45:32 +0100	[thread overview]
Message-ID: <CALDnm5158Uy4e4pUbZgxpjqaSMo8tEmBA7mbp4cOa1Bfmyh=UA@mail.gmail.com> (raw)
In-Reply-To: <835y4o4mfb.fsf@gnu.org>

On Tue, Sep 5, 2023 at 5:25 PM Eli Zaretskii <eliz@gnu.org> wrote:
>
> Adding João.

The troubleshooting section in the manual

   https://joaotavora.github.io/eglot/#Troubleshooting-Eglot

has a heading specifically dedicated to these types of
performance problems:

"A common and easy-to-fix cause of performance problems is the length
of the Eglot events buffer because it represent additional work that Eglot
must do. After verifying Eglot is operating correctly but slowly, try
to customize the variable eglot-events-buffer-size (see Eglot
Variables) to 0. This will disable any debug logging and may speed
things up."

So, keeping a rich log and human-readable log is very useful for
debugging but can kill performance if servers send tons of JSON.

Maybe I could review the default value of eglot-events-buffer-size
or find a more fine-grained solution like some new foo-print-level
or foo-print-length variables, likely for jsonrpc.el.  Suggestions
welcome.  Patches doing this are even more welcome.

João





  reply	other threads:[~2023-09-05 16:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-05  9:01 bug#65760: 29.1; eglot performance issue Глеб Смирнов
2023-09-05 15:55 ` Ivan Sokolov
2023-09-05 16:22   ` Eli Zaretskii
2023-09-05 16:25     ` Eli Zaretskii
2023-09-05 16:45       ` João Távora [this message]
2023-09-05 16:59       ` Axel Forsman
2023-09-05 17:11         ` João Távora
2023-09-05 17:20     ` Ivan Sokolov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALDnm5158Uy4e4pUbZgxpjqaSMo8tEmBA7mbp4cOa1Bfmyh=UA@mail.gmail.com' \
    --to=joaotavora@gmail.com \
    --cc=65760@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=glebsmirnov0708@gmail.com \
    --cc=ivan-p-sokolov@ya.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).