From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#65760: 29.1; eglot performance issue Date: Tue, 5 Sep 2023 18:11:19 +0100 Message-ID: References: <87il8o62dw.fsf@ya.ru> <837cp44mko.fsf@gnu.org> <835y4o4mfb.fsf@gnu.org> <87cyywsghg.fsf@axelf.se> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36252"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 65760@debbugs.gnu.org, ivan-p-sokolov@ya.ru, glebsmirnov0708@gmail.com To: Axel Forsman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 05 19:12:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdZbJ-0009Er-0j for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Sep 2023 19:12:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdZau-0005Cp-EV; Tue, 05 Sep 2023 13:12:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdZas-0005CI-AH for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 13:12:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdZas-0007vb-29 for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 13:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qdZas-0003yq-JK for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 13:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Sep 2023 17:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65760 X-GNU-PR-Package: emacs Original-Received: via spool by 65760-submit@debbugs.gnu.org id=B65760.169393390015260 (code B ref 65760); Tue, 05 Sep 2023 17:12:02 +0000 Original-Received: (at 65760) by debbugs.gnu.org; 5 Sep 2023 17:11:40 +0000 Original-Received: from localhost ([127.0.0.1]:58811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdZaW-0003y4-Eo for submit@debbugs.gnu.org; Tue, 05 Sep 2023 13:11:40 -0400 Original-Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]:53751) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdZaU-0003xr-25 for 65760@debbugs.gnu.org; Tue, 05 Sep 2023 13:11:38 -0400 Original-Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2bcb50e194dso43508721fa.3 for <65760@debbugs.gnu.org>; Tue, 05 Sep 2023 10:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693933891; x=1694538691; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3N9Uu7P0pFtXuyEhyI4j87S5UpaXfMjaO4/TQn/22L0=; b=mFBZBdVcKDWhJIXP+eV8pe1y1JjtFoJKJiI6EbwHMcWy8QPvGzEe224d8VhCyPAAfQ njls46MKiCj2c1jfbT00nNi8t3plsnn5XdKj5a3l0nY39ehX+TiLLd1sVx5FEE5hECth BqnDCQObdkmNKUUgYUQiE/uEiMtsOA/8QI2RvtQ5g6GYG+T+UwE4iFCvWgV9WYzHdS0C /JDboy17juBqmcedBWnGr3xHezwokwJIk6avLTivHs0P5pkH4yxxhBnj3tQEZTHfmhc8 eH14TGQRUYT0RC2x6TrV5/iPASwNeMgdn7cO1iWOzJcjuK1Dtbzfd10l/bvBMBCg9plx /vgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693933891; x=1694538691; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3N9Uu7P0pFtXuyEhyI4j87S5UpaXfMjaO4/TQn/22L0=; b=mCUMOMi0dPRQG4YuhlIn8JZ7Tw8NWl43OBTwr7IdRCNF4LfpQGp0+ICsmolPX3s9fp 3rpNcbcQhxbFkvURKGBC17mDVh0J6wJvCSWbjAkWDJv/mTwvWt8rClG61Nqhq3czOR7t TTVl04+sYO8kW5nvRasWrUQQ+hhKf1CHVIOm3sa0BUW3ak4QmAT3g7mVHYgJqRqa/E5h Fm7VjlDj4255WjUs1C3DjZDIfI0qFEq/kBQAPs62Sl+VAs1rSnPu9YlDc52bPlUDZRTH ZNQwxY7vjZqHyoBJ3F//KDc4E0J/nXzLLSl6vGNgqSRx/ZTKsTm7zgLcYHOujYvg4dXc yAlw== X-Gm-Message-State: AOJu0YyHmcIkw9TPtWUwMJcA2RKtmz7rxJEh9CWibn0biiaGtDGBveL5 HHx/7LlGOa/mtXFPGMs6qIqjyyaBM0SSnMgRZfY= X-Google-Smtp-Source: AGHT+IG+DI2Op6XHNkB8ezKGnKjoUdqtuX4EEp5DRvvMPYdKM8+f7pNG6AhHlz4tQsbF9MOMq3NTA/kkd+5yeaG1Ark= X-Received: by 2002:a2e:9c07:0:b0:2bc:eceb:6a4b with SMTP id s7-20020a2e9c07000000b002bceceb6a4bmr276064lji.28.1693933891348; Tue, 05 Sep 2023 10:11:31 -0700 (PDT) In-Reply-To: <87cyywsghg.fsf@axelf.se> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269386 Archived-At: On Tue, Sep 5, 2023 at 5:59=E2=80=AFPM Axel Forsman wrote: > > I disagree with the initial decision to log all JSONRPC events > by default to begin with, but irregardless, I'll change the default if you volunteer to share half the work of answering and debugging bug reports that contain nothing but screenshots and minimal information with me for the next year. Deal? > should it not be possible to fix the performance issues by > having jsonrpc--log-event push raw events onto a ring, > and introducing a second function that > formats the raw events as strings > and inserts them into a new buffer that gets displayed. > That way the expensive pretty printing would be deferred > to until the events are actually viewed. Fantastic idea if you can make it work. You might be able to use window-configuration-change-hook or something like that. Anyway, await your patches eagerly, but there can't be any interface changes M-x eglot-events-buffer and switch to buffer must work as before. Jo=C3=A3o