unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: SK Kim <tttuuu888@gmail.com>
To: 31800@debbugs.gnu.org
Subject: bug#31800: suggestion of improvement for sort-numeric-fields function.
Date: Wed, 13 Jun 2018 01:09:17 +0900	[thread overview]
Message-ID: <CAKYNWwR2vwfZrMo9QfksJZTnrWd8j69W=kfoXgZM1w5_NYJ_xg@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 656 bytes --]

This is not likely a bug but sort-numeric-fields function does not allow
region with blank lines, while sort-lines does.

This was because sort-skip-fields occurs error with blank line. And when I
added condition for sort-skip-fields like below, sort-numeric-fields was
working with blank lines too.

                     (when (not (string-match-p "^\\s-*$" (thing-at-point
'line)))
                       (sort-skip-fields field))

So, I just hope sort-numeric-fields would work for region with blank lines
too.

I tested with GNU Emacs 26.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.18.9) of 2018-05-29


Always appreciate for contribution.
Thanks.

[-- Attachment #2: Type: text/html, Size: 895 bytes --]

             reply	other threads:[~2018-06-12 16:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-12 16:09 SK Kim [this message]
2019-07-13  3:41 ` bug#31800: suggestion of improvement for sort-numeric-fields function Lars Ingebrigtsen
2019-07-13  8:21   ` SK Kim
2020-01-20 19:55     ` Stefan Kangas
2020-01-22 13:44       ` Lars Ingebrigtsen
2020-01-23 14:50         ` Stefan Kangas
2020-01-24 15:30           ` Lars Ingebrigtsen
2022-02-03 19:34 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKYNWwR2vwfZrMo9QfksJZTnrWd8j69W=kfoXgZM1w5_NYJ_xg@mail.gmail.com' \
    --to=tttuuu888@gmail.com \
    --cc=31800@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).