From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: SK Kim <tttuuu888@gmail.com>, 31800@debbugs.gnu.org
Subject: bug#31800: suggestion of improvement for sort-numeric-fields function.
Date: Wed, 22 Jan 2020 14:44:36 +0100 [thread overview]
Message-ID: <87v9p3vc57.fsf@gnus.org> (raw)
In-Reply-To: <87v9p5rjhj.fsf@marxist.se> (Stefan Kangas's message of "Mon, 20 Jan 2020 20:55:04 +0100")
Stefan Kangas <stefan@marxist.se> writes:
> The patch below looks good to me. Does anyone else have an opinion
> here, or should I go ahead and commit it to master?
[...]
>> - (sort-skip-fields field)
>> + (unless (string-match-p "^\\s-*$" (thing-at-point 'line))
>> + (sort-skip-fields field))
I don't think this patch makes sense as is -- I think that's a
convoluted way of saying `looking-at'? But it makes conceptual sense, I
think.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-01-22 13:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 16:09 bug#31800: suggestion of improvement for sort-numeric-fields function SK Kim
2019-07-13 3:41 ` Lars Ingebrigtsen
2019-07-13 8:21 ` SK Kim
2020-01-20 19:55 ` Stefan Kangas
2020-01-22 13:44 ` Lars Ingebrigtsen [this message]
2020-01-23 14:50 ` Stefan Kangas
2020-01-24 15:30 ` Lars Ingebrigtsen
2022-02-03 19:34 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9p3vc57.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=31800@debbugs.gnu.org \
--cc=stefan@marxist.se \
--cc=tttuuu888@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).