From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: SK Kim Newsgroups: gmane.emacs.bugs Subject: bug#31800: suggestion of improvement for sort-numeric-fields function. Date: Wed, 13 Jun 2018 01:09:17 +0900 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000003a74d5056e7417e9" X-Trace: blaine.gmane.org 1528819699 16643 195.159.176.226 (12 Jun 2018 16:08:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 12 Jun 2018 16:08:19 +0000 (UTC) To: 31800@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 12 18:08:14 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSlqA-0004H3-Mm for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Jun 2018 18:08:14 +0200 Original-Received: from localhost ([::1]:57229 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSlsH-0000lX-QR for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Jun 2018 12:10:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52133) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSlrv-0000cR-3w for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2018 12:10:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSlru-0002m9-7n for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2018 12:10:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37381) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fSlru-0002m2-1b for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2018 12:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fSlrt-0004CH-Se for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2018 12:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: SK Kim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jun 2018 16:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 31800 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.152881978116099 (code B ref -1); Tue, 12 Jun 2018 16:10:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 Jun 2018 16:09:41 +0000 Original-Received: from localhost ([127.0.0.1]:45278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSlrY-0004Bb-Kw for submit@debbugs.gnu.org; Tue, 12 Jun 2018 12:09:40 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60967) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSlrW-0004BM-Ce for submit@debbugs.gnu.org; Tue, 12 Jun 2018 12:09:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSlrQ-0002QJ-Ag for submit@debbugs.gnu.org; Tue, 12 Jun 2018 12:09:33 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:43435) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fSlrQ-0002QD-7X for submit@debbugs.gnu.org; Tue, 12 Jun 2018 12:09:32 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSlrP-0000Sk-6P for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2018 12:09:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSlrO-0002PR-Dd for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2018 12:09:31 -0400 Original-Received: from mail-pf0-x22a.google.com ([2607:f8b0:400e:c00::22a]:35609) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fSlrO-0002PD-09 for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2018 12:09:30 -0400 Original-Received: by mail-pf0-x22a.google.com with SMTP id c22-v6so11940032pfi.2 for ; Tue, 12 Jun 2018 09:09:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=/Y2TdDEV5Am4d3lyWqrnk5pPHltbxJwe4ffEUTHeEF4=; b=gyPDv+4vQnshOawDePoSd8zn6wNIX+wiMSbEkT2yW4z+EiNqft1jS9la9aEBiy5qyA XOie2i/z7XnF7frl2pGaJjivtoQleyf6P6WqXD9PRM+qBNSGOTCozBIyhwFqaBCHqTQ1 Kcva4ZV2IBwwLjRxPiyKnp5uUZFVyhP1OrlM102/Y/8i85f5du+4MXbWlFjLfEOcur6C 9nmknE3n/mzrsi1lBP47GkRJKjY2tvgOzNH4FgskKbB3fLb8LBvUJ5PmijX7lJdTx43Q qyPTZJzeHRr8w6fEEAAETX7ShRvgotxeOb0J8rClwCWDW8hFhBJudPXyOtcC/i0+c2/v wAcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=/Y2TdDEV5Am4d3lyWqrnk5pPHltbxJwe4ffEUTHeEF4=; b=tCbg3zipYSEW+7E0QwpfDebAuEvFSDJcJzqQbbg95+NaNtW3DGiKGNrFSpuJ0Xo0zd Dne7TgHM3rMvmEt9xAG71PuTmrfTNUwcl3Iedn0A3Mfe0g3gBjNXUtOk3hXsbdcxZbgh VvjeKN+kvj3kJ01id+Ejw8K31e2lbiOlp80bnQulDtsa4uin6+4FtdkMXhINz3IE+5BJ FQlfhZsO2g7pEuLNMAs71ZdBpU0CksPyIizdoamIuCloXZYg6iwPU+CzSjTgwdcFKCRv E83I1FQJahJQiEuf/7VqqBO5qCq0Khmec1PeKAXrglrhpmo/NzuT9ITZ1asZ1RtiBh2S lQgg== X-Gm-Message-State: APt69E0HiqkAu9Y4bvoG7NMmlnete/2VSJYEmwIp1zVW5xh4T4AmveB5 YMR/CMEq6/ArTbOuCZjamThJNWIpPQUKIcM3gZh4/oNa X-Google-Smtp-Source: ADUXVKJQQbcDdr+GlenXuotswcfEda8MIYWSdu9kYxxXrOTHFz2gqZmiDiCBN06uiL/XJAkiyPkWQKFWlC0Y2i0DWeM= X-Received: by 2002:a62:d9c5:: with SMTP id b66-v6mr1035084pfl.41.1528819768520; Tue, 12 Jun 2018 09:09:28 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147331 Archived-At: --0000000000003a74d5056e7417e9 Content-Type: text/plain; charset="UTF-8" This is not likely a bug but sort-numeric-fields function does not allow region with blank lines, while sort-lines does. This was because sort-skip-fields occurs error with blank line. And when I added condition for sort-skip-fields like below, sort-numeric-fields was working with blank lines too. (when (not (string-match-p "^\\s-*$" (thing-at-point 'line))) (sort-skip-fields field)) So, I just hope sort-numeric-fields would work for region with blank lines too. I tested with GNU Emacs 26.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.18.9) of 2018-05-29 Always appreciate for contribution. Thanks. --0000000000003a74d5056e7417e9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
This is not likely a bug but sort-numeric-fields function = does not allow region with blank lines, while sort-lines does.
This was because sort-skip-fields occurs error with blank line.= And when I added condition for sort-skip-fields like below, sort-numeric-f= ields was working with blank lines too.

= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0(when (not (string-match-p "^\\s-*$" (thing-at-point 'line= )))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0(sort-skip-fields field))

So, I just hope sort-numeric-fields would work for region with blank = lines too.

I tested with GNU Emacs 26.1 (build 1, = x86_64-pc-linux-gnu, GTK+ Version 3.18.9) of 2018-05-29


Always appreciate for contribution.
Thanks.<= /div>
--0000000000003a74d5056e7417e9--