From: Luis Henriquez-Perez <luishenriquezperez@gmail.com>
To: 21922@debbugs.gnu.org
Subject: bug#21922: Fwd: bug#21922: Fwd: Patch for fixing "straigh-quote" case
Date: Tue, 22 Oct 2019 20:42:38 -0400 [thread overview]
Message-ID: <CAKVVwxe6fr6OC2CVYpJe91H0iJ_3e-DOXf=MvvqUBLetv+8CWw@mail.gmail.com> (raw)
In-Reply-To: <CAKVVwxdAqLNG68P6scLKfNSCupCSB1Yc56qYxJuSrHckP=Jiag@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3079 bytes --]
---------- Forwarded message ---------
From: Luis Henriquez-Perez <luishenriquezperez@gmail.com>
Date: Tue, Oct 22, 2019 at 8:41 PM
Subject: Re: bug#21922: Fwd: Patch for fixing "straigh-quote" case
To: Noam Postavsky <npostavs@gmail.com>
>> I did see your message.
Ok, take your time. I just wanted to make sure I sent this to the right
place.
>> I meant to say (looking-at-p "[[:space:]\n]*quote\\_>")
I changed "[[:space:]\n]" -> "[[:space:]]\n" because I think that's what
you meant.
I posted the result of these change at the bottom of this reply.
I'm new to contributing patches. Is there anything else I need to do to get
this
into emacs?
```elisp
(if (or
(= (point) calculate-lisp-indent-last-sexp)
(eq (char-after (1+ containing-sexp)) ?:)
(eq (char-before containing-sexp) ?')
(let ((quoted-p nil)
(point nil)
(positions (nreverse (butlast (elt state 9)))))
(save-excursion
(while (and positions (not quoted-p))
(setq point (pop positions))
(setq quoted-p
(or (eq (char-before point) ?')
(goto-char (1+ point))
(looking-at-p "[[:space:]]\n*quote\\_>")))))
quoted-p))
;; Containing sexp has nothing before this line
;; except the first element. Indent under that element.
nil
;; Skip the first element, find start of second (the first
;; argument of the function call) and indent under.
(progn (forward-sexp 1)
(parse-partial-sexp (point)
calculate-lisp-indent-last-sexp
0 t)))
```
On Tue, Oct 22, 2019 at 7:59 PM Noam Postavsky <npostavs@gmail.com> wrote:
> Luis Henriquez-Perez <luishenriquezperez@gmail.com> writes:
>
> > I replied to your personal email instead of this thread. I thought maybe
> my
> > replies had not been seen (and also that this should be recorded in the
> > thread). So this is what I had said:
>
> I did you see your messages, just haven't had so much time for handling
> Emacs bugs recently. I was going to forward it to the list before
> replying, so thanks for doing that.
>
> > question 1:
> > I get an `unknown posix character class` error when I try (looking-at-p
> > "[[:whitespace:]\n]*quote\_>"). Did you mean to use [[:space:]] instead?
> > Did you mean: (looking-at-p "[[:space:]]*quote\\>")?
>
> I mixed things up a bit, I meant to say
>
> (looking-at-p "[[:space:]\n]*quote\\_>")
>
> The "\n" is needed because it typically has comment-ender syntax instead
> of space syntax. "\\>" matches end of word, "\\_>" is end of symbol.
>
> > question 2:
> > The reason I used explicit whitespace character is because matches for
> > character classes like [[:space:]] are dependent on the active syntax
> table
> > in the buffer (see this issue
> > <
> https://emacs.stackexchange.com/questions/40911/why-do-regexp-that-matches-text-in-buffer-does-not-necessarily-match-same-text
> >).
> > Not sure if this will be a problem though, what do you think?
>
> I think relying on the mode's syntax table makes sense, though it
> probably doesn't matter a whole lot either way.
>
[-- Attachment #2: Type: text/html, Size: 4452 bytes --]
next prev parent reply other threads:[~2019-10-23 0:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAKVVwxeE8TuHM4-sd6=dAo0Nr3OAU1xD_gxvzrNmLFVoEZY-XQ@mail.gmail.com>
2019-10-22 23:40 ` bug#21922: Fwd: Patch for fixing "straigh-quote" case Luis Henriquez-Perez
2019-10-22 23:59 ` Noam Postavsky
[not found] ` <CAKVVwxdAqLNG68P6scLKfNSCupCSB1Yc56qYxJuSrHckP=Jiag@mail.gmail.com>
2019-10-23 0:42 ` Luis Henriquez-Perez [this message]
2019-10-23 0:55 ` bug#21922: Fwd: " Noam Postavsky
[not found] ` <CAKVVwxfCgR6hzmX2O+XrfeeOO-i9ywSan=WLjhfbQ9QArrkqKA@mail.gmail.com>
2019-10-23 1:28 ` bug#21922: Fwd: " Luis Henriquez-Perez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKVVwxe6fr6OC2CVYpJe91H0iJ_3e-DOXf=MvvqUBLetv+8CWw@mail.gmail.com' \
--to=luishenriquezperez@gmail.com \
--cc=21922@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).