unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@gmail.com>
To: Luis Henriquez-Perez <luishenriquezperez@gmail.com>
Cc: 21922@debbugs.gnu.org
Subject: bug#21922: Fwd: Patch for fixing "straigh-quote" case
Date: Tue, 22 Oct 2019 19:59:55 -0400	[thread overview]
Message-ID: <871rv4e3gk.fsf@gmail.com> (raw)
In-Reply-To: <CAKVVwxfPtvcgh_ViiguPFEzRi7uxdNGTVmFUeNihQCra7OQ=6A@mail.gmail.com> (Luis Henriquez-Perez's message of "Tue, 22 Oct 2019 19:40:38 -0400")

Luis Henriquez-Perez <luishenriquezperez@gmail.com> writes:

> I replied to your personal email instead of this thread. I thought maybe my
> replies had not been seen (and also that this should be recorded in the
> thread). So this is what I had said:

I did you see your messages, just haven't had so much time for handling
Emacs bugs recently.  I was going to forward it to the list before
replying, so thanks for doing that.

> question 1:
> I get an `unknown posix character class` error when I try (looking-at-p
> "[[:whitespace:]\n]*quote\_>").  Did you mean to use [[:space:]] instead?
> Did you mean:  (looking-at-p "[[:space:]]*quote\\>")?

I mixed things up a bit, I meant to say

    (looking-at-p "[[:space:]\n]*quote\\_>")

The "\n" is needed because it typically has comment-ender syntax instead
of space syntax.  "\\>" matches end of word, "\\_>" is end of symbol.

> question 2:
> The reason I used explicit whitespace character is because matches for
> character classes like [[:space:]] are dependent on the active syntax table
> in the buffer (see this issue
> <https://emacs.stackexchange.com/questions/40911/why-do-regexp-that-matches-text-in-buffer-does-not-necessarily-match-same-text>).
> Not sure if this will be a problem though, what do you think?

I think relying on the mode's syntax table makes sense, though it
probably doesn't matter a whole lot either way.





  reply	other threads:[~2019-10-22 23:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAKVVwxeE8TuHM4-sd6=dAo0Nr3OAU1xD_gxvzrNmLFVoEZY-XQ@mail.gmail.com>
2019-10-22 23:40 ` bug#21922: Fwd: Patch for fixing "straigh-quote" case Luis Henriquez-Perez
2019-10-22 23:59   ` Noam Postavsky [this message]
     [not found]     ` <CAKVVwxdAqLNG68P6scLKfNSCupCSB1Yc56qYxJuSrHckP=Jiag@mail.gmail.com>
2019-10-23  0:42       ` bug#21922: Fwd: " Luis Henriquez-Perez
2019-10-23  0:55         ` Noam Postavsky
     [not found]           ` <CAKVVwxfCgR6hzmX2O+XrfeeOO-i9ywSan=WLjhfbQ9QArrkqKA@mail.gmail.com>
2019-10-23  1:28             ` bug#21922: Fwd: " Luis Henriquez-Perez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rv4e3gk.fsf@gmail.com \
    --to=npostavs@gmail.com \
    --cc=21922@debbugs.gnu.org \
    --cc=luishenriquezperez@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).