* bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option
@ 2011-12-10 11:10 Dani Moncayo
[not found] ` <CAH8Pv0gPEq9gVF+zs=rf26gu8mFtwW6rHbs25mZHxae4Z2g_NQ@mail.gmail.com>
0 siblings, 1 reply; 19+ messages in thread
From: Dani Moncayo @ 2011-12-10 11:10 UTC (permalink / raw)
To: 10261
Hi,
After bootstrapping Emacs on my system (MS-Windows 7 64-bit; mingw32),
if I try the "dist" target (mingw32-make dist), I get this error:
--------------------------------------[...]cp -rf
"C:/emacs/trunk/nt/../leim" emacs-24.0.92
cp -rf "C:/emacs/trunk/nt/../site-lisp" emacs-24.0.92
cp -rf emacs-24.0.92/bin
cp: missing destination file operand after `emacs-24.0.92/bin'
Try `cp --help' for more information.
mingw32-make: *** [dist] Error 1
--------------------------------------
Looking at the file "nt/makefile", the failing sentence seems to be
this one: $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin
The problem is that `$(DIST_FILES)' expands to nothing, because I
specified no "--distfiles" argument to configure.bat. In fact, if I
comment out that line, everything seem to go fine.
Therefore, I request to allow making a binary distribution even in
this case, i.e., that the above-mentioned like of nt/makefile was not
written by the configure script when there is no --distfiles
arguments.
TIA
In GNU Emacs 24.0.92.1 (i386-mingw-nt6.1.7601)
of 2011-12-09 on DANI-PC
Windowing system distributor `Microsoft Corp.', version 6.1.7601
configured using `configure --with-gcc (4.6) --no-opt --cflags
-fno-omit-frame-pointer'
--
Dani Moncayo
^ permalink raw reply [flat|nested] 19+ messages in thread[parent not found: <CAH8Pv0gPEq9gVF+zs=rf26gu8mFtwW6rHbs25mZHxae4Z2g_NQ@mail.gmail.com>]
* bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option [not found] ` <CAH8Pv0gPEq9gVF+zs=rf26gu8mFtwW6rHbs25mZHxae4Z2g_NQ@mail.gmail.com> @ 2011-12-10 11:25 ` Dani Moncayo 2011-12-10 14:32 ` Christoph Scholtes 2012-01-02 22:08 ` Christoph Scholtes 0 siblings, 2 replies; 19+ messages in thread From: Dani Moncayo @ 2011-12-10 11:25 UTC (permalink / raw) To: 10261 [Sorry, the OP is badly formatted, due to some "feature" of GMail. Here is the message again, hopefully well formatted]. After bootstrapping Emacs on my system (MS-Windows 7 64-bit; mingw32), if I try the "dist" target (mingw32-make dist), I get this error: -------------------------------------- [...] cp -rf "C:/emacs/trunk/nt/../leim" emacs-24.0.92 cp -rf "C:/emacs/trunk/nt/../site-lisp" emacs-24.0.92 cp -rf emacs-24.0.92/bin cp: missing destination file operand after `emacs-24.0.92/bin' Try `cp --help' for more information. mingw32-make: *** [dist] Error 1 -------------------------------------- Looking at the file "nt/makefile", the failing sentence seems to be this one: $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin The problem is that `$(DIST_FILES)' expands to nothing, because I specified no "--distfiles" argument to configure.bat. In fact, if I comment out that line, everything seem to go fine. Therefore, I request to allow making a binary distribution even in this case, i.e., that the above-mentioned like of nt/makefile was not written by the configure script when there is no --distfiles arguments. TIA. In GNU Emacs 24.0.92.1 (i386-mingw-nt6.1.7601) of 2011-12-09 on DANI-PC Windowing system distributor `Microsoft Corp.', version 6.1.7601 configured using `configure --with-gcc (4.6) --no-opt --cflags -fno-omit-frame-pointer' -- Dani Moncayo ^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option 2011-12-10 11:25 ` Dani Moncayo @ 2011-12-10 14:32 ` Christoph Scholtes 2011-12-10 15:06 ` Dani Moncayo 2012-01-02 22:08 ` Christoph Scholtes 1 sibling, 1 reply; 19+ messages in thread From: Christoph Scholtes @ 2011-12-10 14:32 UTC (permalink / raw) To: Dani Moncayo; +Cc: 10261 On 12/10/2011 4:25 AM, Dani Moncayo wrote: > Therefore, I request to allow making a binary distribution even in > this case, i.e., that the above-mentioned like of nt/makefile was not > written by the configure script when there is no --distfiles > arguments. I will look into it. Just out of curiosity, don't you want to package at least libXpm.dll in your distribution via ---distfiles? Christoph ^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option 2011-12-10 14:32 ` Christoph Scholtes @ 2011-12-10 15:06 ` Dani Moncayo 0 siblings, 0 replies; 19+ messages in thread From: Dani Moncayo @ 2011-12-10 15:06 UTC (permalink / raw) To: Christoph Scholtes; +Cc: 10261 >> Therefore, I request to allow making a binary distribution even in >> this case, i.e., that the above-mentioned like of nt/makefile was not ^^^^ I meant "line". Sorry. >> written by the configure script when there is no --distfiles >> arguments. > > > I will look into it. Thank you. > Just out of curiosity, don't you want to package at least libXpm.dll in your > distribution via ---distfiles? Currently I have no need to package any library, even libXpm.dll. I use Emacs for editing text and source code, and I don't want to use toolbars (at all! :)), so I don't see why I would need that libraries. -- Dani Moncayo ^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option 2011-12-10 11:25 ` Dani Moncayo 2011-12-10 14:32 ` Christoph Scholtes @ 2012-01-02 22:08 ` Christoph Scholtes 2012-02-04 22:46 ` Christoph Scholtes 1 sibling, 1 reply; 19+ messages in thread From: Christoph Scholtes @ 2012-01-02 22:08 UTC (permalink / raw) To: Dani Moncayo; +Cc: 10261 On 12/10/2011 4:25 AM, Dani Moncayo wrote: > The problem is that `$(DIST_FILES)' expands to nothing, because I > specified no "--distfiles" argument to configure.bat. In fact, if I > comment out that line, everything seem to go fine. > > Therefore, I request to allow making a binary distribution even in > this case, i.e., that the above-mentioned like of nt/makefile was not > written by the configure script when there is no --distfiles > arguments. The following patch should fix the problem. It only copies the dist files if any files were specified in the DIST_FILES variable via configure.bat. Eli, could you please review this to ensure that I am not over-complicating things. Thanks. === modified file 'nt/makefile.w32-in' --- nt/makefile.w32-in 2011-11-30 16:23:05 +0000 +++ nt/makefile.w32-in 2012-01-02 22:03:04 +0000 @@ -257,8 +257,22 @@ install-shortcuts: "$(INSTALL_DIR)/bin/addpm" -q -dist: install-bin - mkdir $(TMP_DIST_DIR) +maybe-copy-distfiles: maybe-copy-distfiles-$(SHELLTYPE) + +maybe-copy-distfiles-CMD: doit + @if not $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin + +maybe-copy-distfiles-SH: doit + @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \ + $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin + fi + +create-tmp-dist-dir: + mkdir "$(TMP_DIST_DIR)" +# Also create bin directory for dist files. + mkdir "$(TMP_DIST_DIR)/bin" + +dist: install-bin create-tmp-dist-dir maybe-copy-distfiles $(CP) "$(INSTALL_DIR)/BUGS" $(TMP_DIST_DIR) $(CP) "$(INSTALL_DIR)/COPYING" $(TMP_DIST_DIR) $(CP) "$(INSTALL_DIR)/README" $(TMP_DIST_DIR) @@ -269,7 +283,6 @@ $(CP_DIR) "$(INSTALL_DIR)/lisp" $(TMP_DIST_DIR) $(CP_DIR) "$(INSTALL_DIR)/leim" $(TMP_DIST_DIR) $(CP_DIR) "$(INSTALL_DIR)/site-lisp" $(TMP_DIST_DIR) - $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin $(COMSPEC)$(ComSpec) /c $(ARGQUOTE)zipdist.bat $(VERSION)$(ARGQUOTE) $(DEL_TREE) $(TMP_DIST_DIR) ^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option 2012-01-02 22:08 ` Christoph Scholtes @ 2012-02-04 22:46 ` Christoph Scholtes 2012-02-05 16:47 ` Eli Zaretskii 0 siblings, 1 reply; 19+ messages in thread From: Christoph Scholtes @ 2012-02-04 22:46 UTC (permalink / raw) To: Dani Moncayo; +Cc: 10261 On 1/2/2012 3:08 PM, Christoph Scholtes wrote: > On 12/10/2011 4:25 AM, Dani Moncayo wrote: > >> The problem is that `$(DIST_FILES)' expands to nothing, because I >> specified no "--distfiles" argument to configure.bat. In fact, if I >> comment out that line, everything seem to go fine. >> >> Therefore, I request to allow making a binary distribution even in >> this case, i.e., that the above-mentioned like of nt/makefile was not >> written by the configure script when there is no --distfiles >> arguments. > > The following patch should fix the problem. It only copies the dist > files if any files were specified in the DIST_FILES variable via > configure.bat. > > Eli, could you please review this to ensure that I am not > over-complicating things. Thanks. > > === modified file 'nt/makefile.w32-in' > --- nt/makefile.w32-in 2011-11-30 16:23:05 +0000 > +++ nt/makefile.w32-in 2012-01-02 22:03:04 +0000 > @@ -257,8 +257,22 @@ > install-shortcuts: > "$(INSTALL_DIR)/bin/addpm" -q > > -dist: install-bin > - mkdir $(TMP_DIST_DIR) > +maybe-copy-distfiles: maybe-copy-distfiles-$(SHELLTYPE) > + > +maybe-copy-distfiles-CMD: doit > + @if not $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" $(CP_DIR) > $(DIST_FILES) $(TMP_DIST_DIR)/bin > + > +maybe-copy-distfiles-SH: doit > + @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \ > + $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin > + fi > + > +create-tmp-dist-dir: > + mkdir "$(TMP_DIST_DIR)" > +# Also create bin directory for dist files. > + mkdir "$(TMP_DIST_DIR)/bin" > + > +dist: install-bin create-tmp-dist-dir maybe-copy-distfiles > $(CP) "$(INSTALL_DIR)/BUGS" $(TMP_DIST_DIR) > $(CP) "$(INSTALL_DIR)/COPYING" $(TMP_DIST_DIR) > $(CP) "$(INSTALL_DIR)/README" $(TMP_DIST_DIR) > @@ -269,7 +283,6 @@ > $(CP_DIR) "$(INSTALL_DIR)/lisp" $(TMP_DIST_DIR) > $(CP_DIR) "$(INSTALL_DIR)/leim" $(TMP_DIST_DIR) > $(CP_DIR) "$(INSTALL_DIR)/site-lisp" $(TMP_DIST_DIR) > - $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin > $(COMSPEC)$(ComSpec) /c $(ARGQUOTE)zipdist.bat $(VERSION)$(ARGQUOTE) > $(DEL_TREE) $(TMP_DIST_DIR) Any issues with applying this patch? Christoph ^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option 2012-02-04 22:46 ` Christoph Scholtes @ 2012-02-05 16:47 ` Eli Zaretskii 2012-02-05 18:19 ` Christoph Scholtes 2012-02-05 20:22 ` Christoph Scholtes 0 siblings, 2 replies; 19+ messages in thread From: Eli Zaretskii @ 2012-02-05 16:47 UTC (permalink / raw) To: Christoph Scholtes; +Cc: 10261 > Date: Sat, 04 Feb 2012 15:46:04 -0700 > From: Christoph Scholtes <cschol2112@googlemail.com> > CC: 10261@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org> > > Any issues with applying this patch? No. (And sorry I missed this.) ^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option 2012-02-05 16:47 ` Eli Zaretskii @ 2012-02-05 18:19 ` Christoph Scholtes 2012-02-05 20:22 ` Christoph Scholtes 1 sibling, 0 replies; 19+ messages in thread From: Christoph Scholtes @ 2012-02-05 18:19 UTC (permalink / raw) To: Eli Zaretskii; +Cc: 10261 Eli Zaretskii <eliz@gnu.org> writes: >> Date: Sat, 04 Feb 2012 15:46:04 -0700 >> From: Christoph Scholtes <cschol2112@googlemail.com> >> CC: 10261@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org> >> >> Any issues with applying this patch? > > No. (And sorry I missed this.) Thanks. I will commit this later today. ^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option 2012-02-05 16:47 ` Eli Zaretskii 2012-02-05 18:19 ` Christoph Scholtes @ 2012-02-05 20:22 ` Christoph Scholtes [not found] ` <CAH8Pv0jsXLTywqE+aT8aH-o_JSP60z84W6_5wmR_KmQNXiBiLg@mail.gmail.com> 1 sibling, 1 reply; 19+ messages in thread From: Christoph Scholtes @ 2012-02-05 20:22 UTC (permalink / raw) To: Eli Zaretskii; +Cc: 10261-done Fixed in Emacs trunk r107121. ^ permalink raw reply [flat|nested] 19+ messages in thread
[parent not found: <CAH8Pv0jsXLTywqE+aT8aH-o_JSP60z84W6_5wmR_KmQNXiBiLg@mail.gmail.com>]
[parent not found: <CAH8Pv0hzisvR1TuAL45RS64RAX7CB9W8cFNoS_E6Qt87Bb9ipg@mail.gmail.com>]
[parent not found: <837gzpxkga.fsf@gnu.org>]
[parent not found: <CAH8Pv0iw2HquHJ5v1r6phLqFqMgW7_kK44AbO9PBC5Zu3U-aLA@mail.gmail.com>]
[parent not found: <834nutxgw8.fsf@gnu.org>]
[parent not found: <CAH8Pv0iZYdBDEL-1rReRYXb4z6Oi5b4y6tmVaJFBKoDiVk_seA@mail.gmail.com>]
[parent not found: <83wr7ovxh5.fsf@gnu.org>]
[parent not found: <CAH8Pv0iH0aPf+ON0yL7SMVsNhxv0Ww3j0knpD2_qJo1MgHAPmg@mail.gmail.com>]
* bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option [not found] ` <CAH8Pv0iH0aPf+ON0yL7SMVsNhxv0Ww3j0knpD2_qJo1MgHAPmg@mail.gmail.com> @ 2012-02-23 7:22 ` Dani Moncayo 2012-02-23 7:52 ` Stefan Monnier 0 siblings, 1 reply; 19+ messages in thread From: Dani Moncayo @ 2012-02-23 7:22 UTC (permalink / raw) To: Eli Zaretskii; +Cc: cschol2112, 10261 > The following patch should fix this problem: > > === modified file 'nt/makefile.w32-in' > --- nt/makefile.w32-in 2012-02-05 20:14:54 +0000 > +++ nt/makefile.w32-in 2012-02-15 18:32:45 +0000 > @@ -264,7 +264,7 @@ > > maybe-copy-distfiles-SH: doit > @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \ > - $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin > + $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin ; \ > fi > > create-tmp-dist-dir: If this patch is ok, could someone commit it? -- Dani Moncayo ^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option 2012-02-23 7:22 ` Dani Moncayo @ 2012-02-23 7:52 ` Stefan Monnier 2012-02-23 7:59 ` Dani Moncayo 0 siblings, 1 reply; 19+ messages in thread From: Stefan Monnier @ 2012-02-23 7:52 UTC (permalink / raw) To: Dani Moncayo; +Cc: cschol2112, 10261 >> The following patch should fix this problem: >> >> === modified file 'nt/makefile.w32-in' >> --- nt/makefile.w32-in 2012-02-05 20:14:54 +0000 >> +++ nt/makefile.w32-in 2012-02-15 18:32:45 +0000 >> @@ -264,7 +264,7 @@ >> >> maybe-copy-distfiles-SH: doit >> @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \ >> - $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin >> + $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin ; \ >> fi >> >> create-tmp-dist-dir: > If this patch is ok, could someone commit it? Looks correct, committed (tho I couldn't find the original message you quote, so I don't know who to attribute that to). Stefan ^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option 2012-02-23 7:52 ` Stefan Monnier @ 2012-02-23 7:59 ` Dani Moncayo 2012-02-23 8:00 ` Dani Moncayo 0 siblings, 1 reply; 19+ messages in thread From: Dani Moncayo @ 2012-02-23 7:59 UTC (permalink / raw) To: Stefan Monnier; +Cc: cschol2112, 10261 >> If this patch is ok, could someone commit it? > > Looks correct, committed (tho I couldn't find the original message you > quote, so I don't know who to attribute that to). You can see the thread here: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10261 But I don't understand why some messages don't appear in (http://lists.gnu.org/archive/html/bug-gnu-emacs). It seems like the messages sent to "(bug-number)@debbugs.org" are not showed there. IMO, they should. -- Dani Moncayo ^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option 2012-02-23 7:59 ` Dani Moncayo @ 2012-02-23 8:00 ` Dani Moncayo 2012-02-23 8:37 ` Glenn Morris 0 siblings, 1 reply; 19+ messages in thread From: Dani Moncayo @ 2012-02-23 8:00 UTC (permalink / raw) To: Stefan Monnier; +Cc: cschol2112, 10261 > But I don't understand why some messages don't appear in > (http://lists.gnu.org/archive/html/bug-gnu-emacs). It seems like the > messages sent to "(bug-number)@debbugs.org" are not showed there. ^^^^^^^^^^^^^^^^^^^^^^^^^ > IMO, they should. Sorry, I mean "(bug-number)-done@debbugs.org" -- Dani Moncayo ^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option 2012-02-23 8:00 ` Dani Moncayo @ 2012-02-23 8:37 ` Glenn Morris 0 siblings, 0 replies; 19+ messages in thread From: Glenn Morris @ 2012-02-23 8:37 UTC (permalink / raw) To: Dani Moncayo; +Cc: cschol2112, 10261 Dani Moncayo wrote: >> But I don't understand why some messages don't appear in >> (http://lists.gnu.org/archive/html/bug-gnu-emacs). It seems like the >> messages sent to "(bug-number)@debbugs.org" are not showed there. > ^^^^^^^^^^^^^^^^^^^^^^^^^ >> IMO, they should. > > Sorry, I mean "(bug-number)-done@debbugs.org" http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9467 (Basically, don't send to a -done address unless you want to close an open bug. FWIW, Mail-Followup-To is set appropriately in -done messages.) ^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option [not found] ` <834nutxgw8.fsf@gnu.org> [not found] ` <CAH8Pv0iZYdBDEL-1rReRYXb4z6Oi5b4y6tmVaJFBKoDiVk_seA@mail.gmail.com> @ 2012-02-27 19:43 ` Dani Moncayo 2012-03-23 18:59 ` Dani Moncayo 1 sibling, 1 reply; 19+ messages in thread From: Dani Moncayo @ 2012-02-27 19:43 UTC (permalink / raw) To: 10261; +Cc: cschol2112 I'm re-sending a message from Eli to this list, because I think it didn't arrive to you, since it was sent to a "-done" address (10261-done@debbugs.gnu.org). On Tue, Feb 14, 2012 at 22:08, Eli Zaretskii <eliz@gnu.org> wrote: >>[...] >> And BTW, I'm wondering too: what's the point of the "barebin" file? > > For people who want to be able to dump their own Emacs after > preloading a different collection of Lisp files, I think. I never > used it, FWIW. > >> Should not be separate targets for making the "bin" and "barebin" >> files? > > I actually think we need to deprecate it and eventual stop building > and distributing it. I doubt anyone ever used it. If nobody uses this "barebin" target, I also suggest to deprecate/remove it. -- Dani Moncayo ^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option 2012-02-27 19:43 ` Dani Moncayo @ 2012-03-23 18:59 ` Dani Moncayo 2012-03-23 19:24 ` Dani Moncayo 0 siblings, 1 reply; 19+ messages in thread From: Dani Moncayo @ 2012-03-23 18:59 UTC (permalink / raw) To: 10261; +Cc: cschol2112 Hi, In this bug report, the "dist" target of the nt/makefile was fixed because it failed when no --distfiles argument was given to configure (it always tried to run the "cp" command, and in this case failed). Well, now I've tried to build Emacs in my system, but this time giving a --distfiles argument to configure (for including the libXpm.dll in the binary distribution). I've found that the zip file has been generated without errors, but the dll file has not been included in the "bin" subdirectory. After doing a few experiments, I've found that the problem is in the "maybe-copy-distfiles-SH" target. Currently the target is defined like this: ------------------------- maybe-copy-distfiles-SH: doit @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \ $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin ; \ fi ------------------------- and I've seen that the "if" condition never evaluates to true, so that my distfiles are never copied to the bin subdirectory (regardless of the value of DIST_FILES). I think I've found a solution (I've tested it): write the "if" condition like this: if [ -n $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE) ] ; then \ This is the corresponding patch: === modified file 'nt/makefile.w32-in' --- nt/makefile.w32-in 2012-02-27 03:20:00 +0000 +++ nt/makefile.w32-in 2012-03-23 18:57:00 +0000 @@ -263,7 +263,7 @@ @if not $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin maybe-copy-distfiles-SH: doit - @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \ + @if [ -n $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE) ] ; then \ $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin ; \ fi Do you find it correct? If so, please install it. Thanks. -- Dani Moncayo ^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option 2012-03-23 18:59 ` Dani Moncayo @ 2012-03-23 19:24 ` Dani Moncayo 2012-04-11 6:33 ` Chong Yidong 0 siblings, 1 reply; 19+ messages in thread From: Dani Moncayo @ 2012-03-23 19:24 UTC (permalink / raw) To: 10261; +Cc: cschol2112 > ------------------------- > maybe-copy-distfiles-SH: doit > > @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \ > > $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin ; \ > > fi > ------------------------- I've done a few more test, and actually the problem was in that the "==" should be surrounded by spaces. So install the fix that you prefer (this one or the one I sent before). -- Dani Moncayo ^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option 2012-03-23 19:24 ` Dani Moncayo @ 2012-04-11 6:33 ` Chong Yidong 2012-04-11 13:11 ` Dani Moncayo 0 siblings, 1 reply; 19+ messages in thread From: Chong Yidong @ 2012-04-11 6:33 UTC (permalink / raw) To: Dani Moncayo; +Cc: cschol2112, 10261 Dani Moncayo <dmoncayo@gmail.com> writes: > I've done a few more test, and actually the problem was in that the > "==" should be surrounded by spaces. > > So install the fix that you prefer (this one or the one I sent before). Done. ^ permalink raw reply [flat|nested] 19+ messages in thread
* bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option 2012-04-11 6:33 ` Chong Yidong @ 2012-04-11 13:11 ` Dani Moncayo 0 siblings, 0 replies; 19+ messages in thread From: Dani Moncayo @ 2012-04-11 13:11 UTC (permalink / raw) To: Chong Yidong; +Cc: cschol2112, 10261 > > I've done a few more test, and actually the problem was in that the > > "==" should be surrounded by spaces. > > > > So install the fix that you prefer (this one or the one I sent before). > > Done. Thanks. Actually the bug was only about the "maybe-copy-distfiles-SH" target ("maybe-copy-distfiles-CMD" is not executed in my current environment), but I guess that the additional change in "maybe-copy-distfiles-CMD" is fine too. So, I guess this bug report could be closed. Thanks again. -- Dani Moncayo ^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2012-04-11 13:11 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-10 11:10 bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option Dani Moncayo
[not found] ` <CAH8Pv0gPEq9gVF+zs=rf26gu8mFtwW6rHbs25mZHxae4Z2g_NQ@mail.gmail.com>
2011-12-10 11:25 ` Dani Moncayo
2011-12-10 14:32 ` Christoph Scholtes
2011-12-10 15:06 ` Dani Moncayo
2012-01-02 22:08 ` Christoph Scholtes
2012-02-04 22:46 ` Christoph Scholtes
2012-02-05 16:47 ` Eli Zaretskii
2012-02-05 18:19 ` Christoph Scholtes
2012-02-05 20:22 ` Christoph Scholtes
[not found] ` <CAH8Pv0jsXLTywqE+aT8aH-o_JSP60z84W6_5wmR_KmQNXiBiLg@mail.gmail.com>
[not found] ` <CAH8Pv0hzisvR1TuAL45RS64RAX7CB9W8cFNoS_E6Qt87Bb9ipg@mail.gmail.com>
[not found] ` <837gzpxkga.fsf@gnu.org>
[not found] ` <CAH8Pv0iw2HquHJ5v1r6phLqFqMgW7_kK44AbO9PBC5Zu3U-aLA@mail.gmail.com>
[not found] ` <834nutxgw8.fsf@gnu.org>
[not found] ` <CAH8Pv0iZYdBDEL-1rReRYXb4z6Oi5b4y6tmVaJFBKoDiVk_seA@mail.gmail.com>
[not found] ` <83wr7ovxh5.fsf@gnu.org>
[not found] ` <CAH8Pv0iH0aPf+ON0yL7SMVsNhxv0Ww3j0knpD2_qJo1MgHAPmg@mail.gmail.com>
2012-02-23 7:22 ` Dani Moncayo
2012-02-23 7:52 ` Stefan Monnier
2012-02-23 7:59 ` Dani Moncayo
2012-02-23 8:00 ` Dani Moncayo
2012-02-23 8:37 ` Glenn Morris
2012-02-27 19:43 ` Dani Moncayo
2012-03-23 18:59 ` Dani Moncayo
2012-03-23 19:24 ` Dani Moncayo
2012-04-11 6:33 ` Chong Yidong
2012-04-11 13:11 ` Dani Moncayo
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).