From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dani Moncayo Newsgroups: gmane.emacs.bugs Subject: bug#10261: 24.0.92; The "dist" makefile target & the "--distfiles" configure option Date: Fri, 23 Mar 2012 19:59:38 +0100 Message-ID: References: <4F022AC1.3000009@gmail.com> <4F2DB52C.30801@gmail.com> <83ehu9cjn4.fsf@gnu.org> <86vcnlyqr0.fsf@googlemail.com> <837gzpxkga.fsf@gnu.org> <834nutxgw8.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: dough.gmane.org 1332529226 18321 80.91.229.3 (23 Mar 2012 19:00:26 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 23 Mar 2012 19:00:26 +0000 (UTC) Cc: cschol2112@googlemail.com To: 10261@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 23 20:00:23 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SB9io-0004iF-AE for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Mar 2012 20:00:22 +0100 Original-Received: from localhost ([::1]:34099 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SB9in-0006Bu-R4 for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Mar 2012 15:00:21 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46856) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SB9ih-00062h-LY for bug-gnu-emacs@gnu.org; Fri, 23 Mar 2012 15:00:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SB9ic-0001QJ-Rk for bug-gnu-emacs@gnu.org; Fri, 23 Mar 2012 15:00:15 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57112) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SB9ic-0001Q0-MG for bug-gnu-emacs@gnu.org; Fri, 23 Mar 2012 15:00:10 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SBACV-0000g6-Bh for bug-gnu-emacs@gnu.org; Fri, 23 Mar 2012 15:31:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dani Moncayo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Mar 2012 19:31:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10261 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: Original-Received: via spool by 10261-submit@debbugs.gnu.org id=B10261.13325310622600 (code B ref 10261); Fri, 23 Mar 2012 19:31:03 +0000 Original-Received: (at 10261) by debbugs.gnu.org; 23 Mar 2012 19:31:02 +0000 Original-Received: from localhost ([127.0.0.1]:35711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SBACP-0000fi-RO for submit@debbugs.gnu.org; Fri, 23 Mar 2012 15:30:59 -0400 Original-Received: from mail-ey0-f172.google.com ([209.85.215.172]:46574) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SBAC1-0000fB-Ex for 10261@debbugs.gnu.org; Fri, 23 Mar 2012 15:30:55 -0400 Original-Received: by eaaq11 with SMTP id q11so1163630eaa.3 for <10261@debbugs.gnu.org>; Fri, 23 Mar 2012 11:59:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=h6iSZgojQosxOvw/HkXB4TucNMMO1SQ12DRjumFmUxo=; b=N4blc5hn6Ry2Zggcc6erzdVBmURM35Y88Wuw0Q6U7ITc0fMsyICLzRNHrpDwhO7IV/ yw/bZzkz5uLmZ50pmfE+KW2wvJPF1dCqaIjLSD62ZNG1n1+0ts85+JcBbuSbq1b3FOIU heNesG5UOMSpCtCORu4+ZNKKHMbJtJK56xGiy0dHOlvQEiSxfmDN/7Q6FOFbX+0risdu 2DGNxMy7QTNDcZfiyEEv+yBUU/rrRrKNnyl9XFgYBFUsCptBEjTD+qoiu42jRmKLG0oN ahWtZ5d4a9fozlteChEpFd/AexrMXkG2/PuGIfCajeoIQt+7On1bfK4Y2MhPf9dCiW6/ zRjQ== Original-Received: by 10.14.123.202 with SMTP id v50mr1798728eeh.95.1332529178218; Fri, 23 Mar 2012 11:59:38 -0700 (PDT) Original-Received: by 10.14.100.74 with HTTP; Fri, 23 Mar 2012 11:59:38 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:58033 Archived-At: Hi, In this bug report, the "dist" target of the nt/makefile was fixed because it failed when no --distfiles argument was given to configure (it always tried to run the "cp" command, and in this case failed). Well, now I've tried to build Emacs in my system, but this time giving a --distfiles argument to configure (for including the libXpm.dll in the binary distribution). I've found that the zip file has been generated without errors, but the dll file has not been included in the "bin" subdirectory. After doing a few experiments, I've found that the problem is in the "maybe-copy-distfiles-SH" target. Currently the target is defined like this: ------------------------- maybe-copy-distfiles-SH: doit @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \ $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin ; \ fi ------------------------- and I've seen that the "if" condition never evaluates to true, so that my distfiles are never copied to the bin subdirectory (regardless of the value of DIST_FILES). I think I've found a solution (I've tested it): write the "if" condition like this: if [ -n $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE) ] ; then \ This is the corresponding patch: === modified file 'nt/makefile.w32-in' --- nt/makefile.w32-in 2012-02-27 03:20:00 +0000 +++ nt/makefile.w32-in 2012-03-23 18:57:00 +0000 @@ -263,7 +263,7 @@ @if not $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin maybe-copy-distfiles-SH: doit - @if [ ! $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE)=="" ] ; then \ + @if [ -n $(ARGQUOTE)$(DIST_FILES)$(ARGQUOTE) ] ; then \ $(CP_DIR) $(DIST_FILES) $(TMP_DIST_DIR)/bin ; \ fi Do you find it correct? If so, please install it. Thanks. -- Dani Moncayo