* bug#58981: treesitter-regression with json-mode
2022-11-02 16:16 bug#58979: treesitter-regression with json-mode Johann Höchtl
@ 2022-11-02 16:48 ` Johann Höchtl
2022-11-03 10:50 ` Robert Pluim
2022-11-12 20:34 ` bug#58979: " Stefan Kangas
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Johann Höchtl @ 2022-11-02 16:48 UTC (permalink / raw)
To: 58981
[-- Attachment #1: Type: text/plain, Size: 863 bytes --]
Sorry, disregard, behavior is caused by plugin highlight-indent-guides
Am Mi., 2. Nov. 2022 um 17:16 Uhr schrieb Johann Höchtl <
johann.hoechtl@gmail.com>:
> When I open a large json file (about 3_000_000 lines, about 72Mb,
> pretty-printed) Emacs 29.0.50 opens the file just fine in `js-json-mode`
> and when using regexp-based font locking, it works well.
>
> When I force this buffer into javascript-mode, Emacs hangs. Memory
> consumption as reported by Windows task manager "dances" around 2Gb, yet
> even after waiting for three minutes, Emacs doesn't get responsive any more.
>
> I consider this an unfortunately regression as recent commits to Emacs 29
> (long lines patches) actually makes working with such large files with long
> lines absolutely pleasant, yet as it seems the interaction with tree-sitter
> destroys this gains.
>
[-- Attachment #2: Type: text/html, Size: 1194 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* bug#58979: treesitter-regression with json-mode
2022-11-02 16:16 bug#58979: treesitter-regression with json-mode Johann Höchtl
2022-11-02 16:48 ` bug#58981: " Johann Höchtl
@ 2022-11-12 20:34 ` Stefan Kangas
2022-11-22 7:44 ` Yuan Fu
2023-01-07 23:10 ` Yuan Fu
3 siblings, 0 replies; 6+ messages in thread
From: Stefan Kangas @ 2022-11-12 20:34 UTC (permalink / raw)
To: Johann Höchtl; +Cc: Yuan Fu, 58979
Johann Höchtl <johann.hoechtl@gmail.com> writes:
> When I open a large json file (about 3_000_000 lines, about 72Mb,
> pretty-printed) Emacs 29.0.50 opens the file just fine in
> `js-json-mode` and when using regexp-based font locking, it works
> well.
>
> When I force this buffer into javascript-mode, Emacs hangs. Memory
> consumption as reported by Windows task manager "dances" around 2Gb,
> yet even after waiting for three minutes, Emacs doesn't get responsive
> any more.
>
> I consider this an unfortunately regression as recent commits to Emacs
> 29 (long lines patches) actually makes working with such large files
> with long lines absolutely pleasant, yet as it seems the interaction
> with tree-sitter destroys this gains.
Copying in Yuan Fu.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#58979: treesitter-regression with json-mode
2022-11-02 16:16 bug#58979: treesitter-regression with json-mode Johann Höchtl
2022-11-02 16:48 ` bug#58981: " Johann Höchtl
2022-11-12 20:34 ` bug#58979: " Stefan Kangas
@ 2022-11-22 7:44 ` Yuan Fu
2023-01-07 23:10 ` Yuan Fu
3 siblings, 0 replies; 6+ messages in thread
From: Yuan Fu @ 2022-11-22 7:44 UTC (permalink / raw)
To: Stefan Kangas; +Cc: johann.hoechtl, 58979
Stefan Kangas <stefankangas@gmail.com> writes:
> Johann Höchtl <johann.hoechtl@gmail.com> writes:
>
>> When I open a large json file (about 3_000_000 lines, about 72Mb,
>> pretty-printed) Emacs 29.0.50 opens the file just fine in
>> `js-json-mode` and when using regexp-based font locking, it works
>> well.
>>
>> When I force this buffer into javascript-mode, Emacs hangs. Memory
>> consumption as reported by Windows task manager "dances" around 2Gb,
>> yet even after waiting for three minutes, Emacs doesn't get responsive
>> any more.
>>
>> I consider this an unfortunately regression as recent commits to Emacs
>> 29 (long lines patches) actually makes working with such large files
>> with long lines absolutely pleasant, yet as it seems the interaction
>> with tree-sitter destroys this gains.
>
> Copying in Yuan Fu.
Again, sorry for the delay, I just saw this report :-)
Since your previous report is actually about emacs-tree-sitter, I think
this one is too?
Anyway, since tree-sitter is merged into master now, if you rebuild
master and turn on json-ts-mode, you should be in tree-sitter backed
JSON mode. I’d give that a try and see if works fine.
Thanks,
Yuan
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#58979: treesitter-regression with json-mode
2022-11-02 16:16 bug#58979: treesitter-regression with json-mode Johann Höchtl
` (2 preceding siblings ...)
2022-11-22 7:44 ` Yuan Fu
@ 2023-01-07 23:10 ` Yuan Fu
3 siblings, 0 replies; 6+ messages in thread
From: Yuan Fu @ 2023-01-07 23:10 UTC (permalink / raw)
To: 58979-done
Yuan Fu <casouri@gmail.com> writes:
> Stefan Kangas <stefankangas@gmail.com> writes:
>
>> Johann Höchtl <johann.hoechtl@gmail.com> writes:
>>
>>> When I open a large json file (about 3_000_000 lines, about 72Mb,
>>> pretty-printed) Emacs 29.0.50 opens the file just fine in
>>> `js-json-mode` and when using regexp-based font locking, it works
>>> well.
>>>
>>> When I force this buffer into javascript-mode, Emacs hangs. Memory
>>> consumption as reported by Windows task manager "dances" around 2Gb,
>>> yet even after waiting for three minutes, Emacs doesn't get responsive
>>> any more.
>>>
>>> I consider this an unfortunately regression as recent commits to Emacs
>>> 29 (long lines patches) actually makes working with such large files
>>> with long lines absolutely pleasant, yet as it seems the interaction
>>> with tree-sitter destroys this gains.
>>
>> Copying in Yuan Fu.
>
> Again, sorry for the delay, I just saw this report :-)
>
> Since your previous report is actually about emacs-tree-sitter, I think
> this one is too?
>
> Anyway, since tree-sitter is merged into master now, if you rebuild
> master and turn on json-ts-mode, you should be in tree-sitter backed
> JSON mode. I’d give that a try and see if works fine.
>
> Thanks,
> Yuan
Closing this report since I think there’s nothing to do. Feel free to
reopen.
Yuan
^ permalink raw reply [flat|nested] 6+ messages in thread