From: Aaron Zeng <zeng.aaron.l@gmail.com>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 43677@debbugs.gnu.org
Subject: bug#43677: 27.1; Calc holidays off-by-one error, incorrect business day calculation
Date: Thu, 1 Oct 2020 18:47:58 -0400 [thread overview]
Message-ID: <CAFTimbWpOeT7BQmZ+PXwYCyu3htcPijWR9Ycfe-jMoqxzhVbZQ@mail.gmail.com> (raw)
In-Reply-To: <C0BE148E-FA71-447A-BA91-BECD0F960608@acm.org>
Mattias, that patch seems to work well for me (I tested this by just
loading the lisp into an older version of emacs, since I don't have
experience compiling emacs from source). I don't need business days
for BC dates.
Thanks all for the quick responses.
On Thu, Oct 1, 2020 at 6:19 AM Mattias Engdegård <mattiase@acm.org> wrote:
>
> Aaron, does this patch solve your problem?
>
> It turned out that the ability to select arbitrary holiday weekdays never really worked correctly; the patch attempts to do something about that as well.
>
> The business days code also doesn't work at all very well for BC dates, which of course limits its applicability somewhat but perhaps not critically so. Please tell me if that is something you need fixed.
>
>
>
next prev parent reply other threads:[~2020-10-01 22:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 1:18 bug#43677: 27.1; Calc holidays off-by-one error, incorrect business day calculation Aaron Zeng
2020-09-30 2:50 ` Lars Ingebrigtsen
2020-09-30 8:55 ` Robert Pluim
2020-09-30 9:42 ` Mattias Engdegård
2020-09-30 13:40 ` Lars Ingebrigtsen
2020-09-30 15:52 ` Glenn Morris
2020-09-30 16:22 ` Lars Ingebrigtsen
2020-09-30 16:31 ` Andreas Schwab
2020-09-30 16:12 ` Mattias Engdegård
2020-09-30 16:23 ` Lars Ingebrigtsen
2020-10-01 10:19 ` Mattias Engdegård
2020-10-01 22:47 ` Aaron Zeng [this message]
2020-10-02 10:00 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFTimbWpOeT7BQmZ+PXwYCyu3htcPijWR9Ycfe-jMoqxzhVbZQ@mail.gmail.com \
--to=zeng.aaron.l@gmail.com \
--cc=43677@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).